* [PATCH] media: rcar-csi2: Drop comma after SoC match table sentinel
@ 2022-03-03 12:43 Geert Uytterhoeven
2022-03-03 13:24 ` Niklas Söderlund
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2022-03-03 12:43 UTC (permalink / raw)
To: Niklas Söderlund, Mauro Carvalho Chehab
Cc: linux-media, linux-renesas-soc, Geert Uytterhoeven
It does not make sense to have a comma after a sentinel, as any new
elements must be added before the sentinel.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
index 8c939cb3073d79ec..54428f0a5758ae10 100644
--- a/drivers/media/platform/rcar-vin/rcar-csi2.c
+++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
@@ -1414,7 +1414,7 @@ static const struct soc_device_attribute r8a7795[] = {
.soc_id = "r8a7795", .revision = "ES2.*",
.data = &rcar_csi2_info_r8a7795es2,
},
- { /* sentinel */ },
+ { /* sentinel */ }
};
static int rcsi2_probe(struct platform_device *pdev)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rcar-csi2: Drop comma after SoC match table sentinel
2022-03-03 12:43 [PATCH] media: rcar-csi2: Drop comma after SoC match table sentinel Geert Uytterhoeven
@ 2022-03-03 13:24 ` Niklas Söderlund
0 siblings, 0 replies; 2+ messages in thread
From: Niklas Söderlund @ 2022-03-03 13:24 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Mauro Carvalho Chehab, linux-media, linux-renesas-soc
Hi Geert,
Thanks for your work.
On 2022-03-03 13:43:57 +0100, Geert Uytterhoeven wrote:
> It does not make sense to have a comma after a sentinel, as any new
> elements must be added before the sentinel.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Make sens.
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index 8c939cb3073d79ec..54428f0a5758ae10 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -1414,7 +1414,7 @@ static const struct soc_device_attribute r8a7795[] = {
> .soc_id = "r8a7795", .revision = "ES2.*",
> .data = &rcar_csi2_info_r8a7795es2,
> },
> - { /* sentinel */ },
> + { /* sentinel */ }
> };
>
> static int rcsi2_probe(struct platform_device *pdev)
> --
> 2.25.1
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-03 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 12:43 [PATCH] media: rcar-csi2: Drop comma after SoC match table sentinel Geert Uytterhoeven
2022-03-03 13:24 ` Niklas Söderlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.