From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Shunli Wang <shunli.wang@mediatek.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mediatek: Fix error handling in mt8183_da7219_max98357_dev_probe
Date: Tue, 8 Mar 2022 10:03:10 +0800 [thread overview]
Message-ID: <Yia5XgkGyLbIRc1f@google.com> (raw)
In-Reply-To: <20220307131924.9905-1-linmq006@gmail.com>
On Mon, Mar 07, 2022 at 01:19:21PM +0000, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error paths.
> Fix this by calling of_node_put() in error handling too.
>
> Fixes: ebbddc75bbe8 ("ASoC: Mediatek: MT8183: Add machine driver with DA7219")
I am not sure if the Fixes tag makes sense. ebbddc75bbe8 is the first commit
for the file; however, we have some more commits in between tip and
ebbddc75bbe8.
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
With the minor comment,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Shunli Wang <shunli.wang@mediatek.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mediatek: Fix error handling in mt8183_da7219_max98357_dev_probe
Date: Tue, 8 Mar 2022 10:03:10 +0800 [thread overview]
Message-ID: <Yia5XgkGyLbIRc1f@google.com> (raw)
In-Reply-To: <20220307131924.9905-1-linmq006@gmail.com>
On Mon, Mar 07, 2022 at 01:19:21PM +0000, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error paths.
> Fix this by calling of_node_put() in error handling too.
>
> Fixes: ebbddc75bbe8 ("ASoC: Mediatek: MT8183: Add machine driver with DA7219")
I am not sure if the Fixes tag makes sense. ebbddc75bbe8 is the first commit
for the file; however, we have some more commits in between tip and
ebbddc75bbe8.
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
With the minor comment,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>, Jiaxin Yu <jiaxin.yu@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Shunli Wang <shunli.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: mediatek: Fix error handling in mt8183_da7219_max98357_dev_probe
Date: Tue, 8 Mar 2022 10:03:10 +0800 [thread overview]
Message-ID: <Yia5XgkGyLbIRc1f@google.com> (raw)
In-Reply-To: <20220307131924.9905-1-linmq006@gmail.com>
On Mon, Mar 07, 2022 at 01:19:21PM +0000, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error paths.
> Fix this by calling of_node_put() in error handling too.
>
> Fixes: ebbddc75bbe8 ("ASoC: Mediatek: MT8183: Add machine driver with DA7219")
I am not sure if the Fixes tag makes sense. ebbddc75bbe8 is the first commit
for the file; however, we have some more commits in between tip and
ebbddc75bbe8.
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
With the minor comment,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jiaxin Yu <jiaxin.yu@mediatek.com>,
Shunli Wang <shunli.wang@mediatek.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mediatek: Fix error handling in mt8183_da7219_max98357_dev_probe
Date: Tue, 8 Mar 2022 10:03:10 +0800 [thread overview]
Message-ID: <Yia5XgkGyLbIRc1f@google.com> (raw)
In-Reply-To: <20220307131924.9905-1-linmq006@gmail.com>
On Mon, Mar 07, 2022 at 01:19:21PM +0000, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle() with refcount
> incremented. We should use of_node_put() on it when done.
>
> This function only calls of_node_put() in the regular path.
> And it will cause refcount leak in error paths.
> Fix this by calling of_node_put() in error handling too.
>
> Fixes: ebbddc75bbe8 ("ASoC: Mediatek: MT8183: Add machine driver with DA7219")
I am not sure if the Fixes tag makes sense. ebbddc75bbe8 is the first commit
for the file; however, we have some more commits in between tip and
ebbddc75bbe8.
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
With the minor comment,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-08 2:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 13:19 [PATCH] ASoC: mediatek: Fix error handling in mt8183_da7219_max98357_dev_probe Miaoqian Lin
2022-03-07 13:19 ` Miaoqian Lin
2022-03-07 13:19 ` Miaoqian Lin
2022-03-08 2:03 ` Tzung-Bi Shih [this message]
2022-03-08 2:03 ` Tzung-Bi Shih
2022-03-08 2:03 ` Tzung-Bi Shih
2022-03-08 2:03 ` Tzung-Bi Shih
2022-03-16 1:40 ` [PATCH v2] " Miaoqian Lin
2022-03-16 1:40 ` Miaoqian Lin
2022-03-16 1:40 ` Miaoqian Lin
2022-03-16 2:32 ` Tzung-Bi Shih
2022-03-16 2:32 ` Tzung-Bi Shih
2022-03-16 2:32 ` Tzung-Bi Shih
2022-03-16 2:32 ` Tzung-Bi Shih
2022-03-16 20:35 ` Mark Brown
2022-03-16 20:35 ` Mark Brown
2022-03-16 20:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yia5XgkGyLbIRc1f@google.com \
--to=tzungbi@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=shunli.wang@mediatek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.