* [PATCH] staging: pi433: formatting improvement for multi-line bitwise statement
@ 2022-03-08 8:19 Paulo Miguel Almeida
2022-03-08 13:02 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Paulo Miguel Almeida @ 2022-03-08 8:19 UTC (permalink / raw)
To: gregkh, paulo.miguel.almeida.rodenas, realwakka
Cc: linux-staging, linux-kernel
Move bitwise & operator to the end of previous line for better
readability
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
---
Meta-comments:
This suggestion was made by Dan Carpenter in a previous patch that ended
up being merged:
https://lore.kernel.org/lkml/20220228063238.GA2794@kadam/
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 3f3e863e6cc8..9a55fb29bd54 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -442,8 +442,8 @@ static int pi433_receive(void *data)
/* wait for RSSI level to become high */
dev_dbg(dev->dev, "rx: going to wait for high RSSI level\n");
retval = wait_event_interruptible(dev->rx_wait_queue,
- rf69_read_reg(spi, REG_IRQFLAGS1)
- & MASK_IRQFLAGS1_RSSI);
+ rf69_read_reg(spi, REG_IRQFLAGS1) &
+ MASK_IRQFLAGS1_RSSI);
if (retval) /* wait was interrupted */
goto abort;
dev->interrupt_rx_allowed = false;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: pi433: formatting improvement for multi-line bitwise statement
2022-03-08 8:19 [PATCH] staging: pi433: formatting improvement for multi-line bitwise statement Paulo Miguel Almeida
@ 2022-03-08 13:02 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2022-03-08 13:02 UTC (permalink / raw)
To: Paulo Miguel Almeida; +Cc: gregkh, realwakka, linux-staging, linux-kernel
On Tue, Mar 08, 2022 at 09:19:50PM +1300, Paulo Miguel Almeida wrote:
> Move bitwise & operator to the end of previous line for better
> readability
>
> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
> ---
> Meta-comments:
>
> This suggestion was made by Dan Carpenter in a previous patch that ended
> up being merged:
> https://lore.kernel.org/lkml/20220228063238.GA2794@kadam/
Thanks!
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-08 13:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 8:19 [PATCH] staging: pi433: formatting improvement for multi-line bitwise statement Paulo Miguel Almeida
2022-03-08 13:02 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.