[PATCH] net: phy: marvell: Fix invalid comparison in marvell_{suspend,resume}()

[PATCH] net: phy: marvell: Fix invalid comparison in marvell_{suspend,resume}()

[Kurt Cancemi]

This bug resulted in not resuming and suspending both the fiber and copper
modes. Only the current mode would be suspended.

Signed-off-by: Kurt Cancemi <kurt@x64architecture.com>
---
 drivers/net/phy/marvell.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 2429db614b59..80b888a88127 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -1687,7 +1687,7 @@ static int marvell_suspend(struct phy_device *phydev)
 	int err;
 
 	/* Suspend the fiber mode first */
-	if (!linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
+	if (linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
 			       phydev->supported)) {
 		err = marvell_set_page(phydev, MII_MARVELL_FIBER_PAGE);
 		if (err < 0)
@@ -1722,7 +1722,7 @@ static int marvell_resume(struct phy_device *phydev)
 	int err;
 
 	/* Resume the fiber mode first */
-	if (!linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
+	if (linkmode_test_bit(ETHTOOL_LINK_MODE_FIBRE_BIT,
 			       phydev->supported)) {
 		err = marvell_set_page(phydev, MII_MARVELL_FIBER_PAGE);
 		if (err < 0)
-- 
2.35.1

Re: [PATCH] net: phy: marvell: Fix invalid comparison in marvell_{suspend,resume}()

[Andrew Lunn]

On Fri, Mar 11, 2022 at 10:55:42AM -0500, Kurt Cancemi wrote:
> This bug resulted in not resuming and suspending both the fiber and copper
> modes. Only the current mode would be suspended.
> 
> Signed-off-by: Kurt Cancemi <kurt@x64architecture.com>

Hi Kurt

Please take a look at the netdev FAQ. You should put the tree where
this should be merged into in the subject line.

Since this is a fix, you should also include a Fixes: tag indicating
where the bug was introduces. That helps with backporting.

Fixes: 3758be3dc162 ("Marvell phy: add functions to suspend and resume both interfaces: fiber and copper links.")

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew