From: LABBE Corentin <clabbe@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 17/26] clk: rk3399: use proper crypto0 name
Date: Fri, 25 Mar 2022 08:40:22 +0100 [thread overview]
Message-ID: <Yj1x5hJEKVL71JZ1@Red> (raw)
In-Reply-To: <20220325004125.C80FDC340EC@smtp.kernel.org>
Le Thu, Mar 24, 2022 at 05:41:23PM -0700, Stephen Boyd a écrit :
> Quoting Corentin Labbe (2022-03-21 13:07:30)
> > rk3399 has 2 crypto instance, reset for crypto1 is correctly named, but
> > crypto0 not.
> > Add a 0 to be consistent.
>
> This is OK because nothing is using the define today?
Yes, nothing use this rk3399 define.
>
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > include/dt-bindings/clock/rk3399-cru.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h
> > index 44e0a319f077..39169d94a44e 100644
> > --- a/include/dt-bindings/clock/rk3399-cru.h
> > +++ b/include/dt-bindings/clock/rk3399-cru.h
> > @@ -547,8 +547,8 @@
> > #define SRST_H_PERILP0 171
> > #define SRST_H_PERILP0_NOC 172
> > #define SRST_ROM 173
> > -#define SRST_CRYPTO_S 174
> > -#define SRST_CRYPTO_M 175
> > +#define SRST_CRYPTO0_S 174
> > +#define SRST_CRYPTO0_M 175
> >
> > /* cru_softrst_con11 */
> > #define SRST_P_DCF 176
> > @@ -556,7 +556,7 @@
> > #define SRST_CM0S 178
> > #define SRST_CM0S_DBG 179
> > #define SRST_CM0S_PO 180
> > -#define SRST_CRYPTO 181
> > +#define SRST_CRYPTO0 181
>
> $ git grep SRST_CRYPTO
> Documentation/devicetree/bindings/crypto/rockchip-crypto.txt: resets = <&cru SRST_CRYPTO>;
> arch/arm/boot/dts/rk3288.dtsi: resets = <&cru SRST_CRYPTO>;
>
> Uh oh. Just don't change it and think about something else when it
> starts to feel inconsistent.
This is on rk3288, so not related to rk3399.
Even on the RK3399 TRM, all crypto clocks are called either crypto0 or crypto1 (neither just crypto)
Regards
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 17/26] clk: rk3399: use proper crypto0 name
Date: Fri, 25 Mar 2022 08:40:22 +0100 [thread overview]
Message-ID: <Yj1x5hJEKVL71JZ1@Red> (raw)
In-Reply-To: <20220325004125.C80FDC340EC@smtp.kernel.org>
Le Thu, Mar 24, 2022 at 05:41:23PM -0700, Stephen Boyd a écrit :
> Quoting Corentin Labbe (2022-03-21 13:07:30)
> > rk3399 has 2 crypto instance, reset for crypto1 is correctly named, but
> > crypto0 not.
> > Add a 0 to be consistent.
>
> This is OK because nothing is using the define today?
Yes, nothing use this rk3399 define.
>
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > include/dt-bindings/clock/rk3399-cru.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h
> > index 44e0a319f077..39169d94a44e 100644
> > --- a/include/dt-bindings/clock/rk3399-cru.h
> > +++ b/include/dt-bindings/clock/rk3399-cru.h
> > @@ -547,8 +547,8 @@
> > #define SRST_H_PERILP0 171
> > #define SRST_H_PERILP0_NOC 172
> > #define SRST_ROM 173
> > -#define SRST_CRYPTO_S 174
> > -#define SRST_CRYPTO_M 175
> > +#define SRST_CRYPTO0_S 174
> > +#define SRST_CRYPTO0_M 175
> >
> > /* cru_softrst_con11 */
> > #define SRST_P_DCF 176
> > @@ -556,7 +556,7 @@
> > #define SRST_CM0S 178
> > #define SRST_CM0S_DBG 179
> > #define SRST_CM0S_PO 180
> > -#define SRST_CRYPTO 181
> > +#define SRST_CRYPTO0 181
>
> $ git grep SRST_CRYPTO
> Documentation/devicetree/bindings/crypto/rockchip-crypto.txt: resets = <&cru SRST_CRYPTO>;
> arch/arm/boot/dts/rk3288.dtsi: resets = <&cru SRST_CRYPTO>;
>
> Uh oh. Just don't change it and think about something else when it
> starts to feel inconsistent.
This is on rk3288, so not related to rk3399.
Even on the RK3399 TRM, all crypto clocks are called either crypto0 or crypto1 (neither just crypto)
Regards
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org,
mturquette@baylibre.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 17/26] clk: rk3399: use proper crypto0 name
Date: Fri, 25 Mar 2022 08:40:22 +0100 [thread overview]
Message-ID: <Yj1x5hJEKVL71JZ1@Red> (raw)
In-Reply-To: <20220325004125.C80FDC340EC@smtp.kernel.org>
Le Thu, Mar 24, 2022 at 05:41:23PM -0700, Stephen Boyd a écrit :
> Quoting Corentin Labbe (2022-03-21 13:07:30)
> > rk3399 has 2 crypto instance, reset for crypto1 is correctly named, but
> > crypto0 not.
> > Add a 0 to be consistent.
>
> This is OK because nothing is using the define today?
Yes, nothing use this rk3399 define.
>
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > include/dt-bindings/clock/rk3399-cru.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/rk3399-cru.h b/include/dt-bindings/clock/rk3399-cru.h
> > index 44e0a319f077..39169d94a44e 100644
> > --- a/include/dt-bindings/clock/rk3399-cru.h
> > +++ b/include/dt-bindings/clock/rk3399-cru.h
> > @@ -547,8 +547,8 @@
> > #define SRST_H_PERILP0 171
> > #define SRST_H_PERILP0_NOC 172
> > #define SRST_ROM 173
> > -#define SRST_CRYPTO_S 174
> > -#define SRST_CRYPTO_M 175
> > +#define SRST_CRYPTO0_S 174
> > +#define SRST_CRYPTO0_M 175
> >
> > /* cru_softrst_con11 */
> > #define SRST_P_DCF 176
> > @@ -556,7 +556,7 @@
> > #define SRST_CM0S 178
> > #define SRST_CM0S_DBG 179
> > #define SRST_CM0S_PO 180
> > -#define SRST_CRYPTO 181
> > +#define SRST_CRYPTO0 181
>
> $ git grep SRST_CRYPTO
> Documentation/devicetree/bindings/crypto/rockchip-crypto.txt: resets = <&cru SRST_CRYPTO>;
> arch/arm/boot/dts/rk3288.dtsi: resets = <&cru SRST_CRYPTO>;
>
> Uh oh. Just don't change it and think about something else when it
> starts to feel inconsistent.
This is on rk3288, so not related to rk3399.
Even on the RK3399 TRM, all crypto clocks are called either crypto0 or crypto1 (neither just crypto)
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-25 7:40 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 20:07 [PATCH v3 00/26] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 01/26] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 02/26] crypto: rockchip: do not use uninit variable Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 03/26] crypto: rockchip: do not do custom power management Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 04/26] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 05/26] crypto: rockchip: do not store mode globally Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 06/26] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-22 11:25 ` Robin Murphy
2022-03-22 11:25 ` Robin Murphy
2022-03-22 11:25 ` Robin Murphy
2022-03-23 13:07 ` LABBE Corentin
2022-03-23 13:07 ` LABBE Corentin
2022-03-23 13:07 ` LABBE Corentin
2022-03-21 20:07 ` [PATCH v3 07/26] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 08/26] crypto: rockchip: better handle cipher key Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 09/26] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 10/26] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 11/26] crypto: rockchip: rewrite type Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 12/26] crypto: rockchip: add debugfs Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 13/26] crypto: rockchip: introduce PM Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 14/26] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 15/26] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 16/26] crypto: rockchip: add support for r3399 Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 17/26] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-25 0:41 ` Stephen Boyd
2022-03-25 0:41 ` Stephen Boyd
2022-03-25 0:41 ` Stephen Boyd
2022-03-25 7:40 ` LABBE Corentin [this message]
2022-03-25 7:40 ` LABBE Corentin
2022-03-25 7:40 ` LABBE Corentin
2022-03-25 16:52 ` Stephen Boyd
2022-03-25 16:52 ` Stephen Boyd
2022-03-25 16:52 ` Stephen Boyd
2022-03-21 20:07 ` [PATCH v3 18/26] arm64: dts: rockchip: rk3399: add crypto node Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-22 12:00 ` Robin Murphy
2022-03-22 12:00 ` Robin Murphy
2022-03-22 12:00 ` Robin Murphy
2022-03-23 13:22 ` LABBE Corentin
2022-03-23 13:22 ` LABBE Corentin
2022-03-23 13:22 ` LABBE Corentin
2022-03-23 16:28 ` Heiko Stübner
2022-03-23 16:28 ` Heiko Stübner
2022-03-23 16:28 ` Heiko Stübner
2022-03-21 20:07 ` [PATCH v3 19/26] arm64: dts: rockchip: add rk3328 " Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 20/26] ARM: dts: rk3288: crypto does not need reset-names anymore Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 21/26] dt-bindings: crypto: convert rockchip-crypto to yaml Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-22 1:50 ` Rob Herring
2022-03-22 1:50 ` Rob Herring
2022-03-22 1:50 ` Rob Herring
2022-03-22 9:12 ` LABBE Corentin
2022-03-22 9:12 ` LABBE Corentin
2022-03-22 9:12 ` LABBE Corentin
2022-03-22 18:05 ` Krzysztof Kozlowski
2022-03-22 18:05 ` Krzysztof Kozlowski
2022-03-22 18:05 ` Krzysztof Kozlowski
2022-03-22 18:04 ` Krzysztof Kozlowski
2022-03-22 18:04 ` Krzysztof Kozlowski
2022-03-22 18:04 ` Krzysztof Kozlowski
2022-03-24 16:20 ` LABBE Corentin
2022-03-24 16:20 ` LABBE Corentin
2022-03-24 16:20 ` LABBE Corentin
2022-03-24 18:19 ` Krzysztof Kozlowski
2022-03-24 18:19 ` Krzysztof Kozlowski
2022-03-24 18:19 ` Krzysztof Kozlowski
2022-03-21 20:07 ` [PATCH v3 22/26] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 23/26] crypto: rockchip: Check for maximum frequency of clocks Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 24/26] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 25/26] crypto: rockchip: fix style issue Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` [PATCH v3 26/26] crypto: rockchip: use read_poll_timeout Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
2022-03-21 20:07 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj1x5hJEKVL71JZ1@Red \
--to=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.