From: Pablo Neira Ayuso <pablo@netfilter.org> To: Randy Dunlap <rdunlap@infradead.org> Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, "Jason Wang" <jasowang@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Jens Axboe" <axboe@kernel.dk>, "Amit Shah" <amit@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Eli Cohen" <eli@mellanox.com>, "Saeed Mahameed" <saeedm@nvidia.com>, "Leon Romanovsky" <leon@kernel.org>, "Jozsef Kadlecsik" <kadlec@netfilter.org>, "Florian Westphal" <fw@strlen.de>, "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, "Felipe Balbi" <felipe.balbi@linux.intel.com>, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>, "Krzysztof Opasiak" <k.opasiak@samsung.com>, "Igor Kotrasinski" <i.kotrasinsk@samsung.com>, "Valentina Manea" <valentina.manea.m@gmail.com>, "Shuah Khan" <shuah@kernel.org>, "Shuah Khan" <skhan@linuxfoundation.org>, "Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>, "Joachim Fritschi" <jfritschi@freenet.de>, "Herbert Xu" <herbert@gondor.apana.org.au>, "Thomas Gleixner" <tglx@linutronix.de>, "Steven Rostedt" <rostedt@goodmis.org>, "Ingo Molnar" <mingo@kernel.org>, "Karol Herbst" <karolherbst@gmail.com>, "Pekka Paalanen" <ppaalanen@gmail.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Andy Lutomirski" <luto@kernel.org>, "Peter Zijlstra" <peterz@infradead.org>, "Borislav Petkov" <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit Date: Thu, 17 Mar 2022 16:49:55 +0100 [thread overview] Message-ID: <YjNYo2LKM3smgEJM@salvia> (raw) In-Reply-To: <20220316192010.19001-5-rdunlap@infradead.org> On Wed, Mar 16, 2022 at 12:20:05PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs LGTM. Should I route this through the netfilter tree? > Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > Cc: Jozsef Kadlecsik <kadlec@netfilter.org> > Cc: Florian Westphal <fw@strlen.de> > Cc: netfilter-devel@vger.kernel.org > Cc: coreteam@netfilter.org > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org > --- > net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- lnx-517-rc8.orig/net/ipv4/netfilter/nf_nat_h323.c > +++ lnx-517-rc8/net/ipv4/netfilter/nf_nat_h323.c > @@ -580,7 +580,7 @@ static struct nf_ct_helper_expectfn call > }; > > /****************************************************************************/ > -static int __init init(void) > +static int __init nf_nat_h323_init(void) > { > BUG_ON(set_h245_addr_hook != NULL); > BUG_ON(set_h225_addr_hook != NULL); > @@ -607,7 +607,7 @@ static int __init init(void) > } > > /****************************************************************************/ > -static void __exit fini(void) > +static void __exit nf_nat_h323_fini(void) > { > RCU_INIT_POINTER(set_h245_addr_hook, NULL); > RCU_INIT_POINTER(set_h225_addr_hook, NULL); > @@ -624,8 +624,8 @@ static void __exit fini(void) > } > > /****************************************************************************/ > -module_init(init); > -module_exit(fini); > +module_init(nf_nat_h323_init); > +module_exit(nf_nat_h323_fini); > > MODULE_AUTHOR("Jing Min Zhao <zhaojingmin@users.sourceforge.net>"); > MODULE_DESCRIPTION("H.323 NAT helper");
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org> To: Randy Dunlap <rdunlap@infradead.org> Cc: x86@kernel.org, "Andy Lutomirski" <luto@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, nouveau@lists.freedesktop.org, "Jason Wang" <jasowang@redhat.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Valentina Manea" <valentina.manea.m@gmail.com>, "Krzysztof Opasiak" <k.opasiak@samsung.com>, "Eli Cohen" <eli@mellanox.com>, netdev@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>, "Arnd Bergmann" <arnd@arndb.de>, "Leon Romanovsky" <leon@kernel.org>, linux-rdma@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Jozsef Kadlecsik" <kadlec@netfilter.org>, coreteam@netfilter.org, "Jakub Kicinski" <kuba@kernel.org>, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>, "Joachim Fritschi" <jfritschi@freenet.de>, "Felipe Balbi" <felipe.balbi@linux.intel.com>, "Amit Shah" <amit@kernel.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, linux-block@vger.kernel.org, "Pekka Paalanen" <ppaalanen@gmail.com>, "Borislav Petkov" <bp@alien8.de>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Shuah Khan" <skhan@linuxfoundation.org>, "Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>, virtualization@lists.linux-foundation.org, "Herbert Xu" <herbert@gondor.apana.org.au>, "Jens Axboe" <axboe@kernel.dk>, linux-scsi@vger.kernel.org, "Martin K. Petersen" <martin.petersen@oracle.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, "Florian Westphal" <fw@strlen.de>, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org, "Igor Kotrasinski" <i.kotrasinsk@samsung.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Saeed Mahameed" <saeedm@nvidia.com>, "David S. Miller" <davem@davemloft.net> Subject: Re: [Nouveau] [PATCH 4/9] netfilter: h323: eliminate anonymous module_init & module_exit Date: Thu, 17 Mar 2022 16:49:55 +0100 [thread overview] Message-ID: <YjNYo2LKM3smgEJM@salvia> (raw) In-Reply-To: <20220316192010.19001-5-rdunlap@infradead.org> On Wed, Mar 16, 2022 at 12:20:05PM -0700, Randy Dunlap wrote: > Eliminate anonymous module_init() and module_exit(), which can lead to > confusion or ambiguity when reading System.map, crashes/oops/bugs, > or an initcall_debug log. > > Give each of these init and exit functions unique driver-specific > names to eliminate the anonymous names. > > Example 1: (System.map) > ffffffff832fc78c t init > ffffffff832fc79e t init > ffffffff832fc8f8 t init > > Example 2: (initcall_debug log) > calling init+0x0/0x12 @ 1 > initcall init+0x0/0x12 returned 0 after 15 usecs > calling init+0x0/0x60 @ 1 > initcall init+0x0/0x60 returned 0 after 2 usecs > calling init+0x0/0x9a @ 1 > initcall init+0x0/0x9a returned 0 after 74 usecs LGTM. Should I route this through the netfilter tree? > Fixes: f587de0e2feb ("[NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Pablo Neira Ayuso <pablo@netfilter.org> > Cc: Jozsef Kadlecsik <kadlec@netfilter.org> > Cc: Florian Westphal <fw@strlen.de> > Cc: netfilter-devel@vger.kernel.org > Cc: coreteam@netfilter.org > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org > --- > net/ipv4/netfilter/nf_nat_h323.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- lnx-517-rc8.orig/net/ipv4/netfilter/nf_nat_h323.c > +++ lnx-517-rc8/net/ipv4/netfilter/nf_nat_h323.c > @@ -580,7 +580,7 @@ static struct nf_ct_helper_expectfn call > }; > > /****************************************************************************/ > -static int __init init(void) > +static int __init nf_nat_h323_init(void) > { > BUG_ON(set_h245_addr_hook != NULL); > BUG_ON(set_h225_addr_hook != NULL); > @@ -607,7 +607,7 @@ static int __init init(void) > } > > /****************************************************************************/ > -static void __exit fini(void) > +static void __exit nf_nat_h323_fini(void) > { > RCU_INIT_POINTER(set_h245_addr_hook, NULL); > RCU_INIT_POINTER(set_h225_addr_hook, NULL); > @@ -624,8 +624,8 @@ static void __exit fini(void) > } > > /****************************************************************************/ > -module_init(init); > -module_exit(fini); > +module_init(nf_nat_h323_init); > +module_exit(nf_nat_h323_fini); > > MODULE_AUTHOR("Jing Min Zhao <zhaojingmin@users.sourceforge.net>"); > MODULE_DESCRIPTION("H.323 NAT helper");
next prev parent reply other threads:[~2022-03-17 15:50 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-16 19:20 [PATCH 0/9] treewide: eliminate anonymous module_init & module_exit Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-16 19:20 ` [PATCH 1/9] virtio_blk: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-17 3:26 ` Jason Wang 2022-03-17 3:26 ` [Nouveau] " Jason Wang 2022-03-17 3:26 ` Jason Wang 2022-03-17 8:45 ` Stefan Hajnoczi 2022-03-17 8:45 ` [Nouveau] " Stefan Hajnoczi 2022-03-17 8:45 ` Stefan Hajnoczi 2022-03-20 12:04 ` Michael S. Tsirkin 2022-03-20 12:04 ` [Nouveau] " Michael S. Tsirkin 2022-03-20 12:04 ` Michael S. Tsirkin 2022-03-16 19:20 ` [PATCH 2/9] virtio_console: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-17 15:47 ` Amit Shah 2022-03-17 15:47 ` [Nouveau] " Amit Shah 2022-03-17 15:47 ` Amit Shah 2022-03-17 20:40 ` Randy Dunlap 2022-03-17 20:40 ` [Nouveau] " Randy Dunlap 2022-03-17 20:40 ` Randy Dunlap 2022-03-20 12:04 ` Michael S. Tsirkin 2022-03-20 12:04 ` [Nouveau] " Michael S. Tsirkin 2022-03-20 12:04 ` Michael S. Tsirkin 2022-03-16 19:20 ` [PATCH 3/9] net: mlx5: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-24 18:03 ` Leon Romanovsky 2022-03-24 18:03 ` [Nouveau] " Leon Romanovsky 2022-03-24 18:03 ` Leon Romanovsky 2022-03-16 19:20 ` [PATCH 4/9] netfilter: h323: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-17 3:42 ` Florian Westphal 2022-03-17 15:49 ` Pablo Neira Ayuso [this message] 2022-03-17 15:49 ` [Nouveau] " Pablo Neira Ayuso 2022-03-17 20:42 ` Randy Dunlap 2022-03-17 20:42 ` [Nouveau] " Randy Dunlap 2022-03-17 20:42 ` Randy Dunlap 2022-03-19 22:37 ` Pablo Neira Ayuso 2022-03-16 19:20 ` [PATCH 5/9] virtio-scsi: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-17 3:25 ` Jason Wang 2022-03-17 3:25 ` [Nouveau] " Jason Wang 2022-03-17 3:25 ` Jason Wang 2022-03-17 8:46 ` Stefan Hajnoczi 2022-03-17 8:46 ` [Nouveau] " Stefan Hajnoczi 2022-03-17 8:46 ` Stefan Hajnoczi 2022-03-20 12:04 ` Michael S. Tsirkin 2022-03-20 12:04 ` [Nouveau] " Michael S. Tsirkin 2022-03-20 12:04 ` Michael S. Tsirkin 2022-03-30 3:51 ` Martin K. Petersen 2022-03-30 3:51 ` [Nouveau] " Martin K. Petersen 2022-03-30 3:51 ` Martin K. Petersen 2022-03-16 19:20 ` [PATCH 6/9] usb: gadget: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-17 3:29 ` Ira Weiny 2022-03-17 3:29 ` [Nouveau] " Ira Weiny 2022-03-17 3:29 ` Ira Weiny 2022-03-17 4:59 ` Randy Dunlap 2022-03-17 4:59 ` [Nouveau] " Randy Dunlap 2022-03-17 4:59 ` Randy Dunlap 2022-03-16 19:20 ` [PATCH 7/9] usb: usbip: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-18 22:45 ` Shuah Khan 2022-03-18 22:45 ` [Nouveau] " Shuah Khan 2022-03-16 19:20 ` [PATCH 8/9] x86/crypto: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-04-08 8:31 ` Herbert Xu 2022-04-08 8:31 ` [Nouveau] " Herbert Xu 2022-04-08 8:31 ` Herbert Xu 2022-03-16 19:20 ` [PATCH 9/9] testmmiotrace: " Randy Dunlap 2022-03-16 19:20 ` [Nouveau] " Randy Dunlap 2022-03-16 19:20 ` Randy Dunlap 2022-03-17 2:38 ` Steven Rostedt 2022-03-17 2:38 ` [Nouveau] " Steven Rostedt 2022-03-17 2:38 ` Steven Rostedt 2022-03-17 3:32 ` [PATCH 0/9] treewide: " Ira Weiny 2022-03-17 3:32 ` [Nouveau] " Ira Weiny 2022-03-17 3:32 ` Ira Weiny 2022-03-17 16:11 ` (subset) " Jens Axboe 2022-03-17 16:11 ` [Nouveau] " Jens Axboe 2022-03-17 16:11 ` Jens Axboe 2022-04-07 13:35 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YjNYo2LKM3smgEJM@salvia \ --to=pablo@netfilter.org \ --cc=amit@kernel.org \ --cc=arnd@arndb.de \ --cc=axboe@kernel.dk \ --cc=bigeasy@linutronix.de \ --cc=bp@alien8.de \ --cc=coreteam@netfilter.org \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=eli@mellanox.com \ --cc=felipe.balbi@linux.intel.com \ --cc=fw@strlen.de \ --cc=gregkh@linuxfoundation.org \ --cc=herbert@gondor.apana.org.au \ --cc=hpa@zytor.com \ --cc=i.kotrasinsk@samsung.com \ --cc=jasowang@redhat.com \ --cc=jejb@linux.ibm.com \ --cc=jfritschi@freenet.de \ --cc=jussi.kivilinna@mbnet.fi \ --cc=k.opasiak@samsung.com \ --cc=kadlec@netfilter.org \ --cc=karolherbst@gmail.com \ --cc=kuba@kernel.org \ --cc=leon@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=luto@kernel.org \ --cc=martin.petersen@oracle.com \ --cc=mingo@kernel.org \ --cc=mirq-linux@rere.qmqm.pl \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=netfilter-devel@vger.kernel.org \ --cc=nouveau@lists.freedesktop.org \ --cc=pbonzini@redhat.com \ --cc=peterz@infradead.org \ --cc=ppaalanen@gmail.com \ --cc=rdunlap@infradead.org \ --cc=rostedt@goodmis.org \ --cc=saeedm@nvidia.com \ --cc=shuah@kernel.org \ --cc=skhan@linuxfoundation.org \ --cc=stefanha@redhat.com \ --cc=tglx@linutronix.de \ --cc=valentina.manea.m@gmail.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.