* [PATCH] tty: Use bitwise instead of arithmetic operator for flags
@ 2022-03-18 3:32 Haowen Bai
2022-03-18 12:32 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-18 3:32 UTC (permalink / raw)
To: arnd, gregkh, jirislaby, dsterba, elder, jcmvbkbc
Cc: linux-kernel, Haowen Bai
to make code clear.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/char/pcmcia/synclink_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index 78baba5..e6f2186 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
// BIT7:parity error
// BIT6:framing error
- if (status & (BIT7 + BIT6)) {
+ if (status & (BIT7 | BIT6)) {
if (status & BIT7)
icount->parity++;
else
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tty: Use bitwise instead of arithmetic operator for flags
2022-03-18 3:32 [PATCH] tty: Use bitwise instead of arithmetic operator for flags Haowen Bai
@ 2022-03-18 12:32 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-03-18 12:32 UTC (permalink / raw)
To: Haowen Bai; +Cc: arnd, jirislaby, dsterba, elder, jcmvbkbc, linux-kernel
On Fri, Mar 18, 2022 at 11:32:22AM +0800, Haowen Bai wrote:
> to make code clear.
That is an odd changelog comment. Please read the documentation for how
to write a good changelog text and try again.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 3:32 [PATCH] tty: Use bitwise instead of arithmetic operator for flags Haowen Bai
2022-03-18 12:32 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.