From: Rob Herring <robh@kernel.org>
To: Adrien Thierry <athierry@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <stefan.wahren@i2se.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gaston Gonzalez <gascoar@gmail.com>,
Ojaswin Mujoo <ojaswin98@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711
Date: Wed, 23 Mar 2022 13:44:46 -0500 [thread overview]
Message-ID: <YjtqnktIHajn8skP@robh.at.kernel.org> (raw)
In-Reply-To: <20220315200929.74952-2-athierry@redhat.com>
On Tue, Mar 15, 2022 at 04:09:28PM -0400, Adrien Thierry wrote:
> Add a new compatible string for BCM2711. This is the chip used on the
> Raspberry Pi 4.
>
> Signed-off-by: Adrien Thierry <athierry@redhat.com>
> ---
> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> index e04439b3355b..599bd283df1b 100644
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> @@ -27,6 +27,12 @@ properties:
> - brcm,bcm2836-vchiq
> - const: brcm,bcm2835-vchiq
>
> + - description: BCM2711 based boards
> + items:
> + - enum:
> + - brcm,bcm2711-vchiq
> + - const: brcm,bcm2711-vchiq
Why do you have the same compatible twice?
> +
> reg:
> description: Physical base address and length of the doorbell register pair
> minItems: 1
> --
> 2.35.1
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Adrien Thierry <athierry@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <stefan.wahren@i2se.com>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Gaston Gonzalez <gascoar@gmail.com>,
Ojaswin Mujoo <ojaswin98@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711
Date: Wed, 23 Mar 2022 13:44:46 -0500 [thread overview]
Message-ID: <YjtqnktIHajn8skP@robh.at.kernel.org> (raw)
In-Reply-To: <20220315200929.74952-2-athierry@redhat.com>
On Tue, Mar 15, 2022 at 04:09:28PM -0400, Adrien Thierry wrote:
> Add a new compatible string for BCM2711. This is the chip used on the
> Raspberry Pi 4.
>
> Signed-off-by: Adrien Thierry <athierry@redhat.com>
> ---
> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> index e04439b3355b..599bd283df1b 100644
> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml
> @@ -27,6 +27,12 @@ properties:
> - brcm,bcm2836-vchiq
> - const: brcm,bcm2835-vchiq
>
> + - description: BCM2711 based boards
> + items:
> + - enum:
> + - brcm,bcm2711-vchiq
> + - const: brcm,bcm2711-vchiq
Why do you have the same compatible twice?
> +
> reg:
> description: Physical base address and length of the doorbell register pair
> minItems: 1
> --
> 2.35.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-23 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 20:09 [PATCH 0/2] Add support for bcm2711 in vchiq_arm Adrien Thierry
2022-03-15 20:09 ` Adrien Thierry
2022-03-15 20:09 ` [PATCH 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Adrien Thierry
2022-03-15 20:09 ` Adrien Thierry
2022-03-23 18:44 ` Rob Herring [this message]
2022-03-23 18:44 ` Rob Herring
2022-03-24 17:34 ` Adrien Thierry
2022-03-24 17:34 ` Adrien Thierry
2022-03-15 20:09 ` [PATCH 2/2] staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based RPi Adrien Thierry
2022-03-15 20:09 ` Adrien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjtqnktIHajn8skP@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=athierry@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.