All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example
@ 2022-04-07 19:35 Krzysztof Kozlowski
  2022-04-08  0:33 ` Rob Herring
  2022-04-11  9:14 ` Geert Uytterhoeven
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 19:35 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven,
	Magnus Damm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Consumer examples in the bindings of resource providers are trivial,
useless and duplication of code.  Remove the example code for consumer.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/power/renesas,rcar-sysc.yaml         | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/renesas,rcar-sysc.yaml b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.yaml
index 62a49ca319ec..bd9608c83c3f 100644
--- a/Documentation/devicetree/bindings/power/renesas,rcar-sysc.yaml
+++ b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.yaml
@@ -10,9 +10,11 @@ maintainers:
   - Geert Uytterhoeven <geert+renesas@glider.be>
   - Magnus Damm <magnus.damm@gmail.com>
 
-description:
+description: |
   The R-Car (RZ/G) System Controller provides power management for the CPU
   cores and various coprocessors.
+  The power domain IDs for consumers are defined in header files::
+  include.dt-bindings/power/r8*-sysc.h
 
 properties:
   compatible:
@@ -64,14 +66,3 @@ examples:
             reg = <0xe6180000 0x0200>;
             #power-domain-cells = <1>;
     };
-
-  - |
-    // Power Domain consumers
-    #include <dt-bindings/power/r8a7791-sysc.h>
-
-    cache-controller-0 {
-            compatible = "cache";
-            power-domains = <&sysc R8A7791_PD_CA15_SCU>;
-            cache-unified;
-            cache-level = <2>;
-    };
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example
  2022-04-07 19:35 [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example Krzysztof Kozlowski
@ 2022-04-08  0:33 ` Rob Herring
  2022-04-11  9:14 ` Geert Uytterhoeven
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-04-08  0:33 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Geert Uytterhoeven, linux-kernel,
	Krzysztof Kozlowski, devicetree, Magnus Damm

On Thu, 07 Apr 2022 21:35:42 +0200, Krzysztof Kozlowski wrote:
> Consumer examples in the bindings of resource providers are trivial,
> useless and duplication of code.  Remove the example code for consumer.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/power/renesas,rcar-sysc.yaml         | 15 +++------------
>  1 file changed, 3 insertions(+), 12 deletions(-)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example
  2022-04-07 19:35 [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example Krzysztof Kozlowski
  2022-04-08  0:33 ` Rob Herring
@ 2022-04-11  9:14 ` Geert Uytterhoeven
  2022-04-11  9:51   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-04-11  9:14 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven,
	Magnus Damm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

Hi Krzysztof,

On Thu, Apr 7, 2022 at 9:35 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Consumer examples in the bindings of resource providers are trivial,
> useless and duplication of code.  Remove the example code for consumer.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Thanks for your patch, which is now commit 981a340540381532
("dt-bindings: power: renesas,rcar-sysc: drop useless consumer
example") in dt-rh/for-next.

> --- a/Documentation/devicetree/bindings/power/renesas,rcar-sysc.yaml
> +++ b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.yaml
> @@ -10,9 +10,11 @@ maintainers:
>    - Geert Uytterhoeven <geert+renesas@glider.be>
>    - Magnus Damm <magnus.damm@gmail.com>
>
> -description:
> +description: |
>    The R-Car (RZ/G) System Controller provides power management for the CPU
>    cores and various coprocessors.
> +  The power domain IDs for consumers are defined in header files::
> +  include.dt-bindings/power/r8*-sysc.h

include/dt-bindings/power/r8*-sysc.h?

Or does the period have a special meaning here?

>
>  properties:
>    compatible:

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example
  2022-04-11  9:14 ` Geert Uytterhoeven
@ 2022-04-11  9:51   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-11  9:51 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven,
	Magnus Damm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux Kernel Mailing List

On 11/04/2022 11:14, Geert Uytterhoeven wrote:
>>
>> -description:
>> +description: |
>>    The R-Car (RZ/G) System Controller provides power management for the CPU
>>    cores and various coprocessors.
>> +  The power domain IDs for consumers are defined in header files::
>> +  include.dt-bindings/power/r8*-sysc.h
> 
> include/dt-bindings/power/r8*-sysc.h?
> 
> Or does the period have a special meaning here?

Uh, sorry for this. A typo. Thanks for the report. I will send a fix.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-11  9:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 19:35 [RESEND PATCH] dt-bindings: power: renesas,rcar-sysc: drop useless consumer example Krzysztof Kozlowski
2022-04-08  0:33 ` Rob Herring
2022-04-11  9:14 ` Geert Uytterhoeven
2022-04-11  9:51   ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.