From: Gao Xiang <hsiangkao@linux.alibaba.com> To: Jeffle Xu <jefflexu@linux.alibaba.com> Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com Subject: Re: [PATCH v6 19/22] erofs: register cookie context for data blobs Date: Mon, 28 Mar 2022 17:48:26 +0800 [thread overview] Message-ID: <YkGEasaBSCwfGdj3@B-P7TQMD6M-0146.local> (raw) In-Reply-To: <20220325122223.102958-20-jefflexu@linux.alibaba.com> On Fri, Mar 25, 2022 at 08:22:20PM +0800, Jeffle Xu wrote: > Similar to the multi device mode, erofs could be mounted from multiple > blob files (one bootstrap blob file and optional multiple data blob > files). In this case, each device slot contains the path of > corresponding data blob file. > > Registers corresponding cookie context for each data blob file. > > Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> > --- > fs/erofs/internal.h | 1 + > fs/erofs/super.c | 30 ++++++++++++++++++++++-------- > 2 files changed, 23 insertions(+), 8 deletions(-) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index 6537ededed51..94a118caf580 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -52,6 +52,7 @@ struct erofs_device_info { > struct block_device *bdev; > struct dax_device *dax_dev; Place struct erofs_fscache *fscache; > u64 dax_part_off; > + struct erofs_fscache *blob; Instead here since `blob' is also nydus-specific. Need to update the subject and commit message too. > > u32 blocks; > u32 mapped_blkaddr; > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index de5aeda4aea0..9a6f35e0c22b 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -259,15 +259,28 @@ static int erofs_init_devices(struct super_block *sb, > } > dis = ptr + erofs_blkoff(pos); > > - bdev = blkdev_get_by_path(dif->path, > - FMODE_READ | FMODE_EXCL, > - sb->s_type); > - if (IS_ERR(bdev)) { > - err = PTR_ERR(bdev); > - break; > + if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && > + erofs_is_nodev_mode(sb)) { > + struct erofs_fscache *blob; Same here. Thanks, Gao Xiang
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com> To: Jeffle Xu <jefflexu@linux.alibaba.com> Cc: tianzichen@kuaishou.com, linux-erofs@lists.ozlabs.org, fannaihao@baidu.com, willy@infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, joseph.qi@linux.alibaba.com, linux-cachefs@redhat.com, gregkh@linuxfoundation.org, linux-fsdevel@vger.kernel.org, luodaowen.backend@bytedance.com, gerry@linux.alibaba.com, torvalds@linux-foundation.org Subject: Re: [PATCH v6 19/22] erofs: register cookie context for data blobs Date: Mon, 28 Mar 2022 17:48:26 +0800 [thread overview] Message-ID: <YkGEasaBSCwfGdj3@B-P7TQMD6M-0146.local> (raw) In-Reply-To: <20220325122223.102958-20-jefflexu@linux.alibaba.com> On Fri, Mar 25, 2022 at 08:22:20PM +0800, Jeffle Xu wrote: > Similar to the multi device mode, erofs could be mounted from multiple > blob files (one bootstrap blob file and optional multiple data blob > files). In this case, each device slot contains the path of > corresponding data blob file. > > Registers corresponding cookie context for each data blob file. > > Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> > --- > fs/erofs/internal.h | 1 + > fs/erofs/super.c | 30 ++++++++++++++++++++++-------- > 2 files changed, 23 insertions(+), 8 deletions(-) > > diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h > index 6537ededed51..94a118caf580 100644 > --- a/fs/erofs/internal.h > +++ b/fs/erofs/internal.h > @@ -52,6 +52,7 @@ struct erofs_device_info { > struct block_device *bdev; > struct dax_device *dax_dev; Place struct erofs_fscache *fscache; > u64 dax_part_off; > + struct erofs_fscache *blob; Instead here since `blob' is also nydus-specific. Need to update the subject and commit message too. > > u32 blocks; > u32 mapped_blkaddr; > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index de5aeda4aea0..9a6f35e0c22b 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -259,15 +259,28 @@ static int erofs_init_devices(struct super_block *sb, > } > dis = ptr + erofs_blkoff(pos); > > - bdev = blkdev_get_by_path(dif->path, > - FMODE_READ | FMODE_EXCL, > - sb->s_type); > - if (IS_ERR(bdev)) { > - err = PTR_ERR(bdev); > - break; > + if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && > + erofs_is_nodev_mode(sb)) { > + struct erofs_fscache *blob; Same here. Thanks, Gao Xiang
next prev parent reply other threads:[~2022-03-28 9:48 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-25 12:22 [PATCH v6 00/22] fscache,erofs: fscache-based on-demand read semantics Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 00/22] fscache, erofs: " Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 01/22] fscache: export fscache_end_operation() Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 02/22] cachefiles: extract write routine Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 03/22] cachefiles: notify user daemon with anon_fd when looking up cookie Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 20:52 ` kernel test robot 2022-03-25 20:52 ` kernel test robot 2022-03-25 23:25 ` kernel test robot 2022-03-25 23:25 ` kernel test robot 2022-03-29 6:14 ` [Linux-cachefs] " JeffleXu 2022-03-29 6:14 ` JeffleXu 2022-03-25 12:22 ` [PATCH v6 04/22] cachefiles: notify user daemon when withdrawing cookie Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 05/22] cachefiles: implement on-demand read Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 06/22] cachefiles: enable on-demand read mode Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 07/22] cachefiles: document " Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 08/22] erofs: use meta buffers for erofs_read_superblock() Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 09/22] erofs: make erofs_map_blocks() generally available Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 10/22] erofs: add mode checking helper Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 2:42 ` Gao Xiang 2022-03-28 2:42 ` Gao Xiang 2022-03-28 2:46 ` JeffleXu 2022-03-25 12:22 ` [PATCH v6 11/22] erofs: register global fscache volume Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 12/22] erofs: add cookie context helper functions Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 13:41 ` Gao Xiang 2022-03-25 13:41 ` Gao Xiang 2022-03-28 3:11 ` JeffleXu 2022-03-25 12:22 ` [PATCH v6 13/22] erofs: add anonymous inode managing page cache of blob file Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 13:46 ` [Linux-cachefs] " Gao Xiang 2022-03-25 13:46 ` Gao Xiang 2022-03-25 12:22 ` [PATCH v6 14/22] erofs: add erofs_fscache_read_folios() helper Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 2:49 ` [Linux-cachefs] " Gao Xiang 2022-03-28 2:49 ` Gao Xiang 2022-03-25 12:22 ` [PATCH v6 15/22] erofs: register cookie context for bootstrap blob Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 3:04 ` Gao Xiang 2022-03-28 3:04 ` Gao Xiang 2022-03-28 3:15 ` JeffleXu 2022-03-25 12:22 ` [PATCH v6 16/22] erofs: implement fscache-based metadata read Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 17/22] erofs: implement fscache-based data read for non-inline layout Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 3:14 ` Gao Xiang 2022-03-28 3:14 ` Gao Xiang 2022-03-25 12:22 ` [PATCH v6 18/22] erofs: implement fscache-based data read for inline layout Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-25 12:22 ` [PATCH v6 19/22] erofs: register cookie context for data blobs Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 9:48 ` Gao Xiang [this message] 2022-03-28 9:48 ` Gao Xiang 2022-03-25 12:22 ` [PATCH v6 20/22] erofs: implement fscache-based data read " Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 9:50 ` Gao Xiang 2022-03-28 9:50 ` Gao Xiang 2022-03-25 12:22 ` [PATCH v6 21/22] erofs: implement fscache-based data readahead Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu 2022-03-28 10:55 ` Gao Xiang 2022-03-28 10:55 ` Gao Xiang 2022-03-25 12:22 ` [PATCH v6 22/22] erofs: add 'tag' mount option Jeffle Xu 2022-03-25 12:22 ` Jeffle Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YkGEasaBSCwfGdj3@B-P7TQMD6M-0146.local \ --to=hsiangkao@linux.alibaba.com \ --cc=bo.liu@linux.alibaba.com \ --cc=chao@kernel.org \ --cc=dhowells@redhat.com \ --cc=eguan@linux.alibaba.com \ --cc=fannaihao@baidu.com \ --cc=gerry@linux.alibaba.com \ --cc=gregkh@linuxfoundation.org \ --cc=jefflexu@linux.alibaba.com \ --cc=joseph.qi@linux.alibaba.com \ --cc=linux-cachefs@redhat.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luodaowen.backend@bytedance.com \ --cc=tao.peng@linux.alibaba.com \ --cc=tianzichen@kuaishou.com \ --cc=torvalds@linux-foundation.org \ --cc=willy@infradead.org \ --cc=xiang@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.