From: Vinod Koul <vkoul@kernel.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Krishna Manikandan <mkrishn@codeaurora.org>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells Date: Mon, 28 Mar 2022 22:46:19 +0530 [thread overview] Message-ID: <YkHtY9absUjmqmW7@matsya> (raw) In-Reply-To: <CAA8EJprWoxWwk5EWEfWdLquPR+2=u6V0-v1-+wHMHOk8HiEyNw@mail.gmail.com> On 28-03-22, 19:43, Dmitry Baryshkov wrote: > On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > The DSI node is not a bus and the children do not have unit addresses. > > > > Reported-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > NAK. > DSI panels are children of the DSI device tree node with the reg = <0>; address. > This is the convention used by other platforms too (see e.g. > arch/arm64/boot/dts/freescale/imx8mq-evk.dts). So we should add reg = 0, i will update my dtsi fix > With the DSI split link it is possible to attach two panels to a > single DSI host, so addresses are necessary. > > > --- > > .../bindings/display/msm/dsi-controller-main.yaml | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > index 7095ec3c890d..57f238f72326 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > @@ -51,10 +51,6 @@ properties: > > phy-names: > > const: dsi > > > > - "#address-cells": true > > - > > - "#size-cells": true > > - > > syscon-sfpb: > > description: A phandle to mmss_sfpb syscon node (only for DSIv2). > > $ref: "/schemas/types.yaml#/definitions/phandle" > > @@ -154,9 +150,6 @@ examples: > > reg = <0x0ae94000 0x400>; > > reg-names = "dsi_ctrl"; > > > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > interrupt-parent = <&mdss>; > > interrupts = <4>; > > > > -- > > 2.32.0 > > > > > -- > With best wishes > Dmitry -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Krishna Manikandan <mkrishn@codeaurora.org>, devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, freedreno@lists.freedesktop.org, Sean Paul <sean@poorly.run>, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells Date: Mon, 28 Mar 2022 22:46:19 +0530 [thread overview] Message-ID: <YkHtY9absUjmqmW7@matsya> (raw) In-Reply-To: <CAA8EJprWoxWwk5EWEfWdLquPR+2=u6V0-v1-+wHMHOk8HiEyNw@mail.gmail.com> On 28-03-22, 19:43, Dmitry Baryshkov wrote: > On Mon, 28 Mar 2022 at 18:30, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > > > The DSI node is not a bus and the children do not have unit addresses. > > > > Reported-by: Vinod Koul <vkoul@kernel.org> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > NAK. > DSI panels are children of the DSI device tree node with the reg = <0>; address. > This is the convention used by other platforms too (see e.g. > arch/arm64/boot/dts/freescale/imx8mq-evk.dts). So we should add reg = 0, i will update my dtsi fix > With the DSI split link it is possible to attach two panels to a > single DSI host, so addresses are necessary. > > > --- > > .../bindings/display/msm/dsi-controller-main.yaml | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > index 7095ec3c890d..57f238f72326 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > > @@ -51,10 +51,6 @@ properties: > > phy-names: > > const: dsi > > > > - "#address-cells": true > > - > > - "#size-cells": true > > - > > syscon-sfpb: > > description: A phandle to mmss_sfpb syscon node (only for DSIv2). > > $ref: "/schemas/types.yaml#/definitions/phandle" > > @@ -154,9 +150,6 @@ examples: > > reg = <0x0ae94000 0x400>; > > reg-names = "dsi_ctrl"; > > > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > interrupt-parent = <&mdss>; > > interrupts = <4>; > > > > -- > > 2.32.0 > > > > > -- > With best wishes > Dmitry -- ~Vinod
next prev parent reply other threads:[~2022-03-28 17:16 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-28 15:29 [PATCH] dt-bindings: display: msm: dsi: remove address/size cells Krzysztof Kozlowski 2022-03-28 15:52 ` Krzysztof Kozlowski 2022-03-28 16:43 ` Dmitry Baryshkov 2022-03-28 16:43 ` Dmitry Baryshkov 2022-03-28 17:04 ` Krzysztof Kozlowski 2022-03-28 17:04 ` Krzysztof Kozlowski 2022-03-28 17:16 ` Vinod Koul [this message] 2022-03-28 17:16 ` Vinod Koul 2022-03-28 17:17 ` Krzysztof Kozlowski 2022-03-28 17:17 ` Krzysztof Kozlowski 2022-03-28 18:21 ` Rob Herring 2022-03-28 18:21 ` Rob Herring 2022-03-29 6:31 ` Vinod Koul 2022-03-29 6:31 ` Vinod Koul 2022-03-29 15:52 ` Rob Herring 2022-03-29 15:52 ` Rob Herring 2022-03-31 6:05 ` Vinod Koul 2022-03-31 6:05 ` Vinod Koul 2022-03-31 9:34 ` Dmitry Baryshkov 2022-03-31 9:34 ` Dmitry Baryshkov 2022-03-31 15:51 ` Rob Herring 2022-03-31 15:51 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YkHtY9absUjmqmW7@matsya \ --to=vkoul@kernel.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=krzk+dt@kernel.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mkrishn@codeaurora.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.