All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kirill Tkhai <kirill.tkhai@openvz.org>
Cc: agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com,
	song@kernel.org, linux-kernel@vger.kernel.org,
	khorenko@virtuozzo.com, axboe@kernel.dk,
	linux-block@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 3/4] dm-qcow2: Introduce driver to create block devices over QCOW2 files
Date: Tue, 29 Mar 2022 06:34:13 -0700	[thread overview]
Message-ID: <YkMK1cmWyEJGoMB+@infradead.org> (raw)
In-Reply-To: <164846631540.251310.2398727490395218229.stgit@pro>

On Mon, Mar 28, 2022 at 02:18:35PM +0300, Kirill Tkhai wrote:
> The driver is request based, since this allows to use blk-mq
> merging of request. Driver splits requests itself, and every
> request (i.e., qio) after splitting fits a single cluster.
> (In some cases it is worth to create bigger splits, and this
> is a subject of further optimizations).

Nak, please don't do that.  If you want finer grained processing use
a bio based driver, not a request based one.  This is just getting us
into tons of problems.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Kirill Tkhai <kirill.tkhai@openvz.org>
Cc: axboe@kernel.dk, snitzer@redhat.com,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	song@kernel.org, dm-devel@redhat.com, agk@redhat.com,
	khorenko@virtuozzo.com
Subject: Re: [dm-devel] [PATCH 3/4] dm-qcow2: Introduce driver to create block devices over QCOW2 files
Date: Tue, 29 Mar 2022 06:34:13 -0700	[thread overview]
Message-ID: <YkMK1cmWyEJGoMB+@infradead.org> (raw)
In-Reply-To: <164846631540.251310.2398727490395218229.stgit@pro>

On Mon, Mar 28, 2022 at 02:18:35PM +0300, Kirill Tkhai wrote:
> The driver is request based, since this allows to use blk-mq
> merging of request. Driver splits requests itself, and every
> request (i.e., qio) after splitting fits a single cluster.
> (In some cases it is worth to create bigger splits, and this
> is a subject of further optimizations).

Nak, please don't do that.  If you want finer grained processing use
a bio based driver, not a request based one.  This is just getting us
into tons of problems.

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  parent reply	other threads:[~2022-03-29 13:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 11:18 [PATCH 0/4] dm: Introduce dm-qcow2 driver to attach QCOW2 files as block device Kirill Tkhai
2022-03-28 11:18 ` [dm-devel] " Kirill Tkhai
2022-03-28 11:18 ` [PATCH 1/4] dm: Export dm_complete_request() Kirill Tkhai
2022-03-28 11:18   ` [dm-devel] " Kirill Tkhai
2022-03-28 11:18 ` [PATCH 2/4] dm: Process .io_hints for drivers not having underlying devices Kirill Tkhai
2022-03-28 11:18   ` [dm-devel] " Kirill Tkhai
2022-03-28 11:18 ` [PATCH 3/4] dm-qcow2: Introduce driver to create block devices over QCOW2 files Kirill Tkhai
2022-03-28 11:18   ` [dm-devel] " Kirill Tkhai
2022-03-28 20:03   ` kernel test robot
2022-03-28 20:03     ` kernel test robot
2022-03-28 23:42   ` kernel test robot
2022-03-28 23:42     ` [dm-devel] " kernel test robot
2022-03-29 10:42   ` [PATCH 3/4 v1.5] " Kirill Tkhai
2022-03-29 10:42     ` [dm-devel] " Kirill Tkhai
2022-03-29 13:34   ` Christoph Hellwig [this message]
2022-03-29 13:34     ` [dm-devel] [PATCH 3/4] " Christoph Hellwig
2022-03-29 15:24     ` Kirill Tkhai
2022-03-29 15:24       ` Kirill Tkhai
2022-03-29 22:30       ` Kirill Tkhai
2022-03-29 22:30         ` Kirill Tkhai
2022-03-28 11:18 ` [PATCH 4/4] dm-qcow2: Add helper for working with dm-qcow2 devices Kirill Tkhai
2022-03-28 11:18   ` [dm-devel] " Kirill Tkhai
2022-03-29 13:08 ` [dm-devel] [PATCH 0/4] dm: Introduce dm-qcow2 driver to attach QCOW2 files as block device Christoph Hellwig
2022-03-29 13:08   ` Christoph Hellwig
2022-03-29 15:14   ` Kirill Tkhai
2022-03-29 15:14     ` Kirill Tkhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkMK1cmWyEJGoMB+@infradead.org \
    --to=hch@infradead.org \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=khorenko@virtuozzo.com \
    --cc=kirill.tkhai@openvz.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.