stable-rc: 5.4: blk-mq.h:62:33: error: field 'kobj' has incomplete type

stable-rc: 5.4: blk-mq.h:62:33: error: field 'kobj' has incomplete type

[Naresh Kamboju]

Linux stable-rc 5.4 branch build breaks on all architecture for allnoconfig.

metadata:
    git_describe: v5.4.188-369-ga60d79f382c9
    git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
    git_sha: a60d79f382c91dcb19578178a5032af6ccbf4c89
    kconfig:allnoconfig
    kernel_version: 5.4.189-rc1
    target_arch: x86_64
    toolchain: gcc-11

In file included from include/linux/blk-cgroup.h:25,
                 from include/linux/writeback.h:14,
                 from include/linux/memcontrol.h:22,
                 from include/linux/swap.h:9,
                 from include/linux/suspend.h:5,
                 from arch/x86/kernel/asm-offsets.c:13:
include/linux/blk-mq.h:62:33: error: field 'kobj' has incomplete type
   62 |         struct kobject          kobj;
      |                                 ^~~~
include/linux/blk-mq.h: In function 'blk_mq_rq_from_pdu':
include/linux/blk-mq.h:352:29: error: invalid application of 'sizeof'
to incomplete type 'struct request'
  352 |         return pdu - sizeof(struct request);
      |                             ^~~~~~
include/linux/blk-mq.h: In function 'blk_mq_rq_to_pdu':
include/linux/blk-mq.h:356:19: error: invalid use of undefined type
'struct request'
  356 |         return rq + 1;
      |                   ^
include/linux/blk-mq.h: In function 'request_to_qc_t':
include/linux/blk-mq.h:370:15: error: invalid use of undefined type
'struct request'
  370 |         if (rq->tag != -1)
      |               ^~
include/linux/blk-mq.h:371:26: error: invalid use of undefined type
'struct request'
  371 |                 return rq->tag | (hctx->queue_num << BLK_QC_T_SHIFT);
      |                          ^~
include/linux/blk-mq.h:373:18: error: invalid use of undefined type
'struct request'
  373 |         return rq->internal_tag | (hctx->queue_num << BLK_QC_T_SHIFT) |
      |                  ^~
include/linux/blk-mq.h: In function 'blk_mq_cleanup_rq':
include/linux/blk-mq.h:379:15: error: invalid use of undefined type
'struct request'
  379 |         if (rq->q->mq_ops->cleanup_rq)
      |               ^~
include/linux/blk-mq.h:380:19: error: invalid use of undefined type
'struct request'
  380 |                 rq->q->mq_ops->cleanup_rq(rq);
      |                   ^~
make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

--
Linaro LKFT
https://lkft.linaro.org

[1] https://builds.tuxbuild.com/27KejBvVC9gRN1Yk21Nqn51Ptv6/

Re: stable-rc: 5.4: blk-mq.h:62:33: error: field 'kobj' has incomplete type

[Greg Kroah-Hartman]

On Mon, Apr 04, 2022 at 06:36:01PM +0530, Naresh Kamboju wrote:
> Linux stable-rc 5.4 branch build breaks on all architecture for allnoconfig.
> 
> metadata:
>     git_describe: v5.4.188-369-ga60d79f382c9
>     git_repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
>     git_sha: a60d79f382c91dcb19578178a5032af6ccbf4c89
>     kconfig:allnoconfig
>     kernel_version: 5.4.189-rc1
>     target_arch: x86_64
>     toolchain: gcc-11
> 
> In file included from include/linux/blk-cgroup.h:25,
>                  from include/linux/writeback.h:14,
>                  from include/linux/memcontrol.h:22,
>                  from include/linux/swap.h:9,
>                  from include/linux/suspend.h:5,
>                  from arch/x86/kernel/asm-offsets.c:13:
> include/linux/blk-mq.h:62:33: error: field 'kobj' has incomplete type
>    62 |         struct kobject          kobj;
>       |                                 ^~~~
> include/linux/blk-mq.h: In function 'blk_mq_rq_from_pdu':
> include/linux/blk-mq.h:352:29: error: invalid application of 'sizeof'
> to incomplete type 'struct request'
>   352 |         return pdu - sizeof(struct request);
>       |                             ^~~~~~
> include/linux/blk-mq.h: In function 'blk_mq_rq_to_pdu':
> include/linux/blk-mq.h:356:19: error: invalid use of undefined type
> 'struct request'
>   356 |         return rq + 1;
>       |                   ^
> include/linux/blk-mq.h: In function 'request_to_qc_t':
> include/linux/blk-mq.h:370:15: error: invalid use of undefined type
> 'struct request'
>   370 |         if (rq->tag != -1)
>       |               ^~
> include/linux/blk-mq.h:371:26: error: invalid use of undefined type
> 'struct request'
>   371 |                 return rq->tag | (hctx->queue_num << BLK_QC_T_SHIFT);
>       |                          ^~
> include/linux/blk-mq.h:373:18: error: invalid use of undefined type
> 'struct request'
>   373 |         return rq->internal_tag | (hctx->queue_num << BLK_QC_T_SHIFT) |
>       |                  ^~
> include/linux/blk-mq.h: In function 'blk_mq_cleanup_rq':
> include/linux/blk-mq.h:379:15: error: invalid use of undefined type
> 'struct request'
>   379 |         if (rq->q->mq_ops->cleanup_rq)
>       |               ^~
> include/linux/blk-mq.h:380:19: error: invalid use of undefined type
> 'struct request'
>   380 |                 rq->q->mq_ops->cleanup_rq(rq);
>       |                   ^~
> make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Now fixed up, thanks!

greg k-h