* [PATCH] soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()
@ 2022-03-07 12:58 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-03-07 12:58 UTC (permalink / raw)
To: Andy Gross, Srinivas Kandagatla
Cc: Bjorn Andersson, Vinod Koul, Bard Liao, Pierre-Louis Bossart,
Sanyog Kale, linux-arm-msm, alsa-devel, kernel-janitors
The logical AND && is supposed to be bitwise AND & so it will sometimes
print "connected" instead of "disconnected".
Fixes: 74e79da9fd46 ("soundwire: qcom: add runtime pm support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index f613a41c278a..6ca041f9e449 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1452,7 +1452,7 @@ static bool swrm_wait_for_frame_gen_enabled(struct qcom_swrm_ctrl *swrm)
} while (retry--);
dev_err(swrm->dev, "%s: link status not %s\n", __func__,
- comp_sts && SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
+ comp_sts & SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
return false;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()
@ 2022-03-07 12:58 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-03-07 12:58 UTC (permalink / raw)
To: Andy Gross, Srinivas Kandagatla
Cc: alsa-devel, linux-arm-msm, kernel-janitors, Pierre-Louis Bossart,
Bjorn Andersson, Vinod Koul, Sanyog Kale, Bard Liao
The logical AND && is supposed to be bitwise AND & so it will sometimes
print "connected" instead of "disconnected".
Fixes: 74e79da9fd46 ("soundwire: qcom: add runtime pm support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index f613a41c278a..6ca041f9e449 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1452,7 +1452,7 @@ static bool swrm_wait_for_frame_gen_enabled(struct qcom_swrm_ctrl *swrm)
} while (retry--);
dev_err(swrm->dev, "%s: link status not %s\n", __func__,
- comp_sts && SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
+ comp_sts & SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
return false;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()
2022-03-07 12:58 ` Dan Carpenter
@ 2022-04-05 4:17 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-04-05 4:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, linux-arm-msm, kernel-janitors, Pierre-Louis Bossart,
Bjorn Andersson, Andy Gross, Srinivas Kandagatla, Sanyog Kale,
Bard Liao
On 07-03-22, 15:58, Dan Carpenter wrote:
> The logical AND && is supposed to be bitwise AND & so it will sometimes
> print "connected" instead of "disconnected".
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()
@ 2022-04-05 4:17 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-04-05 4:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Srinivas Kandagatla, Bjorn Andersson, Bard Liao,
Pierre-Louis Bossart, Sanyog Kale, linux-arm-msm, alsa-devel,
kernel-janitors
On 07-03-22, 15:58, Dan Carpenter wrote:
> The logical AND && is supposed to be bitwise AND & so it will sometimes
> print "connected" instead of "disconnected".
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-05 4:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 12:58 [PATCH] soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled() Dan Carpenter
2022-03-07 12:58 ` Dan Carpenter
2022-04-05 4:17 ` Vinod Koul
2022-04-05 4:17 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.