From: Mark Brown <broonie@kernel.org> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH v1 2/4] ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx() Date: Tue, 19 Apr 2022 11:57:26 +0100 [thread overview] Message-ID: <Yl6Vljzvc9nTowEq@sirena.org.uk> (raw) In-Reply-To: <c77d892f-4ff3-f7ad-482f-c9673a3cd86f@linux.intel.com> [-- Attachment #1: Type: text/plain, Size: 308 bytes --] On Mon, Apr 18, 2022 at 04:33:21PM -0500, Pierre-Louis Bossart wrote: > > + if (ret == 0 || err < 0) { > > + ret = err; > > + } > > } > > return err; > cppcheck flags a warning on this patch, I believe we should use "return ret;" here, as done in the other patches of this series? Yes, I think so. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>, stable@vger.kernel.org Subject: Re: [PATCH v1 2/4] ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx() Date: Tue, 19 Apr 2022 11:57:26 +0100 [thread overview] Message-ID: <Yl6Vljzvc9nTowEq@sirena.org.uk> (raw) In-Reply-To: <c77d892f-4ff3-f7ad-482f-c9673a3cd86f@linux.intel.com> [-- Attachment #1: Type: text/plain, Size: 308 bytes --] On Mon, Apr 18, 2022 at 04:33:21PM -0500, Pierre-Louis Bossart wrote: > > + if (ret == 0 || err < 0) { > > + ret = err; > > + } > > } > > return err; > cppcheck flags a warning on this patch, I believe we should use "return ret;" here, as done in the other patches of this series? Yes, I think so. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-19 10:57 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-01 15:56 [PATCH v1 0/4] ASoC: ops: Fix stereo change notifications Mark Brown 2022-02-01 15:56 ` [PATCH v1 1/4] ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw() Mark Brown 2022-02-01 15:56 ` [PATCH v1 2/4] ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx() Mark Brown 2022-04-18 21:33 ` Pierre-Louis Bossart 2022-04-19 10:57 ` Mark Brown [this message] 2022-04-19 10:57 ` Mark Brown 2022-02-01 15:56 ` [PATCH v1 3/4] ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_range() Mark Brown 2022-02-01 15:56 ` [PATCH v1 4/4] ASoC: ops: Fix stereo change notifications in snd_soc_put_xr_sx() Mark Brown 2022-02-03 12:52 ` [PATCH v1 0/4] ASoC: ops: Fix stereo change notifications Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yl6Vljzvc9nTowEq@sirena.org.uk \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=lgirdwood@gmail.com \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.