* [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11 1:35 ` cgel.zte
0 siblings, 0 replies; 6+ messages in thread
From: cgel.zte @ 2022-04-11 1:35 UTC (permalink / raw)
To: sean.wang
Cc: vkoul, matthias.bgg, dmaengine, linux-arm-kernel, linux-mediatek,
linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Using pm_runtime_resume_and_get is more appropriate
for simplifing code
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
index 375e7e647df6..64bad5681447 100644
--- a/drivers/dma/mediatek/mtk-uart-apdma.c
+++ b/drivers/dma/mediatek/mtk-uart-apdma.c
@@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
unsigned int status;
int ret;
- ret = pm_runtime_get_sync(mtkd->ddev.dev);
- if (ret < 0) {
- pm_runtime_put_noidle(chan->device->dev);
+ ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
+ if (ret < 0)
return ret;
- }
mtk_uart_apdma_write(c, VFF_ADDR, 0);
mtk_uart_apdma_write(c, VFF_THRE, 0);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11 1:35 ` cgel.zte
0 siblings, 0 replies; 6+ messages in thread
From: cgel.zte @ 2022-04-11 1:35 UTC (permalink / raw)
To: sean.wang
Cc: vkoul, matthias.bgg, dmaengine, linux-arm-kernel, linux-mediatek,
linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Using pm_runtime_resume_and_get is more appropriate
for simplifing code
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
index 375e7e647df6..64bad5681447 100644
--- a/drivers/dma/mediatek/mtk-uart-apdma.c
+++ b/drivers/dma/mediatek/mtk-uart-apdma.c
@@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
unsigned int status;
int ret;
- ret = pm_runtime_get_sync(mtkd->ddev.dev);
- if (ret < 0) {
- pm_runtime_put_noidle(chan->device->dev);
+ ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
+ if (ret < 0)
return ret;
- }
mtk_uart_apdma_write(c, VFF_ADDR, 0);
mtk_uart_apdma_write(c, VFF_THRE, 0);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11 1:35 ` cgel.zte
0 siblings, 0 replies; 6+ messages in thread
From: cgel.zte @ 2022-04-11 1:35 UTC (permalink / raw)
To: sean.wang
Cc: vkoul, matthias.bgg, dmaengine, linux-arm-kernel, linux-mediatek,
linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Using pm_runtime_resume_and_get is more appropriate
for simplifing code
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
index 375e7e647df6..64bad5681447 100644
--- a/drivers/dma/mediatek/mtk-uart-apdma.c
+++ b/drivers/dma/mediatek/mtk-uart-apdma.c
@@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
unsigned int status;
int ret;
- ret = pm_runtime_get_sync(mtkd->ddev.dev);
- if (ret < 0) {
- pm_runtime_put_noidle(chan->device->dev);
+ ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
+ if (ret < 0)
return ret;
- }
mtk_uart_apdma_write(c, VFF_ADDR, 0);
mtk_uart_apdma_write(c, VFF_THRE, 0);
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
2022-04-11 1:35 ` cgel.zte
(?)
@ 2022-04-11 10:50 ` Vinod Koul
-1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-04-11 10:50 UTC (permalink / raw)
To: cgel.zte
Cc: sean.wang, matthias.bgg, dmaengine, linux-arm-kernel,
linux-mediatek, linux-kernel, Minghao Chi, Zeal Robot
On 11-04-22, 01:35, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
subsystem tag is wrong, pls see gitlog to find the appropriate one
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
Can you explain why it is appropriate?
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index 375e7e647df6..64bad5681447 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
> unsigned int status;
> int ret;
>
> - ret = pm_runtime_get_sync(mtkd->ddev.dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(chan->device->dev);
> + ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
> + if (ret < 0)
> return ret;
> - }
>
> mtk_uart_apdma_write(c, VFF_ADDR, 0);
> mtk_uart_apdma_write(c, VFF_THRE, 0);
> --
> 2.25.1
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11 10:50 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-04-11 10:50 UTC (permalink / raw)
To: cgel.zte
Cc: sean.wang, matthias.bgg, dmaengine, linux-arm-kernel,
linux-mediatek, linux-kernel, Minghao Chi, Zeal Robot
On 11-04-22, 01:35, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
subsystem tag is wrong, pls see gitlog to find the appropriate one
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
Can you explain why it is appropriate?
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index 375e7e647df6..64bad5681447 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
> unsigned int status;
> int ret;
>
> - ret = pm_runtime_get_sync(mtkd->ddev.dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(chan->device->dev);
> + ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
> + if (ret < 0)
> return ret;
> - }
>
> mtk_uart_apdma_write(c, VFF_ADDR, 0);
> mtk_uart_apdma_write(c, VFF_THRE, 0);
> --
> 2.25.1
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11 10:50 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-04-11 10:50 UTC (permalink / raw)
To: cgel.zte
Cc: sean.wang, matthias.bgg, dmaengine, linux-arm-kernel,
linux-mediatek, linux-kernel, Minghao Chi, Zeal Robot
On 11-04-22, 01:35, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
subsystem tag is wrong, pls see gitlog to find the appropriate one
>
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
Can you explain why it is appropriate?
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/dma/mediatek/mtk-uart-apdma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/mediatek/mtk-uart-apdma.c b/drivers/dma/mediatek/mtk-uart-apdma.c
> index 375e7e647df6..64bad5681447 100644
> --- a/drivers/dma/mediatek/mtk-uart-apdma.c
> +++ b/drivers/dma/mediatek/mtk-uart-apdma.c
> @@ -274,11 +274,9 @@ static int mtk_uart_apdma_alloc_chan_resources(struct dma_chan *chan)
> unsigned int status;
> int ret;
>
> - ret = pm_runtime_get_sync(mtkd->ddev.dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(chan->device->dev);
> + ret = pm_runtime_resume_and_get(mtkd->ddev.dev);
> + if (ret < 0)
> return ret;
> - }
>
> mtk_uart_apdma_write(c, VFF_ADDR, 0);
> mtk_uart_apdma_write(c, VFF_THRE, 0);
> --
> 2.25.1
--
~Vinod
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-11 10:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 1:35 [PATCH] drivers: dma: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-11 1:35 ` cgel.zte
2022-04-11 1:35 ` cgel.zte
2022-04-11 10:50 ` Vinod Koul
2022-04-11 10:50 ` Vinod Koul
2022-04-11 10:50 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.