All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml
Date: Tue, 12 Apr 2022 12:10:40 +0300	[thread overview]
Message-ID: <YlVCEIPFQjFs+kwM@atomide.com> (raw)
In-Reply-To: <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org>

Hi,

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220412 08:58]:
> On 11/04/2022 13:18, Tony Lindgren wrote:
> > Some timers on some SoCs are dual mapped, like the ABE timers on omap4
> > and 5. The reg property maxItems must be updated to 2.

So on omap4/5 there are timers with a single IO register and with
dual mapped IO registers.

> (...)
> 
> > +  reg:
> > +    minItems: 1
> > +    maxItems: 2
> > +    description: Timer IO register range
> > +
> 
> Apart from what Grygorii said, it would be useful if you add "if:then:"
> case constraining it per implementation (as I understood from commit msg
> only some use double mapping).
> 
> This looks like:
> https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53

Yes I tried, but see the above. The compatible property is the same for
single mapped and dual mapped timers on the same SoC for omap4/5.

> Similarly should be done for clocks, unless it's impossible (same
> compatible uses different setups of clocks).

It's the same situation for clocks, the same compatible is used for
timers with one clock and timers with two clocks for example on dra7.

I'll check the description again to clarify this, maybe it's not
clear yet.

> BTW, it's a bit confusing it is not a v2...

Oops sorry looks like I forgot to update the version.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml
Date: Tue, 12 Apr 2022 12:10:40 +0300	[thread overview]
Message-ID: <YlVCEIPFQjFs+kwM@atomide.com> (raw)
In-Reply-To: <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org>

Hi,

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220412 08:58]:
> On 11/04/2022 13:18, Tony Lindgren wrote:
> > Some timers on some SoCs are dual mapped, like the ABE timers on omap4
> > and 5. The reg property maxItems must be updated to 2.

So on omap4/5 there are timers with a single IO register and with
dual mapped IO registers.

> (...)
> 
> > +  reg:
> > +    minItems: 1
> > +    maxItems: 2
> > +    description: Timer IO register range
> > +
> 
> Apart from what Grygorii said, it would be useful if you add "if:then:"
> case constraining it per implementation (as I understood from commit msg
> only some use double mapping).
> 
> This looks like:
> https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53

Yes I tried, but see the above. The compatible property is the same for
single mapped and dual mapped timers on the same SoC for omap4/5.

> Similarly should be done for clocks, unless it's impossible (same
> compatible uses different setups of clocks).

It's the same situation for clocks, the same compatible is used for
timers with one clock and timers with two clocks for example on dra7.

I'll check the description again to clarify this, maybe it's not
clear yet.

> BTW, it's a bit confusing it is not a v2...

Oops sorry looks like I forgot to update the version.

Regards,

Tony

  reply	other threads:[~2022-04-12  9:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 11:18 [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Tony Lindgren
2022-04-11 11:18 ` Tony Lindgren
2022-04-11 11:18 ` [PATCH 2/2] dt-bindings: timer: Add compatible for am6 for TI timer-dm Tony Lindgren
2022-04-11 11:18   ` Tony Lindgren
2022-04-12  8:52   ` Krzysztof Kozlowski
2022-04-12  8:52     ` Krzysztof Kozlowski
2022-04-12  8:38 ` [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Grygorii Strashko
2022-04-12  8:38   ` Grygorii Strashko
2022-04-12  8:51   ` Tony Lindgren
2022-04-12  8:51     ` Tony Lindgren
2022-04-12  9:48     ` Grygorii Strashko
2022-04-12  9:48       ` Grygorii Strashko
2022-04-12  9:00 ` Krzysztof Kozlowski
2022-04-12  9:00   ` Krzysztof Kozlowski
2022-04-12  9:10   ` Tony Lindgren [this message]
2022-04-12  9:10     ` Tony Lindgren
2022-04-12  9:13     ` Krzysztof Kozlowski
2022-04-12  9:13       ` Krzysztof Kozlowski
2022-04-12 13:16 [PATCHv3 0/2] Convert TI dmtimer binding " Tony Lindgren
2022-04-12 13:16 ` [PATCH 1/2] dt-bindings: timer: Update TI timer " Tony Lindgren
2022-04-12 13:16   ` Tony Lindgren
2022-04-12 17:06   ` Krzysztof Kozlowski
2022-04-12 17:06     ` Krzysztof Kozlowski
2022-04-13  6:04     ` Tony Lindgren
2022-04-13  6:04       ` Tony Lindgren
2022-04-13  8:09       ` Tony Lindgren
2022-04-13  8:09         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlVCEIPFQjFs+kwM@atomide.com \
    --to=tony@atomide.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.