* [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S
@ 2022-04-12 15:57 Alvin Šipraga
2022-04-12 17:39 ` Andrew Lunn
2022-04-13 13:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Alvin Šipraga @ 2022-04-12 15:57 UTC (permalink / raw)
To: Linus Walleij, Alvin Šipraga, Andrew Lunn, Vivien Didelot,
Florian Fainelli, Vladimir Oltean, David S. Miller,
Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel
From: Alvin Šipraga <alsi@bang-olufsen.dk>
This switch is not even supported, but if someone were to actually put
this compatible string "realtek,rtl8366s" in their device tree, they
would be greeted with a kernel panic because the probe function would
dereference NULL. So let's just remove it.
Link: https://lore.kernel.org/all/CACRpkdYdKZs0WExXc3=0yPNOwP+oOV60HRz7SRoGjZvYHaT=1g@mail.gmail.com/
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
---
drivers/net/dsa/realtek/realtek-smi.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
index 2243d3da55b2..6cec559c90ce 100644
--- a/drivers/net/dsa/realtek/realtek-smi.c
+++ b/drivers/net/dsa/realtek/realtek-smi.c
@@ -546,11 +546,6 @@ static const struct of_device_id realtek_smi_of_match[] = {
.data = &rtl8366rb_variant,
},
#endif
- {
- /* FIXME: add support for RTL8366S and more */
- .compatible = "realtek,rtl8366s",
- .data = NULL,
- },
#if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB)
{
.compatible = "realtek,rtl8365mb",
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S
2022-04-12 15:57 [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S Alvin Šipraga
@ 2022-04-12 17:39 ` Andrew Lunn
2022-04-13 13:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-04-12 17:39 UTC (permalink / raw)
To: Alvin Šipraga
Cc: Linus Walleij, Alvin Šipraga, Vivien Didelot,
Florian Fainelli, Vladimir Oltean, David S. Miller,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
On Tue, Apr 12, 2022 at 05:57:49PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> This switch is not even supported, but if someone were to actually put
> this compatible string "realtek,rtl8366s" in their device tree, they
> would be greeted with a kernel panic because the probe function would
> dereference NULL. So let's just remove it.
>
> Link: https://lore.kernel.org/all/CACRpkdYdKZs0WExXc3=0yPNOwP+oOV60HRz7SRoGjZvYHaT=1g@mail.gmail.com/
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S
2022-04-12 15:57 [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S Alvin Šipraga
2022-04-12 17:39 ` Andrew Lunn
@ 2022-04-13 13:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-04-13 13:50 UTC (permalink / raw)
To: =?utf-8?b?QWx2aW4gxaBpcHJhZ2EgPGFsdmluQHBxcnMuZGs+?=
Cc: linus.walleij, alsi, andrew, vivien.didelot, f.fainelli, olteanv,
davem, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 12 Apr 2022 17:57:49 +0200 you wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> This switch is not even supported, but if someone were to actually put
> this compatible string "realtek,rtl8366s" in their device tree, they
> would be greeted with a kernel panic because the probe function would
> dereference NULL. So let's just remove it.
>
> [...]
Here is the summary with links:
- [net] net: dsa: realtek: don't parse compatible string for RTL8366S
https://git.kernel.org/netdev/net/c/8e925de60dda
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-13 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 15:57 [PATCH net] net: dsa: realtek: don't parse compatible string for RTL8366S Alvin Šipraga
2022-04-12 17:39 ` Andrew Lunn
2022-04-13 13:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.