Re: [PATCH v2 7/7] ARM: dts: qcom: sdx65: Add Shared memory manager support

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	robh+dt@kernel.org, krzk+dt@kernel.org, ulf.hansson@linaro.org,
	agross@kernel.org, manivannan.sadhasivam@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 7/7] ARM: dts: qcom: sdx65: Add Shared memory manager support
Date: Tue, 12 Apr 2022 22:27:14 -0500	[thread overview]
Message-ID: <YlZDEk2Z47GoX/jQ@builder.lan> (raw)
In-Reply-To: <1649670615-21268-8-git-send-email-quic_rohiagar@quicinc.com>

On Mon 11 Apr 04:50 CDT 2022, Rohit Agarwal wrote:

> Add smem node to support shared memory manager on SDX65 platform.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  arch/arm/boot/dts/qcom-sdx65.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index 210e55c..8fef644 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -113,6 +113,12 @@
>  		};
>  	};
>  
> +	smem {
> +		compatible = "qcom,smem";
> +		memory-region = <&smem_mem>;
> +		hwlocks = <&tcsr_mutex 3>;
> +	};

As you only have the single region, please move the compatible and
hwlocks properties into the &smem_mem node (see sm8450.dtsi in arm64 as
an example).

I've applied the other dts changes.

Thanks,
Bjorn

> +
>  	soc: soc {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -- 
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)

From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	ulf.hansson@linaro.org, will@kernel.org,
	linux-mmc@vger.kernel.org, agross@kernel.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	robh+dt@kernel.org, manivannan.sadhasivam@linaro.org,
	krzk+dt@kernel.org, robin.murphy@arm.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/7] ARM: dts: qcom: sdx65: Add Shared memory manager support
Date: Tue, 12 Apr 2022 22:27:14 -0500	[thread overview]
Message-ID: <YlZDEk2Z47GoX/jQ@builder.lan> (raw)
In-Reply-To: <1649670615-21268-8-git-send-email-quic_rohiagar@quicinc.com>

On Mon 11 Apr 04:50 CDT 2022, Rohit Agarwal wrote:

> Add smem node to support shared memory manager on SDX65 platform.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  arch/arm/boot/dts/qcom-sdx65.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index 210e55c..8fef644 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -113,6 +113,12 @@
>  		};
>  	};
>  
> +	smem {
> +		compatible = "qcom,smem";
> +		memory-region = <&smem_mem>;
> +		hwlocks = <&tcsr_mutex 3>;
> +	};

As you only have the single region, please move the compatible and
hwlocks properties into the &smem_mem node (see sm8450.dtsi in arm64 as
an example).

I've applied the other dts changes.

Thanks,
Bjorn

> +
>  	soc: soc {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -- 
> 2.7.4
> 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)

From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	robh+dt@kernel.org, krzk+dt@kernel.org, ulf.hansson@linaro.org,
	agross@kernel.org, manivannan.sadhasivam@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 7/7] ARM: dts: qcom: sdx65: Add Shared memory manager support
Date: Tue, 12 Apr 2022 22:27:14 -0500	[thread overview]
Message-ID: <YlZDEk2Z47GoX/jQ@builder.lan> (raw)
In-Reply-To: <1649670615-21268-8-git-send-email-quic_rohiagar@quicinc.com>

On Mon 11 Apr 04:50 CDT 2022, Rohit Agarwal wrote:

> Add smem node to support shared memory manager on SDX65 platform.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  arch/arm/boot/dts/qcom-sdx65.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index 210e55c..8fef644 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -113,6 +113,12 @@
>  		};
>  	};
>  
> +	smem {
> +		compatible = "qcom,smem";
> +		memory-region = <&smem_mem>;
> +		hwlocks = <&tcsr_mutex 3>;
> +	};

As you only have the single region, please move the compatible and
hwlocks properties into the &smem_mem node (see sm8450.dtsi in arm64 as
an example).

I've applied the other dts changes.

Thanks,
Bjorn

> +
>  	soc: soc {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2022-04-13  3:27 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  9:50 [PATCH v2 0/7] SDX65 devicetree updates Rohit Agarwal
2022-04-11  9:50 ` Rohit Agarwal
2022-04-11  9:50 ` Rohit Agarwal
2022-04-11  9:50 ` [PATCH v2 1/7] ARM: dts: qcom: sdx65: Add reserved memory nodes Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50 ` [PATCH v2 2/7] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-12 11:54   ` Krzysztof Kozlowski
2022-04-12 11:54     ` Krzysztof Kozlowski
2022-04-12 11:54     ` Krzysztof Kozlowski
2022-04-12 14:25   ` Ulf Hansson
2022-04-12 14:25     ` Ulf Hansson
2022-04-12 14:25     ` Ulf Hansson
2022-04-11  9:50 ` [PATCH v2 3/7] ARM: dts: qcom: sdx65: Add support for SDHCI controller Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50 ` [PATCH v2 4/7] dt-bindings: arm-smmu: Add binding for SDX65 SMMU Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-12 11:54   ` Krzysztof Kozlowski
2022-04-12 11:54     ` Krzysztof Kozlowski
2022-04-12 11:54     ` Krzysztof Kozlowski
2022-04-11  9:50 ` [PATCH v2 5/7] ARM: dts: qcom: sdx65: Enable ARM SMMU Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50 ` [PATCH v2 6/7] ARM: dts: qcom: sdx65: Add support for TCSR Mutex Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50 ` [PATCH v2 7/7] ARM: dts: qcom: sdx65: Add Shared memory manager support Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-11  9:50   ` Rohit Agarwal
2022-04-13  3:27   ` Bjorn Andersson [this message]
2022-04-13  3:27     ` Bjorn Andersson
2022-04-13  3:27     ` Bjorn Andersson
2022-05-06 16:07 ` [PATCH v2 0/7] SDX65 devicetree updates Will Deacon
2022-05-06 16:07   ` Will Deacon
2022-05-06 16:07   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlZDEk2Z47GoX/jQ@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_rohiagar@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.