[RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static

[RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static

[kernel test robot]

mm/memory.c:1238:1: warning: symbol 'vma_needs_copy' was not declared. Should it be static?

Fixes: 729c63ce2bbd ("mm/shmem: handle uffd-wp during fork()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 mm/memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index a426c46dd6f68..92cca76bcd3ee 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1234,7 +1234,7 @@ copy_p4d_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma,
  * false when we can speed up fork() by allowing lazy page faults later until
  * when the child accesses the memory range.
  */
-bool
+static bool
 vma_needs_copy(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma)
 {
 	/*

[linux-next:master 3834/3955] mm/memory.c:1238:1: sparse: sparse: symbol 'vma_needs_copy' was not declared. Should it be static?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c97e430ab5539993ab2afc6e80deea80aef9d799
commit: 729c63ce2bbd5813b8061e50cc38187aed05114c [3834/3955] mm/shmem: handle uffd-wp during fork()
config: i386-randconfig-s002 (https://download.01.org/0day-ci/archive/20220414/202204140043.Tx7BIBvI-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=729c63ce2bbd5813b8061e50cc38187aed05114c
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 729c63ce2bbd5813b8061e50cc38187aed05114c
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> mm/memory.c:1238:1: sparse: sparse: symbol 'vma_needs_copy' was not declared. Should it be static?
   mm/memory.c:1031:17: sparse: sparse: context imbalance in 'copy_pte_range' - different lock contexts for basic block
   mm/memory.c:1827:16: sparse: sparse: context imbalance in '__get_locked_pte' - different lock contexts for basic block
   mm/memory.c:1875:9: sparse: sparse: context imbalance in 'insert_page' - different lock contexts for basic block
   mm/memory.c:2377:17: sparse: sparse: context imbalance in 'remap_pte_range' - different lock contexts for basic block
   mm/memory.c:2633:17: sparse: sparse: context imbalance in 'apply_to_pte_range' - unexpected unlock
   mm/memory.c:2922:9: sparse: sparse: context imbalance in 'wp_page_copy' - different lock contexts for basic block
   mm/memory.c:3274:17: sparse: sparse: context imbalance in 'wp_pfn_shared' - unexpected unlock
   mm/memory.c:3341:19: sparse: sparse: context imbalance in 'do_wp_page' - different lock contexts for basic block
   mm/memory.c:5211:5: sparse: sparse: context imbalance in 'follow_invalidate_pte' - wrong count at exit
   mm/memory.c:5332:23: sparse: sparse: context imbalance in 'follow_pfn' - unexpected unlock
   mm/memory.c:5362:9: sparse: sparse: context imbalance in 'follow_phys' - unexpected unlock
   mm/memory.c:5396:9: sparse: sparse: context imbalance in 'generic_access_phys' - unexpected unlock

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static

[Peter Xu]

On Thu, Apr 14, 2022 at 12:02:16AM +0800, kernel test robot wrote:
> mm/memory.c:1238:1: warning: symbol 'vma_needs_copy' was not declared. Should it be static?
> 
> Fixes: 729c63ce2bbd ("mm/shmem: handle uffd-wp during fork()")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

Re: [RFC PATCH linux-next] mm/shmem: vma_needs_copy can be static

[Peter Xu]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

On Thu, Apr 14, 2022 at 12:02:16AM +0800, kernel test robot wrote:
> mm/memory.c:1238:1: warning: symbol 'vma_needs_copy' was not declared. Should it be static?
> 
> Fixes: 729c63ce2bbd ("mm/shmem: handle uffd-wp during fork()")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu