[xfstests-bld PATCH 0/2] Make ntfs3 more usable

[xfstests-bld PATCH 0/2] Make ntfs3 more usable

[Kari Argillander]

Add ntfs3 kernel configs and disable tests which hangs at the moment.

Kari Argillander (2):
  test-appliance: Add exclude file for ntfs3
  kernel-configs: add ntfs3 to current 5.15 configs

 kernel-configs/x86_64-config-5.15                       | 3 +++
 kernel-configs/x86_64-perf-config-5.15                  | 3 +++
 kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude | 8 ++++++++
 3 files changed, 14 insertions(+)
 create mode 100644 kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude

-- 
2.35.1

[xfstests-bld PATCH 1/2] test-appliance: Add exclude file for ntfs3

[Kari Argillander]

From: Kari Argillander <kari.argillander@gmail.com>

There is some hangs which will affect full run. Exclude these for now so
that ntfs3 is easier to run.

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
 kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude b/kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude
new file mode 100644
index 0000000..27160d3
--- /dev/null
+++ b/kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude
@@ -0,0 +1,8 @@
+# These ones hang so badly at the moment that we just ignore them for
+# now.
+generic/014
+generic/129
+
+# This hangs sometimes so for now let's ignore it so that it will not
+# affect full run.
+generic/476
-- 
2.35.1

[xfstests-bld PATCH 2/2] kernel-configs: add ntfs3 to current 5.15 configs

[Kari Argillander]

From: Kari Argillander <kari.argillander@gmail.com>

ntfs3  driver was added to version 5.15 so add it for easier usage.

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
 kernel-configs/x86_64-config-5.15      | 3 +++
 kernel-configs/x86_64-perf-config-5.15 | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/kernel-configs/x86_64-config-5.15 b/kernel-configs/x86_64-config-5.15
index 5bbefbf..a3411a8 100644
--- a/kernel-configs/x86_64-config-5.15
+++ b/kernel-configs/x86_64-config-5.15
@@ -160,6 +160,9 @@ CONFIG_VFAT_FS=y
 CONFIG_FAT_DEFAULT_UTF8=y
 CONFIG_NTFS_FS=y
 CONFIG_NTFS_RW=y
+CONFIG_NTFS3_FS=y
+CONFIG_NTFS3_LZX_XPRESS=y
+CONFIG_NTFS3_FS_POSIX_ACL=y
 CONFIG_PROC_KCORE=y
 CONFIG_PROC_CHILDREN=y
 CONFIG_TMPFS=y
diff --git a/kernel-configs/x86_64-perf-config-5.15 b/kernel-configs/x86_64-perf-config-5.15
index 0c33565..a028329 100644
--- a/kernel-configs/x86_64-perf-config-5.15
+++ b/kernel-configs/x86_64-perf-config-5.15
@@ -156,6 +156,9 @@ CONFIG_VFAT_FS=y
 CONFIG_FAT_DEFAULT_UTF8=y
 CONFIG_NTFS_FS=y
 CONFIG_NTFS_RW=y
+CONFIG_NTFS3_FS=y
+CONFIG_NTFS3_LZX_XPRESS=y
+CONFIG_NTFS3_FS_POSIX_ACL=y
 CONFIG_PROC_KCORE=y
 CONFIG_PROC_CHILDREN=y
 CONFIG_TMPFS=y
-- 
2.35.1

Re: [xfstests-bld PATCH 1/2] test-appliance: Add exclude file for ntfs3

[Darrick J. Wong]

On Fri, Apr 15, 2022 at 02:42:19AM +0300, Kari Argillander wrote:
> From: Kari Argillander <kari.argillander@gmail.com>
> 
> There is some hangs which will affect full run. Exclude these for now so
> that ntfs3 is easier to run.
> 
> Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> ---
>  kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude
> 
> diff --git a/kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude b/kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude
> new file mode 100644
> index 0000000..27160d3
> --- /dev/null
> +++ b/kvm-xfstests/test-appliance/files/root/fs/ntfs3/exclude
> @@ -0,0 +1,8 @@
> +# These ones hang so badly at the moment that we just ignore them for
> +# now.
> +generic/014
> +generic/129
> +
> +# This hangs sometimes so for now let's ignore it so that it will not
> +# affect full run.
> +generic/476

Yikes.  fsstress is enough to knock over ntfs3??!

--D

> -- 
> 2.35.1
> 

Re: [xfstests-bld PATCH 0/2] Make ntfs3 more usable

[Theodore Ts'o]

On Fri, Apr 15, 2022 at 02:42:18AM +0300, Kari Argillander wrote:
> Add ntfs3 kernel configs and disable tests which hangs at the moment.
> 
> Kari Argillander (2):
>   test-appliance: Add exclude file for ntfs3
>   kernel-configs: add ntfs3 to current 5.15 configs

Note that upstream fstests does *not* have support for ntfs3 at the
moment.  I have some admittedly very hacky patches in my personal fork
of xfstests on github, but they use a mix of userspace tools that are
specific for other ntfs file system drivers, since last I checked,
Paragon software has not made open source file system utilities for
ntfs3 available.

The support of ntfs3 in {kvm,gce}-xfstests was experimental in nature
when I was trying to make an assessment about whether ntfs3 was ready
for prime time.  So don't mind applying these patches, but I'm
currently no longer regularly running ntfs3 test runs, and I'm very
much aware that the current ntfs3 support that I had added a while
back into xfstests is definitely not polished or ready for the fstests
maintainer to consider accepting.

Cheers,

					- Ted

Re: [xfstests-bld PATCH 0/2] Make ntfs3 more usable

[Kari Argillander]

On 15.4.2022 7.22, Theodore Ts'o wrote:
> On Fri, Apr 15, 2022 at 02:42:18AM +0300, Kari Argillander wrote:
>> Add ntfs3 kernel configs and disable tests which hangs at the moment.
>>
>> Kari Argillander (2):
>>    test-appliance: Add exclude file for ntfs3
>>    kernel-configs: add ntfs3 to current 5.15 configs
> 
> Note that upstream fstests does *not* have support for ntfs3 at the
> moment.  I have some admittedly very hacky patches in my personal fork
> of xfstests on github, but they use a mix of userspace tools that are
> specific for other ntfs file system drivers, since last I checked,
> Paragon software has not made open source file system utilities for
> ntfs3 available.

Yes I'm fully aware of situation. I just try to make situation little 
bit better and have to start somewhere. Hopefully someone other will 
also start gain interest developing this if tools are easier to use.

> The support of ntfs3 in {kvm,gce}-xfstests was experimental in nature
> when I was trying to make an assessment about whether ntfs3 was ready
> for prime time.  So don't mind applying these patches, but I'm
> currently no longer regularly running ntfs3 test runs, and I'm very
> much aware that the current ntfs3 support that I had added a while
> back into xfstests is definitely not polished or ready for the fstests
> maintainer to consider accepting.
I also planning to do better Xfstests support for ntfs3. Your tool at 
the moment is still only way testing it for new developers so I just 
want it to be little bit easier. I do not except you to run ntfs3. I 
also know about your previes patch. I will polish that to be usable.

I have also made ntfs3 support for Syzkaller and my patch will probably 
be merged this week. It means next week there will probably start coming 
some bug reports from there too. Local Syzkaller run against ntfs3 does 
not see very promising and there will be some bugs. But hey testing 
helps as we see how buggy things are.

Thing is that Konstantin (ntfs3 maintainer) has kept totally radio 
silence after 5.15 was released. I will make own thread about it soon as 
ntfs3 is orphan already. But that will need definitely own thread.

     Argillander

> Cheers,
> 
> 					- Ted