All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, ast@kernel.org,
	daniel@iogearbox.net, kernel-team@fb.com,
	akpm@linux-foundation.org, rick.p.edgecombe@intel.com,
	hch@infradead.org, imbrenda@linux.ibm.com, mcgrof@kernel.org
Subject: Re: [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash
Date: Thu, 14 Apr 2022 23:32:03 -0700	[thread overview]
Message-ID: <YlkRY8QfAdNk+Oso@infradead.org> (raw)
In-Reply-To: <20220414195914.1648345-3-song@kernel.org>

On Thu, Apr 14, 2022 at 12:59:12PM -0700, Song Liu wrote:
> Use __vmalloc_huge() in alloc_large_system_hash() so that large system
> hash (>= PMD_SIZE) could benefit from huge pages. Note that __vmalloc_huge
> only allocates huge pages for systems with HAVE_ARCH_HUGE_VMALLOC.

Looks good (modulo the possible naming chane suggested in patch 1):

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2022-04-15  6:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 19:59 [PATCH v3 bpf RESEND 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Song Liu
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 1/4] vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP Song Liu
2022-04-15  6:31   ` Christoph Hellwig
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 2/4] page_alloc: use __vmalloc_huge for large system hash Song Liu
2022-04-15  6:32   ` Christoph Hellwig [this message]
2022-04-15 16:57     ` Song Liu
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 3/4] module: introduce module_alloc_huge Song Liu
2022-04-14 20:34   ` Luis Chamberlain
2022-04-14 21:03     ` Song Liu
2022-04-14 21:11       ` Luis Chamberlain
2022-04-14 21:31         ` Song Liu
2022-04-15 19:03           ` Luis Chamberlain
2022-04-15  6:32   ` Christoph Hellwig
2022-04-15 15:59     ` Song Liu
2022-04-14 19:59 ` [PATCH v3 bpf RESEND 4/4] bpf: use module_alloc_huge for bpf_prog_pack Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlkRY8QfAdNk+Oso@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=imbrenda@linux.ibm.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.