* [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
@ 2022-04-15 20:53 ` Alaa Mohamed
0 siblings, 0 replies; 8+ messages in thread
From: Alaa Mohamed @ 2022-04-15 20:53 UTC (permalink / raw)
To: outreachy
Cc: jesse.brandeburg, anthony.l.nguyen, davem, kuba, pabeni,
intel-wired-lan, netdev, linux-kernel, ira.weiny,
eng.alaamohamedsoliman.am
The use of kmap() is being deprecated in favor of kmap_local_page()
where it is feasible.
With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible.
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 2a5782063f4c..ba93aa4ae6a0 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
frame_size >>= 1;
- data = kmap(rx_buffer->page);
+ data = kmap_local_page(rx_buffer->page);
if (data[3] != 0xFF ||
data[frame_size + 10] != 0xBE ||
data[frame_size + 12] != 0xAF)
match = false;
- kunmap(rx_buffer->page);
+ kunmap_local(rx_buffer->page);
return match;
}
--
2.35.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
@ 2022-04-15 20:53 ` Alaa Mohamed
0 siblings, 0 replies; 8+ messages in thread
From: Alaa Mohamed @ 2022-04-15 20:53 UTC (permalink / raw)
To: intel-wired-lan
The use of kmap() is being deprecated in favor of kmap_local_page()
where it is feasible.
With kmap_local_page(), the mapping is per thread, CPU local and not
globally visible.
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 2a5782063f4c..ba93aa4ae6a0 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
frame_size >>= 1;
- data = kmap(rx_buffer->page);
+ data = kmap_local_page(rx_buffer->page);
if (data[3] != 0xFF ||
data[frame_size + 10] != 0xBE ||
data[frame_size + 12] != 0xAF)
match = false;
- kunmap(rx_buffer->page);
+ kunmap_local(rx_buffer->page);
return match;
}
--
2.35.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
2022-04-15 20:53 ` [Intel-wired-lan] " Alaa Mohamed
@ 2022-04-15 21:40 ` Ira Weiny
-1 siblings, 0 replies; 8+ messages in thread
From: Ira Weiny @ 2022-04-15 21:40 UTC (permalink / raw)
To: Alaa Mohamed
Cc: outreachy, jesse.brandeburg, anthony.l.nguyen, davem, kuba,
pabeni, intel-wired-lan, netdev, linux-kernel
On Fri, Apr 15, 2022 at 10:53:07PM +0200, Alaa Mohamed wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 2a5782063f4c..ba93aa4ae6a0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
>
> frame_size >>= 1;
>
> - data = kmap(rx_buffer->page);
> + data = kmap_local_page(rx_buffer->page);
>
> if (data[3] != 0xFF ||
> data[frame_size + 10] != 0xBE ||
> data[frame_size + 12] != 0xAF)
> match = false;
>
> - kunmap(rx_buffer->page);
> + kunmap_local(rx_buffer->page);
kunmap_local() is different from kunmap(). It takes an address within the
mapped page. From the kdoc:
/**
* kunmap_local - Unmap a page mapped via kmap_local_page().
* @__addr: An address within the page mapped
*
* @__addr can be any address within the mapped page. Commonly it is the
* address return from kmap_local_page(), but it can also include offsets.
*
* Unmapping should be done in the reverse order of the mapping. See
* kmap_local_page() for details.
*/
#define kunmap_local(__addr) \
...
Ira
>
> return match;
> }
> --
> 2.35.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
@ 2022-04-15 21:40 ` Ira Weiny
0 siblings, 0 replies; 8+ messages in thread
From: Ira Weiny @ 2022-04-15 21:40 UTC (permalink / raw)
To: intel-wired-lan
On Fri, Apr 15, 2022 at 10:53:07PM +0200, Alaa Mohamed wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 2a5782063f4c..ba93aa4ae6a0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
>
> frame_size >>= 1;
>
> - data = kmap(rx_buffer->page);
> + data = kmap_local_page(rx_buffer->page);
>
> if (data[3] != 0xFF ||
> data[frame_size + 10] != 0xBE ||
> data[frame_size + 12] != 0xAF)
> match = false;
>
> - kunmap(rx_buffer->page);
> + kunmap_local(rx_buffer->page);
kunmap_local() is different from kunmap(). It takes an address within the
mapped page. From the kdoc:
/**
* kunmap_local - Unmap a page mapped via kmap_local_page().
* @__addr: An address within the page mapped
*
* @__addr can be any address within the mapped page. Commonly it is the
* address return from kmap_local_page(), but it can also include offsets.
*
* Unmapping should be done in the reverse order of the mapping. See
* kmap_local_page() for details.
*/
#define kunmap_local(__addr) \
...
Ira
>
> return match;
> }
> --
> 2.35.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
2022-04-15 21:40 ` [Intel-wired-lan] " Ira Weiny
@ 2022-04-16 1:33 ` Alaa Mohamed
-1 siblings, 0 replies; 8+ messages in thread
From: Alaa Mohamed @ 2022-04-16 1:33 UTC (permalink / raw)
To: Ira Weiny
Cc: outreachy, jesse.brandeburg, anthony.l.nguyen, davem, kuba,
pabeni, intel-wired-lan, netdev, linux-kernel
On ١٥/٤/٢٠٢٢ ٢٣:٤٠, Ira Weiny wrote:
> On Fri, Apr 15, 2022 at 10:53:07PM +0200, Alaa Mohamed wrote:
>> The use of kmap() is being deprecated in favor of kmap_local_page()
>> where it is feasible.
>>
>> With kmap_local_page(), the mapping is per thread, CPU local and not
>> globally visible.
>>
>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
>> ---
>> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> index 2a5782063f4c..ba93aa4ae6a0 100644
>> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
>>
>> frame_size >>= 1;
>>
>> - data = kmap(rx_buffer->page);
>> + data = kmap_local_page(rx_buffer->page);
>>
>> if (data[3] != 0xFF ||
>> data[frame_size + 10] != 0xBE ||
>> data[frame_size + 12] != 0xAF)
>> match = false;
>>
>> - kunmap(rx_buffer->page);
>> + kunmap_local(rx_buffer->page);
> kunmap_local() is different from kunmap(). It takes an address within the
> mapped page. From the kdoc:
>
> /**
> * kunmap_local - Unmap a page mapped via kmap_local_page().
> * @__addr: An address within the page mapped
> *
> * @__addr can be any address within the mapped page. Commonly it is the
> * address return from kmap_local_page(), but it can also include offsets.
> *
> * Unmapping should be done in the reverse order of the mapping. See
> * kmap_local_page() for details.
> */
> #define kunmap_local(__addr) \
> ...
Got it , Thanks
>
>
> Ira
>
>>
>> return match;
>> }
>> --
>> 2.35.2
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
@ 2022-04-16 1:33 ` Alaa Mohamed
0 siblings, 0 replies; 8+ messages in thread
From: Alaa Mohamed @ 2022-04-16 1:33 UTC (permalink / raw)
To: intel-wired-lan
On ???/??/???? ??:??, Ira Weiny wrote:
> On Fri, Apr 15, 2022 at 10:53:07PM +0200, Alaa Mohamed wrote:
>> The use of kmap() is being deprecated in favor of kmap_local_page()
>> where it is feasible.
>>
>> With kmap_local_page(), the mapping is per thread, CPU local and not
>> globally visible.
>>
>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
>> ---
>> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> index 2a5782063f4c..ba93aa4ae6a0 100644
>> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
>> @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
>>
>> frame_size >>= 1;
>>
>> - data = kmap(rx_buffer->page);
>> + data = kmap_local_page(rx_buffer->page);
>>
>> if (data[3] != 0xFF ||
>> data[frame_size + 10] != 0xBE ||
>> data[frame_size + 12] != 0xAF)
>> match = false;
>>
>> - kunmap(rx_buffer->page);
>> + kunmap_local(rx_buffer->page);
> kunmap_local() is different from kunmap(). It takes an address within the
> mapped page. From the kdoc:
>
> /**
> * kunmap_local - Unmap a page mapped via kmap_local_page().
> * @__addr: An address within the page mapped
> *
> * @__addr can be any address within the mapped page. Commonly it is the
> * address return from kmap_local_page(), but it can also include offsets.
> *
> * Unmapping should be done in the reverse order of the mapping. See
> * kmap_local_page() for details.
> */
> #define kunmap_local(__addr) \
> ...
Got it , Thanks
>
>
> Ira
>
>>
>> return match;
>> }
>> --
>> 2.35.2
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
2022-04-15 20:53 ` [Intel-wired-lan] " Alaa Mohamed
@ 2022-04-16 7:37 ` Julia Lawall
-1 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2022-04-16 7:37 UTC (permalink / raw)
To: Alaa Mohamed
Cc: outreachy, jesse.brandeburg, anthony.l.nguyen, davem, kuba,
pabeni, intel-wired-lan, netdev, linux-kernel, ira.weiny
On Fri, 15 Apr 2022, Alaa Mohamed wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
And why is it feasible here?
julia
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 2a5782063f4c..ba93aa4ae6a0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
>
> frame_size >>= 1;
>
> - data = kmap(rx_buffer->page);
> + data = kmap_local_page(rx_buffer->page);
>
> if (data[3] != 0xFF ||
> data[frame_size + 10] != 0xBE ||
> data[frame_size + 12] != 0xAF)
> match = false;
>
> - kunmap(rx_buffer->page);
> + kunmap_local(rx_buffer->page);
>
> return match;
> }
> --
> 2.35.2
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page()
@ 2022-04-16 7:37 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2022-04-16 7:37 UTC (permalink / raw)
To: intel-wired-lan
On Fri, 15 Apr 2022, Alaa Mohamed wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible.
And why is it feasible here?
julia
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 2a5782063f4c..ba93aa4ae6a0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
>
> frame_size >>= 1;
>
> - data = kmap(rx_buffer->page);
> + data = kmap_local_page(rx_buffer->page);
>
> if (data[3] != 0xFF ||
> data[frame_size + 10] != 0xBE ||
> data[frame_size + 12] != 0xAF)
> match = false;
>
> - kunmap(rx_buffer->page);
> + kunmap_local(rx_buffer->page);
>
> return match;
> }
> --
> 2.35.2
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-16 7:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-15 20:53 [PATCH] intel: igb: igb_ethtool.c: Convert kmap() to kmap_local_page() Alaa Mohamed
2022-04-15 20:53 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-15 21:40 ` Ira Weiny
2022-04-15 21:40 ` [Intel-wired-lan] " Ira Weiny
2022-04-16 1:33 ` Alaa Mohamed
2022-04-16 1:33 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-16 7:37 ` Julia Lawall
2022-04-16 7:37 ` [Intel-wired-lan] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.