From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Johan Hovold <johan+linaro@kernel.org> Cc: Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] phy: qcom-qmp: switch to explicit reset helpers Date: Mon, 2 May 2022 06:02:31 -0700 [thread overview] Message-ID: <Ym/WZ/rftlUGgF6q@ripper> (raw) In-Reply-To: <20220427063243.32576-4-johan+linaro@kernel.org> On Tue 26 Apr 23:32 PDT 2022, Johan Hovold wrote: > Switch to consistently using the explicit reset-controller API which > makes it clear that the reset controllers are used exclusively by the > PHY driver. > > Note that the deprecated of_reset_control_get() and > devm_reset_control_get() are just transitional wrappers for the explicit > API so there's no functional change. > > Suggested-by: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 3f77830921f5..160d723fc773 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -5701,7 +5701,7 @@ static int qcom_qmp_phy_reset_init(struct device *dev, const struct qmp_phy_cfg > struct reset_control *rst; > const char *name = cfg->reset_list[i]; > > - rst = devm_reset_control_get(dev, name); > + rst = devm_reset_control_get_exclusive(dev, name); > if (IS_ERR(rst)) { > dev_err(dev, "failed to get %s reset\n", name); > return PTR_ERR(rst); > @@ -6099,7 +6099,7 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id, > /* Get lane reset, if any */ > if (cfg->has_lane_rst) { > snprintf(prop_name, sizeof(prop_name), "lane%d", id); > - qphy->lane_rst = of_reset_control_get(np, prop_name); > + qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name); > if (IS_ERR(qphy->lane_rst)) { > dev_err(dev, "failed to get lane%d reset\n", id); > return PTR_ERR(qphy->lane_rst); > -- > 2.35.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Johan Hovold <johan+linaro@kernel.org> Cc: Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] phy: qcom-qmp: switch to explicit reset helpers Date: Mon, 2 May 2022 06:02:31 -0700 [thread overview] Message-ID: <Ym/WZ/rftlUGgF6q@ripper> (raw) In-Reply-To: <20220427063243.32576-4-johan+linaro@kernel.org> On Tue 26 Apr 23:32 PDT 2022, Johan Hovold wrote: > Switch to consistently using the explicit reset-controller API which > makes it clear that the reset controllers are used exclusively by the > PHY driver. > > Note that the deprecated of_reset_control_get() and > devm_reset_control_get() are just transitional wrappers for the explicit > API so there's no functional change. > > Suggested-by: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 3f77830921f5..160d723fc773 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -5701,7 +5701,7 @@ static int qcom_qmp_phy_reset_init(struct device *dev, const struct qmp_phy_cfg > struct reset_control *rst; > const char *name = cfg->reset_list[i]; > > - rst = devm_reset_control_get(dev, name); > + rst = devm_reset_control_get_exclusive(dev, name); > if (IS_ERR(rst)) { > dev_err(dev, "failed to get %s reset\n", name); > return PTR_ERR(rst); > @@ -6099,7 +6099,7 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id, > /* Get lane reset, if any */ > if (cfg->has_lane_rst) { > snprintf(prop_name, sizeof(prop_name), "lane%d", id); > - qphy->lane_rst = of_reset_control_get(np, prop_name); > + qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name); > if (IS_ERR(qphy->lane_rst)) { > dev_err(dev, "failed to get lane%d reset\n", id); > return PTR_ERR(qphy->lane_rst); > -- > 2.35.1 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-05-02 13:00 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-27 6:32 [PATCH v2 0/3] phy: qcom-qmp: fix leaks on probe errors Johan Hovold 2022-04-27 6:32 ` Johan Hovold 2022-04-27 6:32 ` [PATCH v2 1/3] phy: qcom-qmp: fix struct clk leak " Johan Hovold 2022-04-27 6:32 ` Johan Hovold 2022-04-27 6:32 ` [PATCH v2 2/3] phy: qcom-qmp: fix reset-controller " Johan Hovold 2022-04-27 6:32 ` Johan Hovold 2022-05-02 13:03 ` Bjorn Andersson 2022-05-02 13:03 ` Bjorn Andersson 2022-04-27 6:32 ` [PATCH v2 3/3] phy: qcom-qmp: switch to explicit reset helpers Johan Hovold 2022-04-27 6:32 ` Johan Hovold 2022-05-02 13:02 ` Bjorn Andersson [this message] 2022-05-02 13:02 ` Bjorn Andersson 2022-05-03 4:41 ` [PATCH v2 0/3] phy: qcom-qmp: fix leaks on probe errors Vinod Koul 2022-05-03 4:41 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Ym/WZ/rftlUGgF6q@ripper \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=johan+linaro@kernel.org \ --cc=kishon@ti.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=p.zabel@pengutronix.de \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.