* [PATCH] PCI: microchip: Add a missing semicolon
@ 2022-04-20 6:58 Uwe Kleine-König
2022-04-20 7:54 ` Conor.Dooley
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2022-04-20 6:58 UTC (permalink / raw)
To: Daire McNamara, Lorenzo Pieralisi
Cc: Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas, linux-pci,
kernel, Ian Cowan, Greg Kroah-Hartman
If the driver is configured as a module (after allowing this by changing
PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the
compiler very unhappy. While there isn't a real problem as
MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver,
do it right for consistency with other drivers.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and
some others) only bool. With this patch applied the driver compiles just
fine with PCIE_MICROCHIP_HOST=m.
Best regards
Uwe
drivers/pci/controller/pcie-microchip-host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c
index 29d8e81e4181..4b1e130f88a3 100644
--- a/drivers/pci/controller/pcie-microchip-host.c
+++ b/drivers/pci/controller/pcie-microchip-host.c
@@ -1115,7 +1115,7 @@ static const struct of_device_id mc_pcie_of_match[] = {
{},
};
-MODULE_DEVICE_TABLE(of, mc_pcie_of_match)
+MODULE_DEVICE_TABLE(of, mc_pcie_of_match);
static struct platform_driver mc_pcie_driver = {
.probe = pci_host_common_probe,
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: microchip: Add a missing semicolon
2022-04-20 6:58 [PATCH] PCI: microchip: Add a missing semicolon Uwe Kleine-König
@ 2022-04-20 7:54 ` Conor.Dooley
2022-04-20 10:40 ` Daire.McNamara
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Conor.Dooley @ 2022-04-20 7:54 UTC (permalink / raw)
To: u.kleine-koenig, Daire.McNamara
Cc: robh, kw, bhelgaas, linux-pci, kernel, ian, gregkh, lorenzo.pieralisi
On 20/04/2022 06:58, Uwe Kleine-König wrote:
> If the driver is configured as a module (after allowing this by changing
> PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the
> compiler very unhappy. While there isn't a real problem as
> MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver,
> do it right for consistency with other drivers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and
> some others) only bool. With this patch applied the driver compiles just
> fine with PCIE_MICROCHIP_HOST=m.
>
> Best regards
> Uwe
I know ~nothing about the PCI driver itself, but I don't see why it wouldn't
work as a module. I gave it a try & nothing has blown up in my face so far...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: microchip: Add a missing semicolon
2022-04-20 6:58 [PATCH] PCI: microchip: Add a missing semicolon Uwe Kleine-König
2022-04-20 7:54 ` Conor.Dooley
@ 2022-04-20 10:40 ` Daire.McNamara
2022-04-20 13:27 ` Rob Herring
2022-04-25 13:02 ` Lorenzo Pieralisi
3 siblings, 0 replies; 6+ messages in thread
From: Daire.McNamara @ 2022-04-20 10:40 UTC (permalink / raw)
To: lorenzo.pieralisi, u.kleine-koenig
Cc: robh, kw, bhelgaas, kernel, linux-pci, gregkh, ian
works fine too. No particular reason to keep it bool.
Acked-by: Daire McNamara <daire.mcnamara@microchip.com>
On Wed, 2022-04-20 at 08:58 +0200, Uwe Kleine-König wrote:
> [You don't often get email from u.kleine-koenig@pengutronix.de. Learn
> why this is important at http://aka.ms/LearnAboutSenderIdentification
> .]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> If the driver is configured as a module (after allowing this by
> changing
> PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon
> makes the
> compiler very unhappy. While there isn't a real problem as
> MODULE_DEVICE_TABLE always evaluates to nothing for a built-in
> driver,
> do it right for consistency with other drivers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST
> (and
> some others) only bool. With this patch applied the driver compiles
> just
> fine with PCIE_MICROCHIP_HOST=m.
>
> Best regards
> Uwe
>
> drivers/pci/controller/pcie-microchip-host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-microchip-host.c
> b/drivers/pci/controller/pcie-microchip-host.c
> index 29d8e81e4181..4b1e130f88a3 100644
> --- a/drivers/pci/controller/pcie-microchip-host.c
> +++ b/drivers/pci/controller/pcie-microchip-host.c
> @@ -1115,7 +1115,7 @@ static const struct of_device_id
> mc_pcie_of_match[] = {
> {},
> };
>
> -MODULE_DEVICE_TABLE(of, mc_pcie_of_match)
> +MODULE_DEVICE_TABLE(of, mc_pcie_of_match);
>
> static struct platform_driver mc_pcie_driver = {
> .probe = pci_host_common_probe,
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: microchip: Add a missing semicolon
2022-04-20 6:58 [PATCH] PCI: microchip: Add a missing semicolon Uwe Kleine-König
2022-04-20 7:54 ` Conor.Dooley
2022-04-20 10:40 ` Daire.McNamara
@ 2022-04-20 13:27 ` Rob Herring
2022-04-20 14:43 ` Uwe Kleine-König
2022-04-25 13:02 ` Lorenzo Pieralisi
3 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2022-04-20 13:27 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Daire McNamara, Lorenzo Pieralisi, Krzysztof Wilczyński,
Bjorn Helgaas, linux-pci, kernel, Ian Cowan, Greg Kroah-Hartman
On Wed, Apr 20, 2022 at 08:58:32AM +0200, Uwe Kleine-König wrote:
> If the driver is configured as a module (after allowing this by changing
> PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the
> compiler very unhappy. While there isn't a real problem as
> MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver,
> do it right for consistency with other drivers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and
> some others) only bool. With this patch applied the driver compiles just
> fine with PCIE_MICROCHIP_HOST=m.
Historical copy-n-paste.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: microchip: Add a missing semicolon
2022-04-20 13:27 ` Rob Herring
@ 2022-04-20 14:43 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2022-04-20 14:43 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Wilczyński, Lorenzo Pieralisi, Daire McNamara,
linux-pci, Ian Cowan, kernel, Greg Kroah-Hartman, Bjorn Helgaas
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On Wed, Apr 20, 2022 at 08:27:05AM -0500, Rob Herring wrote:
> On Wed, Apr 20, 2022 at 08:58:32AM +0200, Uwe Kleine-König wrote:
> > If the driver is configured as a module (after allowing this by changing
> > PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the
> > compiler very unhappy. While there isn't a real problem as
> > MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver,
> > do it right for consistency with other drivers.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> >
> > I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and
> > some others) only bool. With this patch applied the driver compiles just
> > fine with PCIE_MICROCHIP_HOST=m.
>
> Historical copy-n-paste.
For the record: I sent a patch to allow PCIE_MICROCHIP_HOST=m:
https://lore.kernel.org/linux-pci/20220420093449.38054-1-u.kleine-koenig@pengutronix.de
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: microchip: Add a missing semicolon
2022-04-20 6:58 [PATCH] PCI: microchip: Add a missing semicolon Uwe Kleine-König
` (2 preceding siblings ...)
2022-04-20 13:27 ` Rob Herring
@ 2022-04-25 13:02 ` Lorenzo Pieralisi
3 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2022-04-25 13:02 UTC (permalink / raw)
To: Daire McNamara, Uwe Kleine-König
Cc: Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Greg Kroah-Hartman, Ian Cowan, linux-pci, Bjorn Helgaas, kernel
On Wed, 20 Apr 2022 08:58:32 +0200, Uwe Kleine-König wrote:
> If the driver is configured as a module (after allowing this by changing
> PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the
> compiler very unhappy. While there isn't a real problem as
> MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver,
> do it right for consistency with other drivers.
>
>
> [...]
Applied to pci/microchip, thanks!
[1/1] PCI: microchip: Add a missing semicolon
https://git.kernel.org/lpieralisi/pci/c/c049b4b376
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-25 13:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-20 6:58 [PATCH] PCI: microchip: Add a missing semicolon Uwe Kleine-König
2022-04-20 7:54 ` Conor.Dooley
2022-04-20 10:40 ` Daire.McNamara
2022-04-20 13:27 ` Rob Herring
2022-04-20 14:43 ` Uwe Kleine-König
2022-04-25 13:02 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.