Request to cherry-pick c89dffc70b34 to 4.14, 4.19, and 5.4.

Request to cherry-pick c89dffc70b34 to 4.14, 4.19, and 5.4.

[Kuniyuki Iwashima]

Hi maintainers,

Upstream commit 01770a166165 ("tcp: fix race condition when creating child
sockets from syncookies") is planned to be backported to 4.14, 4.19 and
5.4:

  https://marc.info/?l=linux-stable-commits&m=165063781908608&w=3
  https://marc.info/?l=linux-stable-commits&m=165063781708604&w=3
  https://marc.info/?l=linux-stable-commits&m=165063781708603&w=3

Another commit c89dffc70b34 ("tcp: Fix potential use-after-free due to
double kfree()") has a Fixes tag for it, so please backport this also.

Best regards,
Kuniyuki

Re: Request to cherry-pick c89dffc70b34 to 4.14, 4.19, and 5.4.

[Greg Kroah-Hartman]

On Sat, Apr 23, 2022 at 10:07:06AM +0900, Kuniyuki Iwashima wrote:
> Hi maintainers,
> 
> Upstream commit 01770a166165 ("tcp: fix race condition when creating child
> sockets from syncookies") is planned to be backported to 4.14, 4.19 and
> 5.4:
> 
>   https://marc.info/?l=linux-stable-commits&m=165063781908608&w=3
>   https://marc.info/?l=linux-stable-commits&m=165063781708604&w=3
>   https://marc.info/?l=linux-stable-commits&m=165063781708603&w=3
> 
> Another commit c89dffc70b34 ("tcp: Fix potential use-after-free due to
> double kfree()") has a Fixes tag for it, so please backport this also.

Ick, that commit does not apply cleanly.  The people who wanted
01770a166165 should also provide a working version of this fix as well.

thanks,

greg k-h

Re: Request to cherry-pick c89dffc70b34 to 4.14, 4.19, and 5.4.

[Greg Kroah-Hartman]

On Sat, Apr 23, 2022 at 10:58:19AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 23, 2022 at 10:07:06AM +0900, Kuniyuki Iwashima wrote:
> > Hi maintainers,
> > 
> > Upstream commit 01770a166165 ("tcp: fix race condition when creating child
> > sockets from syncookies") is planned to be backported to 4.14, 4.19 and
> > 5.4:
> > 
> >   https://marc.info/?l=linux-stable-commits&m=165063781908608&w=3
> >   https://marc.info/?l=linux-stable-commits&m=165063781708604&w=3
> >   https://marc.info/?l=linux-stable-commits&m=165063781708603&w=3
> > 
> > Another commit c89dffc70b34 ("tcp: Fix potential use-after-free due to
> > double kfree()") has a Fixes tag for it, so please backport this also.
> 
> Ick, that commit does not apply cleanly.  The people who wanted
> 01770a166165 should also provide a working version of this fix as well.

Oh nevermind, I didn't have my queue up to date.  It worked just fine,
sorry for the noise.

greg k-h

Re: Request to cherry-pick c89dffc70b34 to 4.14, 4.19, and 5.4.

[Kuniyuki Iwashima]

From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Sat, 23 Apr 2022 13:00:48 +0200
> On Sat, Apr 23, 2022 at 10:58:19AM +0200, Greg Kroah-Hartman wrote:
> > On Sat, Apr 23, 2022 at 10:07:06AM +0900, Kuniyuki Iwashima wrote:
> > > Hi maintainers,
> > > 
> > > Upstream commit 01770a166165 ("tcp: fix race condition when creating child
> > > sockets from syncookies") is planned to be backported to 4.14, 4.19 and
> > > 5.4:
> > > 
> > >   https://marc.info/?l=linux-stable-commits&m=165063781908608&w=3
> > >   https://marc.info/?l=linux-stable-commits&m=165063781708604&w=3
> > >   https://marc.info/?l=linux-stable-commits&m=165063781708603&w=3
> > > 
> > > Another commit c89dffc70b34 ("tcp: Fix potential use-after-free due to
> > > double kfree()") has a Fixes tag for it, so please backport this also.
> > 
> > Ick, that commit does not apply cleanly.  The people who wanted
> > 01770a166165 should also provide a working version of this fix as well.
> 
> Oh nevermind, I didn't have my queue up to date.  It worked just fine,
> sorry for the noise.

Thanks for queuing up!

Next time I'll send a mail with a backportable-patch, not just commit id :)

Re: Request to cherry-pick c89dffc70b34 to 4.14, 4.19, and 5.4.

[Greg KH]

On Sat, Apr 23, 2022 at 09:23:54PM +0900, Kuniyuki Iwashima wrote:
> From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date:   Sat, 23 Apr 2022 13:00:48 +0200
> > On Sat, Apr 23, 2022 at 10:58:19AM +0200, Greg Kroah-Hartman wrote:
> > > On Sat, Apr 23, 2022 at 10:07:06AM +0900, Kuniyuki Iwashima wrote:
> > > > Hi maintainers,
> > > > 
> > > > Upstream commit 01770a166165 ("tcp: fix race condition when creating child
> > > > sockets from syncookies") is planned to be backported to 4.14, 4.19 and
> > > > 5.4:
> > > > 
> > > >   https://marc.info/?l=linux-stable-commits&m=165063781908608&w=3
> > > >   https://marc.info/?l=linux-stable-commits&m=165063781708604&w=3
> > > >   https://marc.info/?l=linux-stable-commits&m=165063781708603&w=3
> > > > 
> > > > Another commit c89dffc70b34 ("tcp: Fix potential use-after-free due to
> > > > double kfree()") has a Fixes tag for it, so please backport this also.
> > > 
> > > Ick, that commit does not apply cleanly.  The people who wanted
> > > 01770a166165 should also provide a working version of this fix as well.
> > 
> > Oh nevermind, I didn't have my queue up to date.  It worked just fine,
> > sorry for the noise.
> 
> Thanks for queuing up!
> 
> Next time I'll send a mail with a backportable-patch, not just commit id :)

commit id is fine for when I don't do stupid things :)

This is easier than having a backported patch as that way I don't have
to confirm semi-manually that it matches what is in Linus's tree.  So
all is good, keep doing it this way for stuff that applies cleanly.

thanks again,

greg k-h