All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Junwen Wu <wudaemon@163.com>
Cc: adobriyan@gmail.com, akpm@linux-foundation.org, ddiss@suse.de,
	fweimer@redhat.com, keescook@chromium.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] proc: limit schedstate node write operation
Date: Sun, 24 Apr 2022 20:23:17 +0100	[thread overview]
Message-ID: <YmWjpWWdwN0qxFSR@casper.infradead.org> (raw)
In-Reply-To: <YmNs+i/unWKvj4Kx@casper.infradead.org>

On Sun, Apr 24, 2022 at 03:23:54PM +0000, Junwen Wu wrote:
> From: Matthew Wilcox <willy@infradead.org>
> 
> On Sat, Apr 23, 2022 at 02:31:04AM +0000, Junwen Wu wrote:
> > Whatever value is written to /proc/$pid/sched, a task's schedstate data
> > will reset.In some cases, schedstate will drop by accident. We restrict
> > writing a certain value to this node before the data is reset.
> 
> ... and break the existing scripts which expect the current behaviour.
> 
> 
> Hi, Matthew,can you describe it in more detail.

What detail do you need?  Existing scripts depend on the existing
behaviour.  Your change to the behaviour will break them.  That's not
allowed, so your patch is rejected.

WARNING: multiple messages have this Message-ID (diff)
From: Junwen Wu <wudaemon@163.com>
To: willy@infradead.org, Junwen Wu <wudaemon@163.com>
Cc: adobriyan@gmail.com, akpm@linux-foundation.org, ddiss@suse.de,
	fweimer@redhat.com, keescook@chromium.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] proc: limit schedstate node write operation
Date: Sat, 30 Apr 2022 13:48:04 +0000	[thread overview]
Message-ID: <YmWjpWWdwN0qxFSR@casper.infradead.org> (raw) (raw)
Message-ID: <20220430134804.Ar0IZzDtXU90u5wAlSNgagGOKft2cryPqCY3wCuZ-Rg@z> (raw)
In-Reply-To: <YmNs+i/unWKvj4Kx@casper.infradead.org>

From: Matthew Wilcox <willy@infradead.org>

On Sun, Apr 24, 2022 at 03:23:54PM +0000, Junwen Wu wrote:
> From: Matthew Wilcox <willy@infradead.org>
> 
> On Sat, Apr 23, 2022 at 02:31:04AM +0000, Junwen Wu wrote:
> > Whatever value is written to /proc/$pid/sched, a task's schedstate data
> > will reset.In some cases, schedstate will drop by accident. We restrict
> > writing a certain value to this node before the data is reset.
> 
> ... and break the existing scripts which expect the current behaviour.
> 
> 
> Hi, Matthew,can you describe it in more detail.

> What detail do you need?  Existing scripts depend on the existing
> behaviour.  Your change to the behaviour will break them.  That's not
> allowed, so your patch is rejected.

ooh ,just how to operate the node make the script break. I write data to
this node can work well.

Thanks


  reply	other threads:[~2022-04-24 19:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23  2:31 [PATCH v1] proc: limit schedstate node write operation Junwen Wu
2022-04-23  3:05 ` Matthew Wilcox
2022-04-24 15:23   ` Junwen Wu
2022-04-24 19:23   ` Matthew Wilcox [this message]
2022-04-30 13:48     ` Junwen Wu
2022-04-23  4:26 ` kernel test robot
2022-04-24 15:27   ` Junwen Wu
2022-04-24 15:27 ` Junwen Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmWjpWWdwN0qxFSR@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddiss@suse.de \
    --cc=fweimer@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wudaemon@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.