All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions.
@ 2022-04-25  3:42 Ethan Yang
  2022-04-25  3:55 ` [PATCH v2] " Ethan Yang
  0 siblings, 1 reply; 7+ messages in thread
From: Ethan Yang @ 2022-04-25  3:42 UTC (permalink / raw)
  To: johan, gregkh, linux-usb, linux-kernel; +Cc: gchiang, Ethan Yang

add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions.

Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
---
 drivers/usb/serial/qcserial.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index c18bf8164bc2..38e70a573e2c 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -166,6 +166,8 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x1199, 0x9090)},	/* Sierra Wireless EM7565 QDL */
 	{DEVICE_SWI(0x1199, 0x9091)},	/* Sierra Wireless EM7565 */
 	{DEVICE_SWI(0x1199, 0x90d2)},	/* Sierra Wireless EM9191 QDL */
+	{DEVICE_SWI(0x1199, 0xc080)},	/* Sierra Wireless EM7590 */
+	{DEVICE_SWI(0x1199, 0xc081)},	/* Sierra Wireless EM7590 QDL */
 	{DEVICE_SWI(0x413c, 0x81a2)},	/* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
 	{DEVICE_SWI(0x413c, 0x81a3)},	/* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
 	{DEVICE_SWI(0x413c, 0x81a4)},	/* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2] add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions.
  2022-04-25  3:42 [PATCH] add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions Ethan Yang
@ 2022-04-25  3:55 ` Ethan Yang
  2022-04-25  5:18   ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Ethan Yang @ 2022-04-25  3:55 UTC (permalink / raw)
  To: johan, gregkh, linux-usb, linux-kernel; +Cc: gchiang, ipis.yang, Ethan Yang

add support for Sierra Wireless EM7590 0xc080 and 0xc081

Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
---
 drivers/usb/serial/qcserial.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index c18bf8164bc2..586ef5551e76 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -166,6 +166,8 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x1199, 0x9090)},	/* Sierra Wireless EM7565 QDL */
 	{DEVICE_SWI(0x1199, 0x9091)},	/* Sierra Wireless EM7565 */
 	{DEVICE_SWI(0x1199, 0x90d2)},	/* Sierra Wireless EM9191 QDL */
+	{DEVICE_SWI(0x1199, 0xc080)},	/* Sierra Wireless EM7590 QDL */
+	{DEVICE_SWI(0x1199, 0xc081)},	/* Sierra Wireless EM7590 */
 	{DEVICE_SWI(0x413c, 0x81a2)},	/* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
 	{DEVICE_SWI(0x413c, 0x81a3)},	/* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
 	{DEVICE_SWI(0x413c, 0x81a4)},	/* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions.
  2022-04-25  3:55 ` [PATCH v2] " Ethan Yang
@ 2022-04-25  5:18   ` Greg KH
  2022-04-25  5:58     ` [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590 ipis.yang
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2022-04-25  5:18 UTC (permalink / raw)
  To: Ethan Yang; +Cc: johan, linux-usb, linux-kernel, gchiang, Ethan Yang

On Mon, Apr 25, 2022 at 11:55:20AM +0800, Ethan Yang wrote:
> add support for Sierra Wireless EM7590 0xc080 and 0xc081
> 
> Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
> ---
>  drivers/usb/serial/qcserial.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> index c18bf8164bc2..586ef5551e76 100644
> --- a/drivers/usb/serial/qcserial.c
> +++ b/drivers/usb/serial/qcserial.c
> @@ -166,6 +166,8 @@ static const struct usb_device_id id_table[] = {
>  	{DEVICE_SWI(0x1199, 0x9090)},	/* Sierra Wireless EM7565 QDL */
>  	{DEVICE_SWI(0x1199, 0x9091)},	/* Sierra Wireless EM7565 */
>  	{DEVICE_SWI(0x1199, 0x90d2)},	/* Sierra Wireless EM9191 QDL */
> +	{DEVICE_SWI(0x1199, 0xc080)},	/* Sierra Wireless EM7590 QDL */
> +	{DEVICE_SWI(0x1199, 0xc081)},	/* Sierra Wireless EM7590 */
>  	{DEVICE_SWI(0x413c, 0x81a2)},	/* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
>  	{DEVICE_SWI(0x413c, 0x81a3)},	/* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
>  	{DEVICE_SWI(0x413c, 0x81a4)},	/* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
> -- 
> 2.17.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590
  2022-04-25  5:18   ` Greg KH
@ 2022-04-25  5:58     ` ipis.yang
  2022-05-05 11:29       ` Johan Hovold
  0 siblings, 1 reply; 7+ messages in thread
From: ipis.yang @ 2022-04-25  5:58 UTC (permalink / raw)
  To: johan, gregkh, linux-usb, linux-kernel; +Cc: gchiang, ipis.yang, Ethan Yang

From: Ethan Yang <etyang@sierrawireless.com>

add support for Sierra Wireless EM7590 0xc080/0xc081 compositions

Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
---
 drivers/usb/serial/qcserial.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index c18bf8164bc2..586ef5551e76 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -166,6 +166,8 @@ static const struct usb_device_id id_table[] = {
 	{DEVICE_SWI(0x1199, 0x9090)},	/* Sierra Wireless EM7565 QDL */
 	{DEVICE_SWI(0x1199, 0x9091)},	/* Sierra Wireless EM7565 */
 	{DEVICE_SWI(0x1199, 0x90d2)},	/* Sierra Wireless EM9191 QDL */
+	{DEVICE_SWI(0x1199, 0xc080)},	/* Sierra Wireless EM7590 QDL */
+	{DEVICE_SWI(0x1199, 0xc081)},	/* Sierra Wireless EM7590 */
 	{DEVICE_SWI(0x413c, 0x81a2)},	/* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
 	{DEVICE_SWI(0x413c, 0x81a3)},	/* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
 	{DEVICE_SWI(0x413c, 0x81a4)},	/* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590
  2022-04-25  5:58     ` [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590 ipis.yang
@ 2022-05-05 11:29       ` Johan Hovold
  2022-05-05 12:35         ` Ethan Yang
  0 siblings, 1 reply; 7+ messages in thread
From: Johan Hovold @ 2022-05-05 11:29 UTC (permalink / raw)
  To: ipis.yang; +Cc: gregkh, linux-usb, linux-kernel, gchiang, Ethan Yang

On Mon, Apr 25, 2022 at 01:58:40PM +0800, ipis.yang@gmail.com wrote:
> From: Ethan Yang <etyang@sierrawireless.com>
> 
> add support for Sierra Wireless EM7590 0xc080/0xc081 compositions
> 
> Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
> ---

Please include a short changelog here (after the ---) when updating
patches.

Please also include the output of usb-devices (or lsusb -v) for these
two compositions for completeness.

Johan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590
  2022-05-05 11:29       ` Johan Hovold
@ 2022-05-05 12:35         ` Ethan Yang
  2022-05-05 13:51           ` Johan Hovold
  0 siblings, 1 reply; 7+ messages in thread
From: Ethan Yang @ 2022-05-05 12:35 UTC (permalink / raw)
  To: Johan Hovold, 皓宇 �
  Cc: gregkh, linux-usb, linux-kernel, Glen Chiang

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1080 bytes --]

Hi Johan,

Here is the change log:
To revise the correct composition for QDL/APP mode.
1199:c080 is for QDL, and 1199:c081 is for APP mode.

I also enclose the lsusb -v output for both compositions.

Thanks,
Ethan

-----Original Message-----
From: Johan Hovold <johan@kernel.org> 
Sent: Thursday, May 5, 2022 19:30
To: ð©Óî —î <ipis.yang@gmail.com>
Cc: gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Glen Chiang <GChiang@sierrawireless.com>; Ethan Yang <etyang@sierrawireless.com>
Subject: Re: [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590

On Mon, Apr 25, 2022 at 01:58:40PM +0800, ipis.yang@gmail.com wrote:
> From: Ethan Yang <etyang@sierrawireless.com>
> 
> add support for Sierra Wireless EM7590 0xc080/0xc081 compositions
> 
> Signed-off-by: Ethan Yang <etyang@sierrawireless.com>
> ---

Please include a short changelog here (after the ---) when updating patches.

Please also include the output of usb-devices (or lsusb -v) for these two compositions for completeness.

Johan

[-- Attachment #2: c081.txt --]
[-- Type: text/plain, Size: 9915 bytes --]

ethan@ethan-Latitude-7280:~/work/mpbl/5164/MBPL_R21_B5164/Drivers/USB$ lsusb -v -d 1199:

Bus 002 Device 003: ID 1199:c081 Sierra Wireless, Inc.
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               3.20
  bDeviceClass          239 Miscellaneous Device
  bDeviceSubClass         2 ?
  bDeviceProtocol         1 Interface Association
  bMaxPacketSize0         9
  idVendor           0x1199 Sierra Wireless, Inc.
  idProduct          0xc081
  bcdDevice            5.04
  iManufacturer           1 Sierra Wireless, Incorporated
  iProduct                2 Sierra Wireless EM7590 Mobile Broadband Adapter
  iSerial                 3 0123456789ABCDEF
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength          282
    bNumInterfaces          5
    bConfigurationValue     1
    iConfiguration          4 diag,nmea,modem,mbim
    bmAttributes         0xa0
      (Bus Powered)
      Remote Wakeup
    MaxPower              224mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol     48
      iInterface              0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x01  EP 1 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        2
      bAlternateSetting       0
      bNumEndpoints           3
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol     96
      iInterface              0
      ** UNRECOGNIZED:  05 24 00 10 01
      ** UNRECOGNIZED:  05 24 01 00 00
      ** UNRECOGNIZED:  04 24 02 02
      ** UNRECOGNIZED:  05 24 06 00 00
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x000a  1x 10 bytes
        bInterval               9
        bMaxBurst               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x82  EP 2 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        3
      bAlternateSetting       0
      bNumEndpoints           3
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol     64
      iInterface              0
      ** UNRECOGNIZED:  05 24 00 10 01
      ** UNRECOGNIZED:  05 24 01 00 00
      ** UNRECOGNIZED:  04 24 02 02
      ** UNRECOGNIZED:  05 24 06 00 00
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x85  EP 5 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x000a  1x 10 bytes
        bInterval               9
        bMaxBurst               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x84  EP 4 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x03  EP 3 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               0
    Interface Association:
      bLength                 8
      bDescriptorType        11
      bFirstInterface        12
      bInterfaceCount         2
      bFunctionClass          2 Communications
      bFunctionSubClass      14
      bFunctionProtocol       0
      iFunction               0
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber       12
      bAlternateSetting       0
      bNumEndpoints           1
      bInterfaceClass         2 Communications
      bInterfaceSubClass     14
      bInterfaceProtocol      0
      iInterface              6 MBIM Control
      CDC Header:
        bcdCDC               1.10
      CDC Union:
        bMasterInterface        12
        bSlaveInterface         13
      CDC MBIM:
        bcdMBIMVersion       1.00
        wMaxControlMessage   4096
        bNumberFilters       32
        bMaxFilterSize       128
        wMaxSegmentSize      2048
        bmNetworkCapabilities 0x20
          8-byte ntb input size
      UNRECOGNIZED CDC:  08 24 1c 00 01 40 dc 05
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x86  EP 6 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0040  1x 64 bytes
        bInterval               9
        bMaxBurst               0
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber       13
      bAlternateSetting       0
      bNumEndpoints           0
      bInterfaceClass        10 CDC Data
      bInterfaceSubClass      0 Unused
      bInterfaceProtocol      2
      iInterface              0
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber       13
      bAlternateSetting       1
      bNumEndpoints           2
      bInterfaceClass        10 CDC Data
      bInterfaceSubClass      0 Unused
      bInterfaceProtocol      2
      iInterface              7 MBIM Data
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x8e  EP 14 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               6
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x0f  EP 15 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0400  1x 1024 bytes
        bInterval               0
        bMaxBurst               2
Binary Object Store Descriptor:
  bLength                 5
  bDescriptorType        15
  wTotalLength           22
  bNumDeviceCaps          2
  USB 2.0 Extension Device Capability:
    bLength                 7
    bDescriptorType        16
    bDevCapabilityType      2
    bmAttributes   0x0000211e
      Link Power Management (LPM) Supported
  SuperSpeed USB Device Capability:
    bLength                10
    bDescriptorType        16
    bDevCapabilityType      3
    bmAttributes         0x00
    wSpeedsSupported   0x000f
      Device can operate at Low Speed (1Mbps)
      Device can operate at Full Speed (12Mbps)
      Device can operate at High Speed (480Mbps)
      Device can operate at SuperSpeed (5Gbps)
    bFunctionalitySupport   1
      Lowest fully-functional device speed is Full Speed (12Mbps)
    bU1DevExitLat           0 micro seconds
    bU2DevExitLat           0 micro seconds
Device Status:     0x0000
  (Bus Powered)

[-- Attachment #3: c080.txt --]
[-- Type: text/plain, Size: 2260 bytes --]

ethan@ethan-Latitude-7280:~/work/mpbl/5164/MBPL_R21_B5164/Drivers/USB$ lsusb -v -d 1199:

Bus 001 Device 005: ID 1199:c080 Sierra Wireless, Inc.
Couldn't open device, some information will be missing
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               2.00
  bDeviceClass            0 (Defined at Interface level)
  bDeviceSubClass         0
  bDeviceProtocol         0
  bMaxPacketSize0        64
  idVendor           0x1199 Sierra Wireless, Inc.
  idProduct          0xc080
  bcdDevice            0.00
  iManufacturer           1 Sierra Wireless, Incorporated
  iProduct                2 Sierra Wireless EM7590 Mobile Broadband Adapter
  iSerial                 3 0123456789ABCDEF
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength           32
    bNumInterfaces          1
    bConfigurationValue     1
    iConfiguration          0
    bmAttributes         0xa0
      (Bus Powered)
      Remote Wakeup
    MaxPower                2mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           2
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass    255 Vendor Specific Subclass
      bInterfaceProtocol    255 Vendor Specific Protocol
      iInterface              0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0200  1x 512 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x01  EP 1 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0200  1x 512 bytes
        bInterval               0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590
  2022-05-05 12:35         ` Ethan Yang
@ 2022-05-05 13:51           ` Johan Hovold
  0 siblings, 0 replies; 7+ messages in thread
From: Johan Hovold @ 2022-05-05 13:51 UTC (permalink / raw)
  To: Ethan Yang
  Cc: 皓宇 �, gregkh, linux-usb, linux-kernel, Glen Chiang

On Thu, May 05, 2022 at 12:35:41PM +0000, Ethan Yang wrote:
> Hi Johan,
> 
> Here is the change log:
> To revise the correct composition for QDL/APP mode.
> 1199:c080 is for QDL, and 1199:c081 is for APP mode.

I meant that when you when you resend a new version of a patch you
should include a changelog for what changed since the previous
version(s) (below the --- line).

In this case I think you only changed the From address from v1 to v2,
but I'm not sure.

No need to resend, but please keep that in mind for your future
submissions.

> I also enclose the lsusb -v output for both compositions.

Thanks a lot for that.

I've applied the patch now.

Johan

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-05-05 13:51 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25  3:42 [PATCH] add support for Sierra Wireless EM7590 0xc080 and 0xc081 compositions Ethan Yang
2022-04-25  3:55 ` [PATCH v2] " Ethan Yang
2022-04-25  5:18   ` Greg KH
2022-04-25  5:58     ` [PATCH v3] usb: serial: qcserial: add support for Sierra Wireless EM7590 ipis.yang
2022-05-05 11:29       ` Johan Hovold
2022-05-05 12:35         ` Ethan Yang
2022-05-05 13:51           ` Johan Hovold

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.