[igt-dev] [i-g-t,v2, 1/2] lib: sync i915_pciids.h with kernel

[igt-dev] [i-g-t,v2, 1/2] lib: sync i915_pciids.h with kernel

[Talla Raviteja Goud]

From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

This synchronizes with kernel commit

72c3c8d6e5275 ("drm/i915/rpl-p: Add PCI IDs")
to bring in RPL-P PCI IDs.

v2: Corresponding kernel commit added in commit message (Petri)

Signed-off-by: Adam Miszczak <adam.miszczak@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Signed-off-by: Raviteja Goud Talla <ravitejax.goud.talla@intel.com>
---
 lib/i915_pciids.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 533890dc..3233a06e 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -681,4 +681,13 @@
 	INTEL_VGA_DEVICE(0xA788, info), \
 	INTEL_VGA_DEVICE(0xA789, info)
 
+/*RPL-P */
+#define INTEL_RPLP_IDS(info) \
+	INTEL_VGA_DEVICE(0xA720, info), \
+	INTEL_VGA_DEVICE(0xA721, info), \
+	INTEL_VGA_DEVICE(0xA7A0, info), \
+	INTEL_VGA_DEVICE(0xA7A1, info), \
+	INTEL_VGA_DEVICE(0xA7A8, info), \
+	INTEL_VGA_DEVICE(0xA7A9, info)
+
 #endif /* _I915_PCIIDS_H */
-- 
2.34.1

[igt-dev] [i-g-t, v2, 2/2] lib/rpl_p: Add Raptor Lake P platform definition

[Talla Raviteja Goud]

From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

Adding Raptor lake platform definitions

v2: Modifying intel_device_info.c in seperate commit (Petri)
    Earlier changes done in i915_pciids.h commit

Signed-off-by: Adam Miszczak <adam.miszczak@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Signed-off-by: Raviteja Goud Talla <ravitejax.goud.talla@intel.com>
---
 lib/intel_device_info.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index e55841df..0253a732 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -521,6 +521,7 @@ static const struct pci_id_match intel_device_match[] = {
 	INTEL_ADLS_IDS(&intel_alderlake_s_info),
 	INTEL_RPLS_IDS(&intel_raptorlake_s_info),
 	INTEL_ADLP_IDS(&intel_alderlake_p_info),
+	INTEL_RPLP_IDS(&intel_alderlake_p_info),
 	INTEL_ADLN_IDS(&intel_alderlake_n_info),
 
 	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
-- 
2.34.1

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v2,1/2] lib: sync i915_pciids.h with kernel

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6472 bytes --]

== Series Details ==

Series: series starting with [i-g-t,v2,1/2] lib: sync i915_pciids.h with kernel
URL   : https://patchwork.freedesktop.org/series/102907/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11530 -> IGTPW_6960
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_6960 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_6960, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/index.html

Participating hosts (45 -> 44)
------------------------------

  Additional (1): fi-cml-u2 
  Missing    (2): fi-bsw-cyan fi-tgl-u2 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_6960:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@ring_submission:
    - bat-dg1-5:          [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11530/bat-dg1-5/igt@i915_selftest@live@ring_submission.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/bat-dg1-5/igt@i915_selftest@live@ring_submission.html

  
Known issues
------------

  Here are the changes found in IGTPW_6960 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fence@basic-busy@bcs0:
    - fi-cml-u2:          NOTRUN -> [SKIP][3] ([i915#1208]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@gem_exec_fence@basic-busy@bcs0.html

  * igt@gem_huc_copy@huc-copy:
    - fi-cml-u2:          NOTRUN -> [SKIP][4] ([i915#2190])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-cml-u2:          NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@kms_chamelium@dp-hpd-fast:
    - fi-cml-u2:          NOTRUN -> [SKIP][6] ([fdo#109284] / [fdo#111827]) +8 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@kms_chamelium@dp-hpd-fast.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-cml-u2:          NOTRUN -> [SKIP][7] ([fdo#109278]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-cml-u2:          NOTRUN -> [SKIP][8] ([fdo#109285])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - fi-cml-u2:          NOTRUN -> [SKIP][9] ([fdo#109278] / [i915#533])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-cml-u2:          NOTRUN -> [SKIP][10] ([i915#3555])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-userptr:
    - fi-cml-u2:          NOTRUN -> [SKIP][11] ([i915#3301])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-cml-u2/igt@prime_vgem@basic-userptr.html

  * igt@runner@aborted:
    - fi-bdw-5557u:       NOTRUN -> [FAIL][12] ([i915#4312])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-bdw-5557u/igt@runner@aborted.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - {bat-rpls-2}:       [DMESG-WARN][13] ([i915#4391]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11530/bat-rpls-2/igt@core_hotunplug@unbind-rebind.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/bat-rpls-2/igt@core_hotunplug@unbind-rebind.html

  * igt@i915_selftest@live@hangcheck:
    - fi-hsw-4770:        [INCOMPLETE][15] ([i915#4785]) -> [PASS][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11530/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
    - bat-dg1-6:          [DMESG-FAIL][17] ([i915#4494] / [i915#4957]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11530/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/bat-dg1-6/igt@i915_selftest@live@hangcheck.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
  [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6442 -> IGTPW_6960

  CI-20190529: 20190529
  CI_DRM_11530: aa020e951b9496aafe472b08f182a9635518e638 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6960: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/index.html
  IGT_6442: 891ce2ff8769675b52dcfff3cf1c91bb711ddb03 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6960/index.html

[-- Attachment #2: Type: text/html, Size: 7499 bytes --]

Re: [igt-dev] [i-g-t,v2, 1/2] lib: sync i915_pciids.h with kernel

[Petri Latvala]

On Thu, Apr 21, 2022 at 11:28:18AM +0530, Talla Raviteja Goud wrote:
> From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> 
> This synchronizes with kernel commit
> 
> 72c3c8d6e5275 ("drm/i915/rpl-p: Add PCI IDs")
> to bring in RPL-P PCI IDs.
> 
> v2: Corresponding kernel commit added in commit message (Petri)
> 
> Signed-off-by: Adam Miszczak <adam.miszczak@intel.com>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Signed-off-by: Raviteja Goud Talla <ravitejax.goud.talla@intel.com>
> ---
>  lib/i915_pciids.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 533890dc..3233a06e 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -681,4 +681,13 @@
>  	INTEL_VGA_DEVICE(0xA788, info), \
>  	INTEL_VGA_DEVICE(0xA789, info)

You need to _copy_ the file from that kernel commit. It has changes to
the list of RPL-S ids here too, this patch doesn't match what's in
72c3c8d6e5275.


-- 
Petri Latvala


>  
> +/*RPL-P */
> +#define INTEL_RPLP_IDS(info) \
> +	INTEL_VGA_DEVICE(0xA720, info), \
> +	INTEL_VGA_DEVICE(0xA721, info), \
> +	INTEL_VGA_DEVICE(0xA7A0, info), \
> +	INTEL_VGA_DEVICE(0xA7A1, info), \
> +	INTEL_VGA_DEVICE(0xA7A8, info), \
> +	INTEL_VGA_DEVICE(0xA7A9, info)
> +
>  #endif /* _I915_PCIIDS_H */
> -- 
> 2.34.1
> 

Re: [igt-dev] [i-g-t, v2, 2/2] lib/rpl_p: Add Raptor Lake P platform definition

[Petri Latvala]

On Thu, Apr 21, 2022 at 11:28:19AM +0530, Talla Raviteja Goud wrote:
> From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> 
> Adding Raptor lake platform definitions
> 
> v2: Modifying intel_device_info.c in seperate commit (Petri)
>     Earlier changes done in i915_pciids.h commit
> 
> Signed-off-by: Adam Miszczak <adam.miszczak@intel.com>
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> Signed-off-by: Raviteja Goud Talla <ravitejax.goud.talla@intel.com>

Acked-by: Petri Latvala <petri.latvala@intel.com>

but,


> ---
>  lib/intel_device_info.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index e55841df..0253a732 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -521,6 +521,7 @@ static const struct pci_id_match intel_device_match[] = {
>  	INTEL_ADLS_IDS(&intel_alderlake_s_info),
>  	INTEL_RPLS_IDS(&intel_raptorlake_s_info),
>  	INTEL_ADLP_IDS(&intel_alderlake_p_info),
> +	INTEL_RPLP_IDS(&intel_alderlake_p_info),
>  	INTEL_ADLN_IDS(&intel_alderlake_n_info),

Not necessary to do in this patch, but as also discussed internally,
this needs to be made consistent. RPL-P using ADL-P info but RPL-S
using RPL-S info. Either both use the corresponding ADL info struct or
neither, not this mix of in between.


-- 
Petri Latvala

Re: [igt-dev] [i-g-t,v2, 1/2] lib: sync i915_pciids.h with kernel

[Talla, RavitejaX Goud]

Need to float missing RPL-S pciids patch (756b807f6a3e0) prior to current RPL-P?

Thanks,
Raviteja 

Re: [igt-dev] [i-g-t,v2, 1/2] lib: sync i915_pciids.h with kernel

[Petri Latvala]

On Mon, Apr 25, 2022 at 11:12:56AM +0300, Talla, RavitejaX Goud wrote:
> Need to float missing RPL-S pciids patch (756b807f6a3e0) prior to current RPL-P?

No, just copy and send the patch like that. Commit message can explain
which PCI IDs that brings.


-- 
Petri Latvala