From: Rob Herring <robh@kernel.org> To: Daniel Kaehn <kaehndan@gmail.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com Subject: Re: [PATCH v4 1/2] dt-bindings: sound: Add generic serial MIDI device Date: Mon, 25 Apr 2022 17:16:29 -0500 [thread overview] Message-ID: <YmcdvcyeJJBB1pqW@robh.at.kernel.org> (raw) In-Reply-To: <20220425191602.770932-2-kaehndan@gmail.com> On Mon, Apr 25, 2022 at 02:16:02PM -0500, Daniel Kaehn wrote: > Adds dt-binding for snd-serial-generic serial MIDI driver Bindings are for h/w and there's no such thing as generic h/w. There are some exceptions but you'll have to justify why this is special. > Signed-off-by: Daniel Kaehn <kaehndan@gmail.com> > --- > .../devicetree/bindings/sound/serialmidi.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/serialmidi.yaml > > diff --git a/Documentation/devicetree/bindings/sound/serialmidi.yaml b/Documentation/devicetree/bindings/sound/serialmidi.yaml > new file mode 100644 > index 000000000000..38ef49a0c2f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/serialmidi.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/serialmidi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Serial MIDI Device > + > +maintainers: > + - Daniel Kaehn <kaehndan@gmail.com> > + > +description: | Don't need '|' unless there is formatting to preserve. > + Generic MIDI interface using a serial device. Can only be set to use standard speeds > + corresponding to supported baud rates of the underlying serial device. If standard MIDI > + speed of 31.25 kBaud is needed, configure the clocks of the underlying serial device > + so that a requested speed of 38.4 kBaud resuts in the standard MIDI baud rate. > + > +properties: > + compatible: > + const: serialmidi > + > + speed: Not a standard property and we already have 2 of them concerning baud rate. > + maxItems: 1 > + description: | > + Speed to set the serial port to when the MIDI device is opened. > + If not specified, the underlying serial device is allowed to use its configured default speed. > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + serial { > + midi { > + compatible = "serialmidi"; > + speed = <38400>; > + }; > + }; > -- > 2.33.0 > >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Daniel Kaehn <kaehndan@gmail.com> Cc: tiwai@suse.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: sound: Add generic serial MIDI device Date: Mon, 25 Apr 2022 17:16:29 -0500 [thread overview] Message-ID: <YmcdvcyeJJBB1pqW@robh.at.kernel.org> (raw) In-Reply-To: <20220425191602.770932-2-kaehndan@gmail.com> On Mon, Apr 25, 2022 at 02:16:02PM -0500, Daniel Kaehn wrote: > Adds dt-binding for snd-serial-generic serial MIDI driver Bindings are for h/w and there's no such thing as generic h/w. There are some exceptions but you'll have to justify why this is special. > Signed-off-by: Daniel Kaehn <kaehndan@gmail.com> > --- > .../devicetree/bindings/sound/serialmidi.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/serialmidi.yaml > > diff --git a/Documentation/devicetree/bindings/sound/serialmidi.yaml b/Documentation/devicetree/bindings/sound/serialmidi.yaml > new file mode 100644 > index 000000000000..38ef49a0c2f9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/serialmidi.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/serialmidi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Serial MIDI Device > + > +maintainers: > + - Daniel Kaehn <kaehndan@gmail.com> > + > +description: | Don't need '|' unless there is formatting to preserve. > + Generic MIDI interface using a serial device. Can only be set to use standard speeds > + corresponding to supported baud rates of the underlying serial device. If standard MIDI > + speed of 31.25 kBaud is needed, configure the clocks of the underlying serial device > + so that a requested speed of 38.4 kBaud resuts in the standard MIDI baud rate. > + > +properties: > + compatible: > + const: serialmidi > + > + speed: Not a standard property and we already have 2 of them concerning baud rate. > + maxItems: 1 > + description: | > + Speed to set the serial port to when the MIDI device is opened. > + If not specified, the underlying serial device is allowed to use its configured default speed. > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + serial { > + midi { > + compatible = "serialmidi"; > + speed = <38400>; > + }; > + }; > -- > 2.33.0 > >
next prev parent reply other threads:[~2022-04-25 22:17 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 19:16 [PATCH v4 0/2] Add generic serial MIDI driver using serial bus API Daniel Kaehn 2022-04-25 19:16 ` Daniel Kaehn 2022-04-25 19:16 ` [PATCH v4 1/2] dt-bindings: sound: Add generic serial MIDI device Daniel Kaehn 2022-04-25 19:16 ` Daniel Kaehn 2022-04-25 22:16 ` Rob Herring [this message] 2022-04-25 22:16 ` Rob Herring 2022-04-26 0:49 ` Dan K 2022-04-26 0:49 ` Dan K 2022-04-27 0:47 ` Rob Herring 2022-04-27 0:47 ` Rob Herring 2022-04-27 9:29 ` Dan K 2022-04-28 1:58 ` Rob Herring 2022-04-28 3:22 ` Dan K 2022-04-25 19:16 ` [PATCH v4 2/2] Add generic serial MIDI driver using serial bus API Daniel Kaehn 2022-04-25 19:16 ` Daniel Kaehn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YmcdvcyeJJBB1pqW@robh.at.kernel.org \ --to=robh@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=devicetree@vger.kernel.org \ --cc=kaehndan@gmail.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.