[igt-dev] [PATCH i-g-t 0/2] HAX add description to prime_self_import

[igt-dev] [PATCH i-g-t 0/2] HAX add description to prime_self_import

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add test description to prime_self_import.

Priyanka Dandamudi (2):
  prime_self_import: Add description for test
  HAX: don't do full run

 tests/intel-ci/fast-feedback.testlist | 179 +-------------------------
 tests/prime_self_import.c             |  26 ++--
 2 files changed, 19 insertions(+), 186 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/2] prime_self_import: Add description for test

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add description for test.

v2: add description to tests[].

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
---
 tests/prime_self_import.c | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
index 38a554396..bf5486194 100644
--- a/tests/prime_self_import.c
+++ b/tests/prime_self_import.c
@@ -429,19 +429,29 @@ igt_main
 	struct {
 		const char *name;
 		void (*fn)(void);
+		const char *describe;
 	} tests[] = {
-		{ "basic-with_one_bo", test_with_one_bo },
-		{ "basic-with_one_bo_two_files", test_with_one_bo_two_files },
-		{ "basic-with_two_bos", test_with_two_bos },
-		{ "basic-with_fd_dup", test_with_fd_dup },
-		{ "export-vs-gem_close-race", test_export_close_race },
-		{ "reimport-vs-gem_close-race", test_reimport_close_race },
-		{ "basic-llseek-size", test_llseek_size },
-		{ "basic-llseek-bad", test_llseek_bad },
+		{ "basic-with_one_bo", test_with_one_bo,
+			"Check prime import/export with one buffer object." },
+		{ "basic-with_one_bo_two_files", test_with_one_bo_two_files,
+			"Check prime/flink with one buffer object." },
+		{ "basic-with_two_bos", test_with_two_bos,
+			"Check prime import/export with two buffer objects."},
+		{ "basic-with_fd_dup", test_with_fd_dup,
+			"Check prime export with duplicate fd."},
+		{ "export-vs-gem_close-race", test_export_close_race,
+			"Check race of gem close against prime export." },
+		{ "reimport-vs-gem_close-race", test_reimport_close_race,
+			"Check race of gem close against reimport." },
+		{ "basic-llseek-size", test_llseek_size,
+			"Check dmabuf llseek support." },
+		{ "basic-llseek-bad", test_llseek_bad,
+			"Check dmabuf llseek support with invalid values."},
 	};
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(tests); i++) {
+		igt_describe(tests[i].describe);
 		igt_subtest(tests[i].name)
 			tests[i].fn();
 	}
-- 
2.25.1

Re: [igt-dev] [PATCH i-g-t 1/2] prime_self_import: Add description for test

[Kamil Konieczny]

Hi Priyanka,

On 2022-04-26 at 12:50:48 +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Add description for test.
> 
> v2: add description to tests[].
> 

Lgtm,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

--
Kamil

> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
> ---
>  tests/prime_self_import.c | 26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
> index 38a554396..bf5486194 100644
> --- a/tests/prime_self_import.c
> +++ b/tests/prime_self_import.c
> @@ -429,19 +429,29 @@ igt_main
>  	struct {
>  		const char *name;
>  		void (*fn)(void);
> +		const char *describe;
>  	} tests[] = {
> -		{ "basic-with_one_bo", test_with_one_bo },
> -		{ "basic-with_one_bo_two_files", test_with_one_bo_two_files },
> -		{ "basic-with_two_bos", test_with_two_bos },
> -		{ "basic-with_fd_dup", test_with_fd_dup },
> -		{ "export-vs-gem_close-race", test_export_close_race },
> -		{ "reimport-vs-gem_close-race", test_reimport_close_race },
> -		{ "basic-llseek-size", test_llseek_size },
> -		{ "basic-llseek-bad", test_llseek_bad },
> +		{ "basic-with_one_bo", test_with_one_bo,
> +			"Check prime import/export with one buffer object." },
> +		{ "basic-with_one_bo_two_files", test_with_one_bo_two_files,
> +			"Check prime/flink with one buffer object." },
> +		{ "basic-with_two_bos", test_with_two_bos,
> +			"Check prime import/export with two buffer objects."},
> +		{ "basic-with_fd_dup", test_with_fd_dup,
> +			"Check prime export with duplicate fd."},
> +		{ "export-vs-gem_close-race", test_export_close_race,
> +			"Check race of gem close against prime export." },
> +		{ "reimport-vs-gem_close-race", test_reimport_close_race,
> +			"Check race of gem close against reimport." },
> +		{ "basic-llseek-size", test_llseek_size,
> +			"Check dmabuf llseek support." },
> +		{ "basic-llseek-bad", test_llseek_bad,
> +			"Check dmabuf llseek support with invalid values."},
>  	};
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(tests); i++) {
> +		igt_describe(tests[i].describe);
>  		igt_subtest(tests[i].name)
>  			tests[i].fn();
>  	}
> -- 
> 2.25.1
> 

[igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Just for test description, no full run is necessary.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 179 +-------------------------
 1 file changed, 1 insertion(+), 178 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 5c867bbf7..1d57372d3 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,180 +1,3 @@
 # Keep alphabetically sorted by default
 
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
+igt@meta_test@fail-result
-- 
2.25.1

[igt-dev] ✗ Fi.CI.BUILD: failure for HAX add description to prime_self_import (rev2)

[Patchwork]

== Series Details ==

Series: HAX add description to prime_self_import (rev2)
URL   : https://patchwork.freedesktop.org/series/101586/
State : failure

== Summary ==

Applying: prime_self_import: Add description for test
Applying: HAX: don't do full run
Using index info to reconstruct a base tree...
M	tests/intel-ci/fast-feedback.testlist
Falling back to patching base and 3-way merge...
Auto-merging tests/intel-ci/fast-feedback.testlist
CONFLICT (content): Merge conflict in tests/intel-ci/fast-feedback.testlist
Patch failed at 0002 HAX: don't do full run
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

[igt-dev] [PATCH i-g-t 0/2] HAX add description to prime_self_import

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add test description to prime_self_import.

Priyanka Dandamudi (2):
  prime_self_import: Add description for test
  HAX: don't do full run

 tests/intel-ci/fast-feedback.testlist | 179 +-------------------------
 tests/prime_self_import.c             |   2 +
 2 files changed, 3 insertions(+), 178 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/2] prime_self_import: Add description for test

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add description for test.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
---
 tests/prime_self_import.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
index 38a55439..a56ec313 100644
--- a/tests/prime_self_import.c
+++ b/tests/prime_self_import.c
@@ -442,6 +442,8 @@ igt_main
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(tests); i++) {
+		igt_describe_f("Verify PRIME_HANDLE_TO_FD functionality in"
+				" different scenarios:%s", tests[i].name);
 		igt_subtest(tests[i].name)
 			tests[i].fn();
 	}
-- 
2.25.1

Re: [igt-dev] [PATCH i-g-t 1/2] prime_self_import: Add description for test

[Kamil Konieczny]

Hi Priyanka,

Dnia 2022-03-21 at 18:42:04 +0530, priyanka.dandamudi@intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Add description for test.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
> ---
>  tests/prime_self_import.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/prime_self_import.c b/tests/prime_self_import.c
> index 38a55439..a56ec313 100644
> --- a/tests/prime_self_import.c
> +++ b/tests/prime_self_import.c
> @@ -442,6 +442,8 @@ igt_main
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(tests); i++) {
> +		igt_describe_f("Verify PRIME_HANDLE_TO_FD functionality in"
> +				" different scenarios:%s", tests[i].name);

Imho this doesn't add much explanation to test, so either keep
it short, like "Verify prime import/export with %s", or add
description to tests[] and print tests[i].idescription

>  		igt_subtest(tests[i].name)
>  			tests[i].fn();
>  	}
> -- 
> 2.25.1
> 
Regards,
Kamil