From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Jani Nikula <jani.nikula@intel.com> Cc: intel-gfx@lists.freedesktop.org, Ankit Nautiyal <ankit.k.nautiyal@intel.com>, Lee Shawn C <shawn.c.lee@intel.com>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 02/19] drm/edid: check for HF-SCDB block Date: Tue, 26 Apr 2022 22:07:51 +0300 [thread overview] Message-ID: <YmhDB6LxHXJvBMRB@intel.com> (raw) In-Reply-To: <a372cec9ce98438a963d199ebb04c2de56152513.1649948562.git.jani.nikula@intel.com> On Thu, Apr 14, 2022 at 06:06:45PM +0300, Jani Nikula wrote: > From: Lee Shawn C <shawn.c.lee@intel.com> > > Find HF-SCDB information in CEA extensions block. And retrieve > Max_TMDS_Character_Rate that support by sink device. > > v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse > drm_parse_hdmi_forum_vsdb() to parse this packet. > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/drm_edid.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 4758e78fad82..32ece9607b94 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3495,6 +3495,7 @@ add_detailed_modes(struct drm_connector *connector, const struct edid *edid, > #define EXT_VIDEO_CAPABILITY_BLOCK 0x00 > #define EXT_VIDEO_DATA_BLOCK_420 0x0E > #define EXT_VIDEO_CAP_BLOCK_Y420CMDB 0x0F > +#define EXT_VIDEO_HF_SCDB_DATA_BLOCK 0x79 > #define EDID_BASIC_AUDIO (1 << 6) > #define EDID_CEA_YCRCB444 (1 << 5) > #define EDID_CEA_YCRCB422 (1 << 4) > @@ -4426,6 +4427,20 @@ static bool cea_db_is_vcdb(const u8 *db) > return true; > } > > +static bool cea_db_is_hdmi_forum_scdb(const u8 *db) > +{ > + if (cea_db_tag(db) != USE_EXTENDED_TAG) > + return false; > + > + if (cea_db_payload_len(db) < 7) > + return false; > + > + if (cea_db_extended_tag(db) != EXT_VIDEO_HF_SCDB_DATA_BLOCK) > + return false; > + > + return true; > +} > + > static bool cea_db_is_y420cmdb(const u8 *db) > { > if (cea_db_tag(db) != USE_EXTENDED_TAG) > @@ -5387,7 +5402,8 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > > if (cea_db_is_hdmi_vsdb(db)) > drm_parse_hdmi_vsdb_video(connector, db); > - if (cea_db_is_hdmi_forum_vsdb(db)) > + if (cea_db_is_hdmi_forum_vsdb(db) || > + cea_db_is_hdmi_forum_scdb(db)) > drm_parse_hdmi_forum_vsdb(connector, db); I'd do a s/parse_hdmi_forum_vsdb/parse_scds/ to keep up with the spec terminology. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > if (cea_db_is_microsoft_vsdb(db)) > drm_parse_microsoft_vsdb(connector, db); > -- > 2.30.2 -- Ville Syrjälä Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Jani Nikula <jani.nikula@intel.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 02/19] drm/edid: check for HF-SCDB block Date: Tue, 26 Apr 2022 22:07:51 +0300 [thread overview] Message-ID: <YmhDB6LxHXJvBMRB@intel.com> (raw) In-Reply-To: <a372cec9ce98438a963d199ebb04c2de56152513.1649948562.git.jani.nikula@intel.com> On Thu, Apr 14, 2022 at 06:06:45PM +0300, Jani Nikula wrote: > From: Lee Shawn C <shawn.c.lee@intel.com> > > Find HF-SCDB information in CEA extensions block. And retrieve > Max_TMDS_Character_Rate that support by sink device. > > v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse > drm_parse_hdmi_forum_vsdb() to parse this packet. > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com> > Cc: intel-gfx <intel-gfx@lists.freedesktop.org> > Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/drm_edid.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 4758e78fad82..32ece9607b94 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3495,6 +3495,7 @@ add_detailed_modes(struct drm_connector *connector, const struct edid *edid, > #define EXT_VIDEO_CAPABILITY_BLOCK 0x00 > #define EXT_VIDEO_DATA_BLOCK_420 0x0E > #define EXT_VIDEO_CAP_BLOCK_Y420CMDB 0x0F > +#define EXT_VIDEO_HF_SCDB_DATA_BLOCK 0x79 > #define EDID_BASIC_AUDIO (1 << 6) > #define EDID_CEA_YCRCB444 (1 << 5) > #define EDID_CEA_YCRCB422 (1 << 4) > @@ -4426,6 +4427,20 @@ static bool cea_db_is_vcdb(const u8 *db) > return true; > } > > +static bool cea_db_is_hdmi_forum_scdb(const u8 *db) > +{ > + if (cea_db_tag(db) != USE_EXTENDED_TAG) > + return false; > + > + if (cea_db_payload_len(db) < 7) > + return false; > + > + if (cea_db_extended_tag(db) != EXT_VIDEO_HF_SCDB_DATA_BLOCK) > + return false; > + > + return true; > +} > + > static bool cea_db_is_y420cmdb(const u8 *db) > { > if (cea_db_tag(db) != USE_EXTENDED_TAG) > @@ -5387,7 +5402,8 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > > if (cea_db_is_hdmi_vsdb(db)) > drm_parse_hdmi_vsdb_video(connector, db); > - if (cea_db_is_hdmi_forum_vsdb(db)) > + if (cea_db_is_hdmi_forum_vsdb(db) || > + cea_db_is_hdmi_forum_scdb(db)) > drm_parse_hdmi_forum_vsdb(connector, db); I'd do a s/parse_hdmi_forum_vsdb/parse_scds/ to keep up with the spec terminology. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > if (cea_db_is_microsoft_vsdb(db)) > drm_parse_microsoft_vsdb(connector, db); > -- > 2.30.2 -- Ville Syrjälä Intel
next prev parent reply other threads:[~2022-04-26 19:08 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-14 15:06 [PATCH 00/19] drm/edid: CEA data block iterators, and more Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 01/19] drm/edid: reset display info in drm_add_edid_modes() for NULL edid Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-26 18:52 ` Ville Syrjälä 2022-04-26 18:52 ` [Intel-gfx] " Ville Syrjälä 2022-04-14 15:06 ` [PATCH 02/19] drm/edid: check for HF-SCDB block Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-26 19:07 ` Ville Syrjälä [this message] 2022-04-26 19:07 ` Ville Syrjälä 2022-04-14 15:06 ` [PATCH 03/19] drm/edid: clean up CTA data block tag definitions Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 04/19] drm/edid: add iterator for EDID base and extension blocks Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 05/19] drm/edid: add iterator for CTA data blocks Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 06/19] drm/edid: clean up cea_db_is_*() functions Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-26 19:10 ` Ville Syrjälä 2022-04-26 19:10 ` [Intel-gfx] " Ville Syrjälä 2022-04-14 15:06 ` [PATCH 07/19] drm/edid: convert add_cea_modes() to use cea db iter Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 08/19] drm/edid: convert drm_edid_to_speaker_allocation() " Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 09/19] drm/edid: convert drm_edid_to_sad() " Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 10/19] drm/edid: convert drm_detect_hdmi_monitor() " Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 11/19] drm/edid: convert drm_detect_monitor_audio() " Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 12/19] drm/edid: convert drm_parse_cea_ext() " Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 13/19] drm/edid: convert drm_edid_to_eld() " Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 14/19] drm/edid: sunset the old unused cea data block iterators Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 15/19] drm/edid: restore some type safety to cea_db_*() functions Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:06 ` [PATCH 16/19] drm/edid: detect basic audio in all CEA extensions Jani Nikula 2022-04-14 15:06 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:07 ` [PATCH 17/19] drm/edid: detect color formats and CTA revision in all CTA extensions Jani Nikula 2022-04-14 15:07 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:07 ` [PATCH 18/19] drm/edid: skip CTA extension scan in drm_edid_to_eld() just for CTA rev Jani Nikula 2022-04-14 15:07 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:07 ` [PATCH 19/19] drm/edid: sunset drm_find_cea_extension() Jani Nikula 2022-04-14 15:07 ` [Intel-gfx] " Jani Nikula 2022-04-14 15:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more Patchwork 2022-04-14 15:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2022-04-14 17:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: CEA data block iterators, and more (rev2) Patchwork 2022-04-14 17:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-04-14 20:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YmhDB6LxHXJvBMRB@intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=ankit.k.nautiyal@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=shawn.c.lee@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.