From: Borislav Petkov <bp@alien8.de>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
linux-hyperv@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Arnd Bergmann <arnd@arndb.de>, Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Oleksandr Tyshchenko <olekstysh@gmail.com>
Subject: Re: [PATCH 1/2] kernel: add platform_has() infrastructure
Date: Tue, 26 Apr 2022 22:09:38 +0200 [thread overview]
Message-ID: <YmhRgn896loDHofa@zn.tnic> (raw)
In-Reply-To: <YmhNxnHMe/of4rDD@osiris>
On Tue, Apr 26, 2022 at 09:53:42PM +0200, Heiko Carstens wrote:
> > You probably should make that thing static and use only accessors to
> > modify it in case you wanna change the underlying data structure in the
> > future.
>
> That would add another indirection, which at least I think is not
> necessary and would make it less likely that this infrastructure is
> used.
So if you want to have a single variable which contains platform feature
bits, you don't need any platform_<bla> accessors but use this variable
directly.
I'd prefer the accessors any day of the week, though.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: linux-hyperv@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Wei Liu <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Dexuan Cui <decui@microsoft.com>,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Vasily Gorbik <gor@linux.ibm.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org,
Oleksandr Tyshchenko <olekstysh@gmail.com>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH 1/2] kernel: add platform_has() infrastructure
Date: Tue, 26 Apr 2022 22:09:38 +0200 [thread overview]
Message-ID: <YmhRgn896loDHofa@zn.tnic> (raw)
In-Reply-To: <YmhNxnHMe/of4rDD@osiris>
On Tue, Apr 26, 2022 at 09:53:42PM +0200, Heiko Carstens wrote:
> > You probably should make that thing static and use only accessors to
> > modify it in case you wanna change the underlying data structure in the
> > future.
>
> That would add another indirection, which at least I think is not
> necessary and would make it less likely that this infrastructure is
> used.
So if you want to have a single variable which contains platform feature
bits, you don't need any platform_<bla> accessors but use this variable
directly.
I'd prefer the accessors any day of the week, though.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-04-26 20:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 13:40 [PATCH 0/2] kernel: add new infrastructure for platform_has() support Juergen Gross
2022-04-26 13:40 ` Juergen Gross via Virtualization
2022-04-26 13:40 ` [PATCH 1/2] kernel: add platform_has() infrastructure Juergen Gross
2022-04-26 13:40 ` Juergen Gross via Virtualization
2022-04-26 17:31 ` Borislav Petkov
2022-04-26 17:31 ` Borislav Petkov
2022-04-26 19:53 ` Heiko Carstens
2022-04-26 20:09 ` Borislav Petkov [this message]
2022-04-26 20:09 ` Borislav Petkov
2022-04-27 6:20 ` Juergen Gross
2022-04-27 6:20 ` Juergen Gross via Virtualization
2022-04-26 13:40 ` [PATCH 2/2] virtio: replace arch_has_restricted_virtio_memory_access() Juergen Gross
2022-04-26 13:40 ` Juergen Gross via Virtualization
2022-04-26 17:35 ` Borislav Petkov
2022-04-26 17:35 ` Borislav Petkov
2022-04-26 19:51 ` Heiko Carstens
2022-04-27 6:40 ` Juergen Gross
2022-04-27 6:40 ` Juergen Gross via Virtualization
2022-04-27 12:26 ` Borislav Petkov
2022-04-27 12:26 ` Borislav Petkov
2022-04-27 12:45 ` Juergen Gross
2022-04-27 12:45 ` Juergen Gross via Virtualization
2022-04-27 6:37 ` Juergen Gross
2022-04-27 6:37 ` Juergen Gross via Virtualization
2022-04-27 12:28 ` Borislav Petkov
2022-04-27 12:28 ` Borislav Petkov
2022-04-27 12:37 ` Juergen Gross
2022-04-27 12:37 ` Juergen Gross via Virtualization
2022-04-27 14:09 ` Tom Lendacky
2022-04-27 14:09 ` Tom Lendacky via Virtualization
2022-04-27 14:14 ` Juergen Gross
2022-04-27 14:14 ` Juergen Gross via Virtualization
2022-04-27 7:48 ` [PATCH 0/2] kernel: add new infrastructure for platform_has() support Oleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmhRgn896loDHofa@zn.tnic \
--to=bp@alien8.de \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=gor@linux.ibm.com \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=olekstysh@gmail.com \
--cc=peterz@infradead.org \
--cc=sthemmin@microsoft.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.