* [PATCH 0/2] dmaengine/ARM: use proper 'dma-channels/requests' properties
@ 2022-04-27 16:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:15 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
Hi,
The core DT schema defines generic 'dma-channels' and 'dma-requests'
properties, so in preparation to moving bindings to DT schema, convert
existing users of '#dma-channels' and '#dma-requests' to the generic
variant.
Not tested on hardware.
IMPORTANT
=========
The patchset is not bisectable! The DTS patches should be applied a
release *after* driver change is accepted.
See also:
[1] https://lore.kernel.org/linux-devicetree/fedb56be-f275-aabb-cdf5-dbd394b8a7bd@linaro.org/T/#m6235f451045c337d70a62dc65eab9a716618550b
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] dt-bindings: dmaengine: fsl-imx: deprecate '#dma-channels' and '#dma-requests'
2022-04-27 16:15 ` Krzysztof Kozlowski
@ 2022-04-27 16:15 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:15 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The generic properties, used in most of the drivers and defined in
generic dma-common DT bindings, are 'dma-channels' and 'dma-requests'.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/dma/fsl-imx-dma.txt | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
index 7bd8847d6394..1c9929d53727 100644
--- a/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
+++ b/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
@@ -13,8 +13,10 @@ Required properties:
- #dma-cells : Has to be 1. imx-dma does not support anything else.
Optional properties:
-- #dma-channels : Number of DMA channels supported. Should be 16.
-- #dma-requests : Number of DMA requests supported.
+- dma-channels : Number of DMA channels supported. Should be 16.
+- #dma-channels : deprecated
+- dma-requests : Number of DMA requests supported.
+- #dma-requests : deprecated
Example:
@@ -23,7 +25,7 @@ Example:
reg = <0x10001000 0x1000>;
interrupts = <32 33>;
#dma-cells = <1>;
- #dma-channels = <16>;
+ dma-channels = <16>;
};
--
2.32.0
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/2] dt-bindings: dmaengine: fsl-imx: deprecate '#dma-channels' and '#dma-requests'
@ 2022-04-27 16:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:15 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The generic properties, used in most of the drivers and defined in
generic dma-common DT bindings, are 'dma-channels' and 'dma-requests'.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/dma/fsl-imx-dma.txt | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt b/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
index 7bd8847d6394..1c9929d53727 100644
--- a/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
+++ b/Documentation/devicetree/bindings/dma/fsl-imx-dma.txt
@@ -13,8 +13,10 @@ Required properties:
- #dma-cells : Has to be 1. imx-dma does not support anything else.
Optional properties:
-- #dma-channels : Number of DMA channels supported. Should be 16.
-- #dma-requests : Number of DMA requests supported.
+- dma-channels : Number of DMA channels supported. Should be 16.
+- #dma-channels : deprecated
+- dma-requests : Number of DMA requests supported.
+- #dma-requests : deprecated
Example:
@@ -23,7 +25,7 @@ Example:
reg = <0x10001000 0x1000>;
interrupts = <32 33>;
#dma-cells = <1>;
- #dma-channels = <16>;
+ dma-channels = <16>;
};
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: dmaengine: fsl-imx: deprecate '#dma-channels' and '#dma-requests'
2022-04-27 16:15 ` Krzysztof Kozlowski
@ 2022-04-27 18:28 ` Rob Herring
-1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-04-27 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: NXP Linux Team, Krzysztof Kozlowski, Vinod Koul, Fabio Estevam,
Rob Herring, Pengutronix Kernel Team, linux-kernel, Shawn Guo,
Sascha Hauer, linux-arm-kernel, dmaengine, devicetree
On Wed, 27 Apr 2022 18:15:32 +0200, Krzysztof Kozlowski wrote:
> The generic properties, used in most of the drivers and defined in
> generic dma-common DT bindings, are 'dma-channels' and 'dma-requests'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/dma/fsl-imx-dma.txt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: dmaengine: fsl-imx: deprecate '#dma-channels' and '#dma-requests'
@ 2022-04-27 18:28 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-04-27 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: NXP Linux Team, Krzysztof Kozlowski, Vinod Koul, Fabio Estevam,
Rob Herring, Pengutronix Kernel Team, linux-kernel, Shawn Guo,
Sascha Hauer, linux-arm-kernel, dmaengine, devicetree
On Wed, 27 Apr 2022 18:15:32 +0200, Krzysztof Kozlowski wrote:
> The generic properties, used in most of the drivers and defined in
> generic dma-common DT bindings, are 'dma-channels' and 'dma-requests'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/dma/fsl-imx-dma.txt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: dmaengine: fsl-imx: deprecate '#dma-channels' and '#dma-requests'
2022-04-27 16:15 ` Krzysztof Kozlowski
@ 2022-05-05 5:29 ` Shawn Guo
-1 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2022-05-05 5:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dmaengine, devicetree, linux-arm-kernel, linux-kernel
On Wed, Apr 27, 2022 at 06:15:32PM +0200, Krzysztof Kozlowski wrote:
> The generic properties, used in most of the drivers and defined in
> generic dma-common DT bindings, are 'dma-channels' and 'dma-requests'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied both, thanks!
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] dt-bindings: dmaengine: fsl-imx: deprecate '#dma-channels' and '#dma-requests'
@ 2022-05-05 5:29 ` Shawn Guo
0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2022-05-05 5:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dmaengine, devicetree, linux-arm-kernel, linux-kernel
On Wed, Apr 27, 2022 at 06:15:32PM +0200, Krzysztof Kozlowski wrote:
> The generic properties, used in most of the drivers and defined in
> generic dma-common DT bindings, are 'dma-channels' and 'dma-requests'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied both, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/2] ARM: dts: imx27: use new 'dma-channels' property
2022-04-27 16:15 ` Krzysztof Kozlowski
@ 2022-04-27 16:15 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:15 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The '#dma-channels' property was deprecated in favor of one defined by
generic dma-common DT bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/imx27.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index fd525c3b16fa..b660c7d05584 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -96,7 +96,7 @@ dma: dma@10001000 {
<&clks IMX27_CLK_DMA_AHB_GATE>;
clock-names = "ipg", "ahb";
#dma-cells = <1>;
- #dma-channels = <16>;
+ dma-channels = <16>;
};
wdog: watchdog@10002000 {
--
2.32.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/2] ARM: dts: imx27: use new 'dma-channels' property
@ 2022-04-27 16:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 16:15 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dmaengine, devicetree, linux-arm-kernel,
linux-kernel
Cc: Krzysztof Kozlowski
The '#dma-channels' property was deprecated in favor of one defined by
generic dma-common DT bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/imx27.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index fd525c3b16fa..b660c7d05584 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -96,7 +96,7 @@ dma: dma@10001000 {
<&clks IMX27_CLK_DMA_AHB_GATE>;
clock-names = "ipg", "ahb";
#dma-cells = <1>;
- #dma-channels = <16>;
+ dma-channels = <16>;
};
wdog: watchdog@10002000 {
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] dmaengine/ARM: use proper 'dma-channels/requests' properties
2022-04-27 16:15 ` Krzysztof Kozlowski
@ 2022-04-27 18:28 ` Rob Herring
-1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-04-27 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dmaengine, devicetree, linux-arm-kernel, linux-kernel
On Wed, Apr 27, 2022 at 06:15:31PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> The core DT schema defines generic 'dma-channels' and 'dma-requests'
> properties, so in preparation to moving bindings to DT schema, convert
> existing users of '#dma-channels' and '#dma-requests' to the generic
> variant.
>
> Not tested on hardware.
>
> IMPORTANT
> =========
> The patchset is not bisectable! The DTS patches should be applied a
> release *after* driver change is accepted.
There's no driver change though...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] dmaengine/ARM: use proper 'dma-channels/requests' properties
@ 2022-04-27 18:28 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2022-04-27 18:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dmaengine, devicetree, linux-arm-kernel, linux-kernel
On Wed, Apr 27, 2022 at 06:15:31PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> The core DT schema defines generic 'dma-channels' and 'dma-requests'
> properties, so in preparation to moving bindings to DT schema, convert
> existing users of '#dma-channels' and '#dma-requests' to the generic
> variant.
>
> Not tested on hardware.
>
> IMPORTANT
> =========
> The patchset is not bisectable! The DTS patches should be applied a
> release *after* driver change is accepted.
There's no driver change though...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] dmaengine/ARM: use proper 'dma-channels/requests' properties
2022-04-27 18:28 ` Rob Herring
@ 2022-04-27 19:30 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 19:30 UTC (permalink / raw)
To: Rob Herring
Cc: Vinod Koul, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, dmaengine, devicetree,
linux-arm-kernel, linux-kernel
On Wed, 27 Apr 2022 at 20:28, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Apr 27, 2022 at 06:15:31PM +0200, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > The core DT schema defines generic 'dma-channels' and 'dma-requests'
> > properties, so in preparation to moving bindings to DT schema, convert
> > existing users of '#dma-channels' and '#dma-requests' to the generic
> > variant.
> >
> > Not tested on hardware.
> >
> > IMPORTANT
> > =========
> > The patchset is not bisectable! The DTS patches should be applied a
> > release *after* driver change is accepted.
>
> There's no driver change though...
Indeed, copy paste cover letter. This FSL dma driver does not use the
properties, so it's only in the bindings and in the DTS. The patchset
can be taken as-is, without in-kernel ABI break. Only out-of-tree
users of DTSI will be affected.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] dmaengine/ARM: use proper 'dma-channels/requests' properties
@ 2022-04-27 19:30 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-27 19:30 UTC (permalink / raw)
To: Rob Herring
Cc: Vinod Koul, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, dmaengine, devicetree,
linux-arm-kernel, linux-kernel
On Wed, 27 Apr 2022 at 20:28, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Apr 27, 2022 at 06:15:31PM +0200, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > The core DT schema defines generic 'dma-channels' and 'dma-requests'
> > properties, so in preparation to moving bindings to DT schema, convert
> > existing users of '#dma-channels' and '#dma-requests' to the generic
> > variant.
> >
> > Not tested on hardware.
> >
> > IMPORTANT
> > =========
> > The patchset is not bisectable! The DTS patches should be applied a
> > release *after* driver change is accepted.
>
> There's no driver change though...
Indeed, copy paste cover letter. This FSL dma driver does not use the
properties, so it's only in the bindings and in the DTS. The patchset
can be taken as-is, without in-kernel ABI break. Only out-of-tree
users of DTSI will be affected.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread