From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Adrien Thierry <athierry@redhat.com> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vchiq_arm: use standard print helpers Date: Thu, 28 Apr 2022 17:23:17 +0200 [thread overview] Message-ID: <YmqxZevQJpWuLlQ3@kroah.com> (raw) In-Reply-To: <20220428150550.261499-1-athierry@redhat.com> On Thu, Apr 28, 2022 at 11:05:49AM -0400, Adrien Thierry wrote: > Replace the custom debug print macros with the standard dev_err() and > friends. > > This handles TODO item "Cleanup logging mechanism". > > Signed-off-by: Adrien Thierry <athierry@redhat.com> > --- > > Changes since v1: removed function name in dev_dbg() calls > > .../interface/vchiq_arm/vchiq_arm.c | 157 +++--- > .../interface/vchiq_arm/vchiq_connected.c | 7 +- > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++---------- > .../interface/vchiq_arm/vchiq_core.h | 43 +- > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ---- > .../interface/vchiq_arm/vchiq_dev.c | 86 ++- > 7 files changed, 341 insertions(+), 556 deletions(-) Try doing this in smaller chunks. There's a lot of churn here, and not all of it is correct. Try removing these one-function-at-a-time and then when it's all finished, you can remove the debugfs and function calls as no one is calling them. That way it's also easier to review, as-is, this is a tough review. Would you want to review this at once? A few odd things that jumped out at me: > @@ -1332,6 +1325,8 @@ vchiq_keepalive_thread_func(void *v) > struct vchiq_state *state = (struct vchiq_state *)v; > struct vchiq_arm_state *arm_state = vchiq_platform_get_arm_state(state); > > + struct device *dev = state->dev; > + Checkpatch should have warned you about the extra blank line here. Put all variables one after each other please. > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > @@ -27,7 +27,7 @@ static void connected_init(void) > * be made immediately, otherwise it will be deferred until > * vchiq_call_connected_callbacks is called. > */ > -void vchiq_add_connected_callback(void (*callback)(void)) > +void vchiq_add_connected_callback(struct device *dev, void (*callback)(void)) Pass in the real vchiq device pointer, not a struct device. > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > @@ -4,7 +4,9 @@ > #ifndef VCHIQ_CONNECTED_H > #define VCHIQ_CONNECTED_H > > -void vchiq_add_connected_callback(void (*callback)(void)); > +#include <linux/device.h> Don't include the .h file here, it shouldn't be needed if you make this the same real device type. > > struct vchiq_state { > + struct device *dev; Careful now, have you properly handled the reference counting? I can't tell so you should do this type of change on it's own to make it obvious you handle it properly. > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c > @@ -37,6 +37,8 @@ static const char *const ioctl_names[] = { > "CLOSE_DELIVERED" > }; > > +static struct miscdevice vchiq_miscdev; That looks really odd. If you create this, where are you initializing it? Did you test this code? thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Adrien Thierry <athierry@redhat.com> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vchiq_arm: use standard print helpers Date: Thu, 28 Apr 2022 17:23:17 +0200 [thread overview] Message-ID: <YmqxZevQJpWuLlQ3@kroah.com> (raw) In-Reply-To: <20220428150550.261499-1-athierry@redhat.com> On Thu, Apr 28, 2022 at 11:05:49AM -0400, Adrien Thierry wrote: > Replace the custom debug print macros with the standard dev_err() and > friends. > > This handles TODO item "Cleanup logging mechanism". > > Signed-off-by: Adrien Thierry <athierry@redhat.com> > --- > > Changes since v1: removed function name in dev_dbg() calls > > .../interface/vchiq_arm/vchiq_arm.c | 157 +++--- > .../interface/vchiq_arm/vchiq_connected.c | 7 +- > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > .../interface/vchiq_arm/vchiq_core.c | 495 ++++++++---------- > .../interface/vchiq_arm/vchiq_core.h | 43 +- > .../interface/vchiq_arm/vchiq_debugfs.c | 105 ---- > .../interface/vchiq_arm/vchiq_dev.c | 86 ++- > 7 files changed, 341 insertions(+), 556 deletions(-) Try doing this in smaller chunks. There's a lot of churn here, and not all of it is correct. Try removing these one-function-at-a-time and then when it's all finished, you can remove the debugfs and function calls as no one is calling them. That way it's also easier to review, as-is, this is a tough review. Would you want to review this at once? A few odd things that jumped out at me: > @@ -1332,6 +1325,8 @@ vchiq_keepalive_thread_func(void *v) > struct vchiq_state *state = (struct vchiq_state *)v; > struct vchiq_arm_state *arm_state = vchiq_platform_get_arm_state(state); > > + struct device *dev = state->dev; > + Checkpatch should have warned you about the extra blank line here. Put all variables one after each other please. > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > @@ -27,7 +27,7 @@ static void connected_init(void) > * be made immediately, otherwise it will be deferred until > * vchiq_call_connected_callbacks is called. > */ > -void vchiq_add_connected_callback(void (*callback)(void)) > +void vchiq_add_connected_callback(struct device *dev, void (*callback)(void)) Pass in the real vchiq device pointer, not a struct device. > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h > @@ -4,7 +4,9 @@ > #ifndef VCHIQ_CONNECTED_H > #define VCHIQ_CONNECTED_H > > -void vchiq_add_connected_callback(void (*callback)(void)); > +#include <linux/device.h> Don't include the .h file here, it shouldn't be needed if you make this the same real device type. > > struct vchiq_state { > + struct device *dev; Careful now, have you properly handled the reference counting? I can't tell so you should do this type of change on it's own to make it obvious you handle it properly. > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c > @@ -37,6 +37,8 @@ static const char *const ioctl_names[] = { > "CLOSE_DELIVERED" > }; > > +static struct miscdevice vchiq_miscdev; That looks really odd. If you create this, where are you initializing it? Did you test this code? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-28 15:23 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-28 15:05 [PATCH v2] staging: vchiq_arm: use standard print helpers Adrien Thierry 2022-04-28 15:05 ` Adrien Thierry 2022-04-28 15:23 ` Greg Kroah-Hartman [this message] 2022-04-28 15:23 ` Greg Kroah-Hartman 2022-04-28 15:45 ` Greg Kroah-Hartman 2022-04-28 15:45 ` Greg Kroah-Hartman 2022-04-30 7:48 ` Stefan Wahren 2022-04-30 7:48 ` Stefan Wahren 2022-05-02 17:08 ` Adrien Thierry 2022-05-02 17:08 ` Adrien Thierry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YmqxZevQJpWuLlQ3@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=athierry@redhat.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-staging@lists.linux.dev \ --cc=nsaenz@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.