* [PATCH] iguanair: no superfluous usb_unlink_urb()
@ 2022-05-12 12:50 Oliver Neukum
2022-05-13 16:20 ` Sean Young
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2022-05-12 12:50 UTC (permalink / raw)
To: linux-media, mchehab, sean; +Cc: Oliver Neukum
Unlinking yourself while the completion handler
is running is a NOP. Drop it.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/media/rc/iguanair.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index c9cb8277723f..276bf3c8a8cb 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media/rc/iguanair.c
@@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)
return;
ir = urb->context;
- if (!ir) {
- usb_unlink_urb(urb);
+ if (!ir)
return;
- }
switch (urb->status) {
case 0:
@@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)
case -ECONNRESET:
case -ENOENT:
case -ESHUTDOWN:
- usb_unlink_urb(urb);
return;
case -EPIPE:
default:
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iguanair: no superfluous usb_unlink_urb()
2022-05-12 12:50 [PATCH] iguanair: no superfluous usb_unlink_urb() Oliver Neukum
@ 2022-05-13 16:20 ` Sean Young
0 siblings, 0 replies; 2+ messages in thread
From: Sean Young @ 2022-05-13 16:20 UTC (permalink / raw)
To: Oliver Neukum; +Cc: linux-media, mchehab
On Thu, May 12, 2022 at 02:50:00PM +0200, Oliver Neukum wrote:
> Unlinking yourself while the completion handler
> is running is a NOP. Drop it.
Applied, thanks!
Sean
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/media/rc/iguanair.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
> index c9cb8277723f..276bf3c8a8cb 100644
> --- a/drivers/media/rc/iguanair.c
> +++ b/drivers/media/rc/iguanair.c
> @@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)
> return;
>
> ir = urb->context;
> - if (!ir) {
> - usb_unlink_urb(urb);
> + if (!ir)
> return;
> - }
>
> switch (urb->status) {
> case 0:
> @@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)
> case -ECONNRESET:
> case -ENOENT:
> case -ESHUTDOWN:
> - usb_unlink_urb(urb);
> return;
> case -EPIPE:
> default:
> --
> 2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-13 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 12:50 [PATCH] iguanair: no superfluous usb_unlink_urb() Oliver Neukum
2022-05-13 16:20 ` Sean Young
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.