* [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible
@ 2022-04-26 17:59 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-04-26 17:59 UTC (permalink / raw)
To: Bartosz Golaszewski, Krzysztof Kozlowski, Alim Akhtar
Cc: Bartosz Golaszewski, Krzysztof Kozlowski, linux-i2c, devicetree,
linux-kernel, linux-arm-kernel, linux-samsung-soc
The samsung,s524ad0xd1 compatible is in use, but not documented. According
to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
with the 24c128. As the schema requires a fallback compatible to the
corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
- Fix the example in samsung,s3c2410-i2c.yaml
Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
.../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 6b61a8cf6137..d14e0accbda8 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -120,7 +120,9 @@ properties:
- const: giantec,gt24c32a
- const: atmel,24c32
- items:
- - const: renesas,r1ex24128
+ - enum:
+ - renesas,r1ex24128
+ - samsung,s524ad0xd1
- const: atmel,24c128
label:
diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
index c26230518957..3d5782deb97d 100644
--- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
@@ -123,7 +123,7 @@ examples:
samsung,i2c-slave-addr = <0x66>;
eeprom@50 {
- compatible = "samsung,s524ad0xd1";
+ compatible = "samsung,s524ad0xd1", "atmel,24c128";
reg = <0x50>;
};
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
2022-04-26 17:59 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible Rob Herring
@ 2022-04-26 18:31 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-26 18:31 UTC (permalink / raw)
To: Rob Herring, Bartosz Golaszewski, Krzysztof Kozlowski, Alim Akhtar
Cc: Bartosz Golaszewski, linux-i2c, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc
On 26/04/2022 19:59, Rob Herring wrote:
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
There is still a DTS to fix. I assume you leave it for volunteers, so
I'll send a patch for it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
@ 2022-04-26 18:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-26 18:31 UTC (permalink / raw)
To: Rob Herring, Bartosz Golaszewski, Krzysztof Kozlowski, Alim Akhtar
Cc: Bartosz Golaszewski, linux-i2c, devicetree, linux-kernel,
linux-arm-kernel, linux-samsung-soc
On 26/04/2022 19:59, Rob Herring wrote:
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
There is still a DTS to fix. I assume you leave it for volunteers, so
I'll send a patch for it.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
2022-04-26 17:59 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible Rob Herring
@ 2022-05-02 12:02 ` Bartosz Golaszewski
-1 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2022-05-02 12:02 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Alim Akhtar, Bartosz Golaszewski,
Krzysztof Kozlowski, linux-i2c, devicetree,
Linux Kernel Mailing List, Linux ARM, linux-samsung-soc
On Tue, Apr 26, 2022 at 8:00 PM Rob Herring <robh@kernel.org> wrote:
>
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
For at24 part:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 6b61a8cf6137..d14e0accbda8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -120,7 +120,9 @@ properties:
> - const: giantec,gt24c32a
> - const: atmel,24c32
> - items:
> - - const: renesas,r1ex24128
> + - enum:
> + - renesas,r1ex24128
> + - samsung,s524ad0xd1
> - const: atmel,24c128
>
> label:
> diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> index c26230518957..3d5782deb97d 100644
> --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> @@ -123,7 +123,7 @@ examples:
> samsung,i2c-slave-addr = <0x66>;
>
> eeprom@50 {
> - compatible = "samsung,s524ad0xd1";
> + compatible = "samsung,s524ad0xd1", "atmel,24c128";
> reg = <0x50>;
> };
> };
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible
@ 2022-05-02 12:02 ` Bartosz Golaszewski
0 siblings, 0 replies; 8+ messages in thread
From: Bartosz Golaszewski @ 2022-05-02 12:02 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Alim Akhtar, Bartosz Golaszewski,
Krzysztof Kozlowski, linux-i2c, devicetree,
Linux Kernel Mailing List, Linux ARM, linux-samsung-soc
On Tue, Apr 26, 2022 at 8:00 PM Rob Herring <robh@kernel.org> wrote:
>
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
For at24 part:
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 6b61a8cf6137..d14e0accbda8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -120,7 +120,9 @@ properties:
> - const: giantec,gt24c32a
> - const: atmel,24c32
> - items:
> - - const: renesas,r1ex24128
> + - enum:
> + - renesas,r1ex24128
> + - samsung,s524ad0xd1
> - const: atmel,24c128
>
> label:
> diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> index c26230518957..3d5782deb97d 100644
> --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> @@ -123,7 +123,7 @@ examples:
> samsung,i2c-slave-addr = <0x66>;
>
> eeprom@50 {
> - compatible = "samsung,s524ad0xd1";
> + compatible = "samsung,s524ad0xd1", "atmel,24c128";
> reg = <0x50>;
> };
> };
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
2022-04-26 17:59 ` [PATCH v2] dt-bindings: eeprom/at24: Add samsung, s524ad0xd1 compatible Rob Herring
@ 2022-05-02 18:40 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-02 18:40 UTC (permalink / raw)
To: Rob Herring
Cc: Bartosz Golaszewski, Krzysztof Kozlowski, linux-samsung-soc,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
Krzysztof Kozlowski, linux-i2c, linux-kernel, Alim Akhtar
On Tue, 26 Apr 2022 12:59:39 -0500, Rob Herring wrote:
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
@ 2022-05-02 18:40 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-05-02 18:40 UTC (permalink / raw)
To: Rob Herring
Cc: Bartosz Golaszewski, Krzysztof Kozlowski, linux-samsung-soc,
Bartosz Golaszewski, devicetree, linux-arm-kernel,
Krzysztof Kozlowski, linux-i2c, linux-kernel, Alim Akhtar
On Tue, 26 Apr 2022 12:59:39 -0500, Rob Herring wrote:
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread