[PATCH net] selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer

[PATCH net] selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer

[Vladimir Oltean]

As discussed here with Ido Schimmel:
https://patchwork.kernel.org/project/netdevbpf/patch/20220224102908.5255-2-jianbol@nvidia.com/

the default conform-exceed action is "reclassify", for a reason we don't
really understand.

The point is that hardware can't offload that police action, so not
specifying "conform-exceed" was always wrong, even though the command
used to work in hardware (but not in software) until the kernel started
adding validation for it.

Fix the command used by the selftest by making the policer drop on
exceed, and pass the packet to the next action (goto) on conform.

Fixes: 8cd6b020b644 ("selftests: ocelot: add some example VCAP IS1, IS2 and ES0 tc offloads")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh b/tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh
index 7e684e27a682..4401a654c2c0 100755
--- a/tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh
+++ b/tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh
@@ -190,7 +190,7 @@ setup_prepare()
 
 	tc filter add dev $eth0 ingress chain $(IS2 0 0) pref 1 \
 		protocol ipv4 flower skip_sw ip_proto udp dst_port 5201 \
-		action police rate 50mbit burst 64k \
+		action police rate 50mbit burst 64k conform-exceed drop/pipe \
 		action goto chain $(IS2 1 0)
 }
 
-- 
2.25.1

Re: [PATCH net] selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer

[Ido Schimmel]

On Tue, May 03, 2022 at 03:14:28PM +0300, Vladimir Oltean wrote:
> As discussed here with Ido Schimmel:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220224102908.5255-2-jianbol@nvidia.com/
> 
> the default conform-exceed action is "reclassify", for a reason we don't
> really understand.
> 
> The point is that hardware can't offload that police action, so not
> specifying "conform-exceed" was always wrong, even though the command
> used to work in hardware (but not in software) until the kernel started
> adding validation for it.
> 
> Fix the command used by the selftest by making the policer drop on
> exceed, and pass the packet to the next action (goto) on conform.
> 
> Fixes: 8cd6b020b644 ("selftests: ocelot: add some example VCAP IS1, IS2 and ES0 tc offloads")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH net] selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  3 May 2022 15:14:28 +0300 you wrote:
> As discussed here with Ido Schimmel:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220224102908.5255-2-jianbol@nvidia.com/
> 
> the default conform-exceed action is "reclassify", for a reason we don't
> really understand.
> 
> The point is that hardware can't offload that police action, so not
> specifying "conform-exceed" was always wrong, even though the command
> used to work in hardware (but not in software) until the kernel started
> adding validation for it.
> 
> [...]

Here is the summary with links:
  - [net] selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer
    https://git.kernel.org/netdev/net/c/5a7c5f70c743

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html