From: Jean-Philippe Brucker <jean-philippe@linaro.org> To: Lu Baolu <baolu.lu@linux.intel.com> Cc: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, Kevin Tian <kevin.tian@intel.com>, Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>, Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>, Jacob jun Pan <jacob.jun.pan@intel.com>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 02/12] iommu: Add pasid_bits field in struct dev_iommu Date: Tue, 3 May 2022 19:02:22 +0100 [thread overview] Message-ID: <YnFuLsvWcjjKBWNy@myrica> (raw) In-Reply-To: <20220502014842.991097-3-baolu.lu@linux.intel.com> On Mon, May 02, 2022 at 09:48:32AM +0800, Lu Baolu wrote: > Use this field to save the pasid/ssid bits that a device is able to > support with its IOMMU hardware. It is a generic attribute of a device > and lifting it into the per-device dev_iommu struct makes it possible > to allocate a PASID for device without calls into the IOMMU drivers. > Any iommu driver which suports PASID related features should set this > field before features are enabled on the devices. > > For initialization of this field in the VT-d driver, the > info->pasid_supported is only set for PCI devices. So the status is > that non-PCI SVA hasn't been supported yet. Setting this field only for > PCI devices has no functional change. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > include/linux/iommu.h | 1 + > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 ++ > drivers/iommu/intel/iommu.c | 5 ++++- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 5e1afe169549..b8ffaf2cb1d0 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -373,6 +373,7 @@ struct dev_iommu { > struct iommu_fwspec *fwspec; > struct iommu_device *iommu_dev; > void *priv; > + unsigned int pasid_bits; > }; > > int iommu_device_register(struct iommu_device *iommu, > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 627a3ed5ee8f..afc63fce6107 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2681,6 +2681,8 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev) > smmu->features & ARM_SMMU_FEAT_STALL_FORCE) > master->stall_enabled = true; > > + dev->iommu->pasid_bits = master->ssid_bits; > + > return &smmu->iommu; > > err_free_master: > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c > index cf43e8f9091b..170eb777d57b 100644 > --- a/drivers/iommu/intel/iommu.c > +++ b/drivers/iommu/intel/iommu.c > @@ -4611,8 +4611,11 @@ static struct iommu_device *intel_iommu_probe_device(struct device *dev) > if (pasid_supported(iommu)) { > int features = pci_pasid_features(pdev); > > - if (features >= 0) > + if (features >= 0) { > info->pasid_supported = features | 1; > + dev->iommu->pasid_bits = > + fls(pci_max_pasids(pdev)) - 1; > + } > } > > if (info->ats_supported && ecap_prs(iommu->ecap) && > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe@linaro.org> To: Lu Baolu <baolu.lu@linux.intel.com> Cc: Kevin Tian <kevin.tian@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ashok Raj <ashok.raj@intel.com>, Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Jean-Philippe Brucker <jean-philippe@linaro.com>, Vinod Koul <vkoul@kernel.org>, Jacob jun Pan <jacob.jun.pan@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Will Deacon <will@kernel.org> Subject: Re: [PATCH v5 02/12] iommu: Add pasid_bits field in struct dev_iommu Date: Tue, 3 May 2022 19:02:22 +0100 [thread overview] Message-ID: <YnFuLsvWcjjKBWNy@myrica> (raw) In-Reply-To: <20220502014842.991097-3-baolu.lu@linux.intel.com> On Mon, May 02, 2022 at 09:48:32AM +0800, Lu Baolu wrote: > Use this field to save the pasid/ssid bits that a device is able to > support with its IOMMU hardware. It is a generic attribute of a device > and lifting it into the per-device dev_iommu struct makes it possible > to allocate a PASID for device without calls into the IOMMU drivers. > Any iommu driver which suports PASID related features should set this > field before features are enabled on the devices. > > For initialization of this field in the VT-d driver, the > info->pasid_supported is only set for PCI devices. So the status is > that non-PCI SVA hasn't been supported yet. Setting this field only for > PCI devices has no functional change. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > include/linux/iommu.h | 1 + > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 ++ > drivers/iommu/intel/iommu.c | 5 ++++- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 5e1afe169549..b8ffaf2cb1d0 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -373,6 +373,7 @@ struct dev_iommu { > struct iommu_fwspec *fwspec; > struct iommu_device *iommu_dev; > void *priv; > + unsigned int pasid_bits; > }; > > int iommu_device_register(struct iommu_device *iommu, > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 627a3ed5ee8f..afc63fce6107 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2681,6 +2681,8 @@ static struct iommu_device *arm_smmu_probe_device(struct device *dev) > smmu->features & ARM_SMMU_FEAT_STALL_FORCE) > master->stall_enabled = true; > > + dev->iommu->pasid_bits = master->ssid_bits; > + > return &smmu->iommu; > > err_free_master: > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c > index cf43e8f9091b..170eb777d57b 100644 > --- a/drivers/iommu/intel/iommu.c > +++ b/drivers/iommu/intel/iommu.c > @@ -4611,8 +4611,11 @@ static struct iommu_device *intel_iommu_probe_device(struct device *dev) > if (pasid_supported(iommu)) { > int features = pci_pasid_features(pdev); > > - if (features >= 0) > + if (features >= 0) { > info->pasid_supported = features | 1; > + dev->iommu->pasid_bits = > + fls(pci_max_pasids(pdev)) - 1; > + } > } > > if (info->ats_supported && ecap_prs(iommu->ecap) && > -- > 2.25.1 > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-03 18:02 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-02 1:48 [PATCH v5 00/12] iommu: SVA and IOPF refactoring Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-02 1:48 ` [PATCH v5 01/12] dmaengine: idxd: Separate user and kernel pasid enabling Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-02 1:48 ` [PATCH v5 02/12] iommu: Add pasid_bits field in struct dev_iommu Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:02 ` Jean-Philippe Brucker [this message] 2022-05-03 18:02 ` Jean-Philippe Brucker 2022-05-05 6:25 ` Baolu Lu 2022-05-05 6:25 ` Baolu Lu 2022-05-02 1:48 ` [PATCH v5 03/12] iommu: Add attach/detach_dev_pasid domain ops Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:07 ` Jean-Philippe Brucker 2022-05-03 18:07 ` Jean-Philippe Brucker 2022-05-05 6:28 ` Baolu Lu 2022-05-05 6:28 ` Baolu Lu 2022-05-02 1:48 ` [PATCH v5 04/12] iommu/sva: Basic data structures for SVA Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:09 ` Jean-Philippe Brucker 2022-05-03 18:09 ` Jean-Philippe Brucker 2022-05-05 6:42 ` Baolu Lu 2022-05-05 6:42 ` Baolu Lu 2022-05-07 8:32 ` Baolu Lu 2022-05-07 8:32 ` Baolu Lu 2022-05-07 12:39 ` Baolu Lu 2022-05-07 12:39 ` Baolu Lu 2022-05-02 1:48 ` [PATCH v5 05/12] iommu/vt-d: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-02 1:48 ` [PATCH v5 06/12] iommu/vt-d: Add SVA domain support Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-02 1:48 ` [PATCH v5 07/12] arm-smmu-v3/sva: " Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:12 ` Jean-Philippe Brucker 2022-05-03 18:12 ` Jean-Philippe Brucker 2022-05-05 7:09 ` Baolu Lu 2022-05-05 7:09 ` Baolu Lu 2022-05-02 1:48 ` [PATCH v5 08/12] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-02 1:48 ` [PATCH v5 09/12] iommu: Remove SVA related callbacks from iommu ops Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:14 ` Jean-Philippe Brucker 2022-05-03 18:14 ` Jean-Philippe Brucker 2022-05-02 1:48 ` [PATCH v5 10/12] iommu: Prepare IOMMU domain for IOPF Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:20 ` Jean-Philippe Brucker 2022-05-03 18:20 ` Jean-Philippe Brucker 2022-05-05 8:31 ` Baolu Lu 2022-05-05 8:31 ` Baolu Lu 2022-05-05 13:38 ` Jean-Philippe Brucker 2022-05-05 13:38 ` Jean-Philippe Brucker 2022-05-06 5:40 ` Baolu Lu 2022-05-06 5:40 ` Baolu Lu 2022-05-02 1:48 ` [PATCH v5 11/12] iommu: Per-domain I/O page fault handling Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:27 ` Jean-Philippe Brucker 2022-05-03 18:27 ` Jean-Philippe Brucker 2022-05-02 1:48 ` [PATCH v5 12/12] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu 2022-05-02 1:48 ` Lu Baolu 2022-05-03 18:28 ` Jean-Philippe Brucker 2022-05-03 18:28 ` Jean-Philippe Brucker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YnFuLsvWcjjKBWNy@myrica \ --to=jean-philippe@linaro.org \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dave.jiang@intel.com \ --cc=eric.auger@redhat.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jean-philippe@linaro.com \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robin.murphy@arm.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.