From: Eric Biggers <ebiggers@kernel.org> To: Nathan Huckleberry <nhuck@google.com> Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, Paul Crowley <paulcrowley@google.com>, Sami Tolvanen <samitolvanen@google.com>, Ard Biesheuvel <ardb@kernel.org> Subject: Re: [PATCH v6 4/9] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR Date: Wed, 4 May 2022 21:45:03 -0700 [thread overview] Message-ID: <YnNWT139+XAJ7zC1@sol.localdomain> (raw) In-Reply-To: <20220504001823.2483834-5-nhuck@google.com> On Wed, May 04, 2022 at 12:18:18AM +0000, Nathan Huckleberry wrote: > Add hardware accelerated versions of XCTR for x86-64 CPUs with AESNI > support. These implementations are modified versions of the CTR > implementations found in aesni-intel_asm.S and aes_ctrby8_avx-x86_64.S. The commit message still needs to be fixed, as I noted on v5, since there is now only one implementation being added, and aesni-intel_asm.S isn't being changed. > > More information on XCTR can be found in the HCTR2 paper: > "Length-preserving encryption with HCTR2": > https://eprint.iacr.org/2021/1441.pdf > > Signed-off-by: Nathan Huckleberry <nhuck@google.com> > Reviewed-by: Ard Biesheuvel <ardb@kernel.org> > --- > arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 232 ++++++++++++++++-------- > arch/x86/crypto/aesni-intel_glue.c | 114 +++++++++++- > crypto/Kconfig | 2 +- > 3 files changed, 266 insertions(+), 82 deletions(-) Otherwise this patch looks good: Reviewed-by: Eric Biggers <ebiggers@google.com> - Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: Nathan Huckleberry <nhuck@google.com> Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, Paul Crowley <paulcrowley@google.com>, Sami Tolvanen <samitolvanen@google.com>, Ard Biesheuvel <ardb@kernel.org> Subject: Re: [PATCH v6 4/9] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR Date: Wed, 4 May 2022 21:45:03 -0700 [thread overview] Message-ID: <YnNWT139+XAJ7zC1@sol.localdomain> (raw) In-Reply-To: <20220504001823.2483834-5-nhuck@google.com> On Wed, May 04, 2022 at 12:18:18AM +0000, Nathan Huckleberry wrote: > Add hardware accelerated versions of XCTR for x86-64 CPUs with AESNI > support. These implementations are modified versions of the CTR > implementations found in aesni-intel_asm.S and aes_ctrby8_avx-x86_64.S. The commit message still needs to be fixed, as I noted on v5, since there is now only one implementation being added, and aesni-intel_asm.S isn't being changed. > > More information on XCTR can be found in the HCTR2 paper: > "Length-preserving encryption with HCTR2": > https://eprint.iacr.org/2021/1441.pdf > > Signed-off-by: Nathan Huckleberry <nhuck@google.com> > Reviewed-by: Ard Biesheuvel <ardb@kernel.org> > --- > arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 232 ++++++++++++++++-------- > arch/x86/crypto/aesni-intel_glue.c | 114 +++++++++++- > crypto/Kconfig | 2 +- > 3 files changed, 266 insertions(+), 82 deletions(-) Otherwise this patch looks good: Reviewed-by: Eric Biggers <ebiggers@google.com> - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-05 4:45 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-04 0:18 [PATCH v6 0/9] crypto: HCTR2 support Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-04 0:18 ` [PATCH v6 1/9] crypto: xctr - Add XCTR support Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-04 0:18 ` [PATCH v6 2/9] crypto: polyval - Add POLYVAL support Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-04 0:18 ` [PATCH v6 3/9] crypto: hctr2 - Add HCTR2 support Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-04 0:18 ` [PATCH v6 4/9] crypto: x86/aesni-xctr: Add accelerated implementation of XCTR Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-05 4:45 ` Eric Biggers [this message] 2022-05-05 4:45 ` Eric Biggers 2022-05-04 0:18 ` [PATCH v6 5/9] crypto: arm64/aes-xctr: " Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-06 5:49 ` Eric Biggers 2022-05-06 5:49 ` Eric Biggers 2022-05-04 0:18 ` [PATCH v6 6/9] crypto: arm64/aes-xctr: Improve readability of XCTR and CTR modes Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-05 6:49 ` Ard Biesheuvel 2022-05-05 6:49 ` Ard Biesheuvel 2022-05-06 5:41 ` Eric Biggers 2022-05-06 5:41 ` Eric Biggers 2022-05-06 21:22 ` Nathan Huckleberry 2022-05-06 21:22 ` Nathan Huckleberry 2022-05-04 0:18 ` [PATCH v6 7/9] crypto: x86/polyval: Add PCLMULQDQ accelerated implementation of POLYVAL Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-05 5:08 ` Eric Biggers 2022-05-05 5:08 ` Eric Biggers 2022-05-04 0:18 ` [PATCH v6 8/9] crypto: arm64/polyval: Add PMULL " Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry 2022-05-05 5:56 ` Eric Biggers 2022-05-05 5:56 ` Eric Biggers 2022-05-04 0:18 ` [PATCH v6 9/9] fscrypt: Add HCTR2 support for filename encryption Nathan Huckleberry 2022-05-04 0:18 ` Nathan Huckleberry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YnNWT139+XAJ7zC1@sol.localdomain \ --to=ebiggers@kernel.org \ --cc=ardb@kernel.org \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-fscrypt@vger.kernel.org \ --cc=nhuck@google.com \ --cc=paulcrowley@google.com \ --cc=samitolvanen@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.