From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Yonggang Luo <luoyonggang@gmail.com>
Subject: Re: [PATCH] docs/about: Update the support statement for Windows
Date: Thu, 5 May 2022 12:55:57 +0100 [thread overview]
Message-ID: <YnO7TUI4RV+6+WPH@redhat.com> (raw)
In-Reply-To: <YnOHgZWHZ3fdYXqM@redhat.com>
On Thu, May 05, 2022 at 09:14:57AM +0100, Daniel P. Berrangé wrote:
> On Thu, May 05, 2022 at 09:48:41AM +0200, Thomas Huth wrote:
> > Our support statement for Windows currently talks about "Vista / Server
> > 2008" - which is related to the API of Windows, and this is not easy
> > to understand for the non-technical users. It might also not be quite
> > true anymore, since we only compile-test QEMU with recent toolchains.
>
> We documented Vista / Server 2008 because that is what our code is
> declaring it wants in terms of Windows public APIs:
>
> In osdep.h we have:
>
> #ifdef _WIN32
> /* as defined in sdkddkver.h */
> #ifndef _WIN32_WINNT
> #define _WIN32_WINNT 0x0600 /* Vista */
> #endif
>
> which tells Mingw / MSys not to expose windows header file declarations
> that post-date Vista.
Of course we rely on 3rd party libraries and in particular GLib2 is
mandatory, and it also set _WIN32_WINNT. So our constraint is the
newer of the _WIN32_WINNT constraint set by QEMU and whatever version
of GLib2 being compiled against.
QEMU sets a min GLib of 2.56, and that version of GLib sets 0x0601
which means Windows >= 7. So even though QEMU only asks for Vista,
in practice our minimum is 7.
Given that we should increase QEMU's own _WIN32_WINNT value to 0x601
too, since its impossible to build with older GLib than 2.56.
Next time we bump GLib min version, we should remember to check
their _WIN32_WINNT value.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-05-05 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 7:48 [PATCH] docs/about: Update the support statement for Windows Thomas Huth
2022-05-05 8:14 ` Daniel P. Berrangé
2022-05-05 11:55 ` Daniel P. Berrangé [this message]
2022-05-05 14:12 ` Thomas Huth
2022-05-05 15:09 ` Daniel P. Berrangé
2022-05-12 6:59 ` Thomas Huth
2022-05-05 8:27 ` Peter Maydell
2022-05-05 9:14 ` Stefan Weil via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnO7TUI4RV+6+WPH@redhat.com \
--to=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.