From: Mark Brown <broonie@kernel.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openbmc@lists.ozlabs.org, MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding
Date: Thu, 5 May 2022 13:05:19 +0100 [thread overview]
Message-ID: <YnO9fxkuk6AnEhLl@sirena.org.uk> (raw)
In-Reply-To: <YnLxjJI8Vu3LqAnL@hatter.bewilderbeest.net>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
On Wed, May 04, 2022 at 02:35:08PM -0700, Zev Weiss wrote:
> On Wed, May 04, 2022 at 01:49:12PM PDT, Mark Brown wrote:
> > For example if the output comes out on a socket then that socket should
> > be described.
> Okay -- in the case of an Open19 power shelf like the ahe-50dc, there are 50
> instances of this, 48 of which are in four ganged connectors each with 12
> pairs of pins, but two of which have their own dedicated little individual
> sockets. The connectors are physically different, but they're all identical
> as far as software is concerned, so I'm not clear on why it would need to be
> expressed in any DT properties or the like. Or did you just mean
> explanatory free-form text in the description field?
Explanatory description would be one example of something that should be
described, yes - if there is control for switching the supplies on and
off the user is going to need to be able to figure out which software
control corresponds to which physical connection. Other devices may
have more things that need autoamtion (eg, jack detection).
> > Sure, but there's no reason why it can't scale down to something
> > simpler. It's easier to support something simpler than have to extend
> > to support something more complicated.
> Alright, so would you suggest creating something like
> drivers/extcon/extcon-regulator-output.c, and just having its extcon
> functionality be something of a stub for now?
I'm not super familiar with extcon but that seems plausible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openbmc@lists.ozlabs.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding
Date: Thu, 5 May 2022 13:05:19 +0100 [thread overview]
Message-ID: <YnO9fxkuk6AnEhLl@sirena.org.uk> (raw)
In-Reply-To: <YnLxjJI8Vu3LqAnL@hatter.bewilderbeest.net>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
On Wed, May 04, 2022 at 02:35:08PM -0700, Zev Weiss wrote:
> On Wed, May 04, 2022 at 01:49:12PM PDT, Mark Brown wrote:
> > For example if the output comes out on a socket then that socket should
> > be described.
> Okay -- in the case of an Open19 power shelf like the ahe-50dc, there are 50
> instances of this, 48 of which are in four ganged connectors each with 12
> pairs of pins, but two of which have their own dedicated little individual
> sockets. The connectors are physically different, but they're all identical
> as far as software is concerned, so I'm not clear on why it would need to be
> expressed in any DT properties or the like. Or did you just mean
> explanatory free-form text in the description field?
Explanatory description would be one example of something that should be
described, yes - if there is control for switching the supplies on and
off the user is going to need to be able to figure out which software
control corresponds to which physical connection. Other devices may
have more things that need autoamtion (eg, jack detection).
> > Sure, but there's no reason why it can't scale down to something
> > simpler. It's easier to support something simpler than have to extend
> > to support something more complicated.
> Alright, so would you suggest creating something like
> drivers/extcon/extcon-regulator-output.c, and just having its extcon
> functionality be something of a stub for now?
I'm not super familiar with extcon but that seems plausible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-05-05 12:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 6:52 [PATCH 1/6] dt-bindings: regulator: Add regulator-external-output property Zev Weiss
2022-05-04 6:52 ` Zev Weiss
2022-05-04 6:52 ` [PATCH 2/6] dt-bindings: regulator: Add reg-external-output binding Zev Weiss
2022-05-04 6:52 ` Zev Weiss
2022-05-04 12:55 ` Mark Brown
2022-05-04 12:55 ` Mark Brown
2022-05-04 20:33 ` Zev Weiss
2022-05-04 20:33 ` Zev Weiss
2022-05-04 20:49 ` Mark Brown
2022-05-04 20:49 ` Mark Brown
2022-05-04 21:35 ` Zev Weiss
2022-05-04 21:35 ` Zev Weiss
2022-05-05 12:05 ` Mark Brown [this message]
2022-05-05 12:05 ` Mark Brown
2022-05-05 8:33 ` Krzysztof Kozlowski
2022-05-04 6:52 ` [PATCH 3/6] regulator: core: Add error flags to sysfs attributes Zev Weiss
2022-05-04 6:52 ` Zev Weiss
2022-05-04 6:52 ` [PATCH 4/6] regulator: core: Add external-output support Zev Weiss
2022-05-04 6:52 ` Zev Weiss
2022-05-04 13:06 ` Mark Brown
2022-05-04 13:06 ` Mark Brown
2022-05-04 6:52 ` [PATCH 5/6] regulator: core: Add external get type Zev Weiss
2022-05-04 6:52 ` Zev Weiss
2022-05-04 6:52 ` [PATCH 6/6] regulator: core: Add external-consumer driver Zev Weiss
2022-05-04 6:52 ` Zev Weiss
2022-05-04 12:36 ` [PATCH 1/6] dt-bindings: regulator: Add regulator-external-output property Mark Brown
2022-05-04 12:36 ` Mark Brown
2022-05-04 20:54 ` (subset) " Mark Brown
2022-05-04 20:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnO9fxkuk6AnEhLl@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.