From: Nathan Chancellor <nathan@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v2] i2c: at91: use dma safe buffers
Date: Thu, 5 May 2022 07:51:42 -0700 [thread overview]
Message-ID: <YnPkfrI4Udl9lMR8@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220407150828.202513-1-michael@walle.cc>
On Thu, Apr 07, 2022 at 05:08:28PM +0200, Michael Walle wrote:
> The supplied buffer might be on the stack and we get the following error
> message:
> [ 3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory
>
> Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if
> necessary.
>
> Fixes: 60937b2cdbf9 ("i2c: at91: add dma support")
> Signed-off-by: Michael Walle <michael@walle.cc>
> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> changes since v1:
> - remove extra empty line
> - add fixes tag as suggested by Codrin
>
> drivers/i2c/busses/i2c-at91-master.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
> index b0eae94909f4..5eca3b3bb609 100644
> --- a/drivers/i2c/busses/i2c-at91-master.c
> +++ b/drivers/i2c/busses/i2c-at91-master.c
> @@ -656,6 +656,7 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)
> unsigned int_addr_flag = 0;
> struct i2c_msg *m_start = msg;
> bool is_read;
> + u8 *dma_buf;
>
> dev_dbg(&adap->dev, "at91_xfer: processing %d messages:\n", num);
>
> @@ -703,7 +704,17 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)
> dev->msg = m_start;
> dev->recv_len_abort = false;
>
> + if (dev->use_dma) {
> + dma_buf = i2c_get_dma_safe_msg_buf(m_start, 1);
> + if (!dma_buf) {
> + ret = -ENOMEM;
> + goto out;
> + }
> + dev->buf = dma_buf;
> + }
> +
> ret = at91_do_twi_transfer(dev);
> + i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
>
> ret = (ret < 0) ? ret : num;
> out:
> --
> 2.30.2
>
>
This change as commit 03fbb903c8bf ("i2c: at91: use dma safe buffers")
causes the following clang warning:
drivers/i2c/busses/i2c-at91-master.c:707:6: error: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (dev->use_dma) {
^~~~~~~~~~~~
drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here
i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
^~~~~~~
drivers/i2c/busses/i2c-at91-master.c:707:2: note: remove the 'if' if its condition is always true
if (dev->use_dma) {
^~~~~~~~~~~~~~~~~~
drivers/i2c/busses/i2c-at91-master.c:659:13: note: initialize the variable 'dma_buf' to silence this warning
u8 *dma_buf;
^
= NULL
1 error generated.
Should this variable be initialized or should the call to
i2c_put_dma_safe_msg_buf() be moved into the if statement?
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] i2c: at91: use dma safe buffers
Date: Thu, 5 May 2022 07:51:42 -0700 [thread overview]
Message-ID: <YnPkfrI4Udl9lMR8@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220407150828.202513-1-michael@walle.cc>
On Thu, Apr 07, 2022 at 05:08:28PM +0200, Michael Walle wrote:
> The supplied buffer might be on the stack and we get the following error
> message:
> [ 3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory
>
> Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if
> necessary.
>
> Fixes: 60937b2cdbf9 ("i2c: at91: add dma support")
> Signed-off-by: Michael Walle <michael@walle.cc>
> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> changes since v1:
> - remove extra empty line
> - add fixes tag as suggested by Codrin
>
> drivers/i2c/busses/i2c-at91-master.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
> index b0eae94909f4..5eca3b3bb609 100644
> --- a/drivers/i2c/busses/i2c-at91-master.c
> +++ b/drivers/i2c/busses/i2c-at91-master.c
> @@ -656,6 +656,7 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)
> unsigned int_addr_flag = 0;
> struct i2c_msg *m_start = msg;
> bool is_read;
> + u8 *dma_buf;
>
> dev_dbg(&adap->dev, "at91_xfer: processing %d messages:\n", num);
>
> @@ -703,7 +704,17 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)
> dev->msg = m_start;
> dev->recv_len_abort = false;
>
> + if (dev->use_dma) {
> + dma_buf = i2c_get_dma_safe_msg_buf(m_start, 1);
> + if (!dma_buf) {
> + ret = -ENOMEM;
> + goto out;
> + }
> + dev->buf = dma_buf;
> + }
> +
> ret = at91_do_twi_transfer(dev);
> + i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
>
> ret = (ret < 0) ? ret : num;
> out:
> --
> 2.30.2
>
>
This change as commit 03fbb903c8bf ("i2c: at91: use dma safe buffers")
causes the following clang warning:
drivers/i2c/busses/i2c-at91-master.c:707:6: error: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (dev->use_dma) {
^~~~~~~~~~~~
drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here
i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
^~~~~~~
drivers/i2c/busses/i2c-at91-master.c:707:2: note: remove the 'if' if its condition is always true
if (dev->use_dma) {
^~~~~~~~~~~~~~~~~~
drivers/i2c/busses/i2c-at91-master.c:659:13: note: initialize the variable 'dma_buf' to silence this warning
u8 *dma_buf;
^
= NULL
1 error generated.
Should this variable be initialized or should the call to
i2c_put_dma_safe_msg_buf() be moved into the if statement?
Cheers,
Nathan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-05 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 15:08 [PATCH v2] i2c: at91: use dma safe buffers Michael Walle
2022-04-07 15:08 ` Michael Walle
2022-05-02 21:36 ` Michael Walle
2022-05-02 21:36 ` Michael Walle
2022-05-04 20:23 ` Wolfram Sang
2022-05-04 20:23 ` Wolfram Sang
2022-05-04 20:48 ` Michael Walle
2022-05-04 20:48 ` Michael Walle
2022-05-05 14:51 ` Nathan Chancellor [this message]
2022-05-05 14:51 ` Nathan Chancellor
2022-05-05 15:11 ` Michael Walle
2022-05-05 15:11 ` Michael Walle
2022-05-05 15:18 ` Nathan Chancellor
2022-05-05 15:18 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnPkfrI4Udl9lMR8@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michael@walle.cc \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.