[PATCH] nvme: uninitialized return in nvme_ns_head_chr_uring_cmd()

[PATCH] nvme: uninitialized return in nvme_ns_head_chr_uring_cmd()

[Dan Carpenter]

The "ret" value is not set if "ns" is zero.

Fixes: 86116c2f6fee ("nvme: wire-up uring-cmd support for io-passthru on char-device.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/nvme/host/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index 4b91e452768b..c118559d47f0 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -688,7 +688,7 @@ int nvme_ns_head_chr_uring_cmd(struct io_uring_cmd *ioucmd,
 	struct nvme_ns_head *head = container_of(cdev, struct nvme_ns_head, cdev);
 	int srcu_idx = srcu_read_lock(&head->srcu);
 	struct nvme_ns *ns = nvme_find_path(head);
-	int ret;
+	int ret = 0;
 
 	if (ns)
 		ret = nvme_ns_uring_cmd(ns, ioucmd, issue_flags);
-- 
2.35.1

Re: [PATCH] nvme: uninitialized return in nvme_ns_head_chr_uring_cmd()

[Kanchan Joshi]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Mon, May 09, 2022 at 12:06:42PM +0300, Dan Carpenter wrote:
>The "ret" value is not set if "ns" is zero.
>
>Fixes: 86116c2f6fee ("nvme: wire-up uring-cmd support for io-passthru on char-device.")
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

This change is already present in the branch.
Folded during -
https://lore.kernel.org/linux-nvme/20220506150357.2443040-1-nathan@kernel.org/

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]