All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:56 ` Nícolas F. R. A. Prado
  0 siblings, 0 replies; 12+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-09 18:56 UTC (permalink / raw)
  To: Mark Brown
  Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
	Jiaxin Yu, Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek

This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
was merged while the property name and definition were still being
discussed. Revert the commit for now and a follow up commit will re-add
the property after it is further discussed and reviewed.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
index 5b03c8dbf318..7a25bc9b8060 100644
--- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
@@ -54,11 +54,6 @@ properties:
       - const: aud_infra_clk
       - const: aud_infra_26m_clk
 
-patternProperties:
-  "^i2s[0-35-9]-share$":
-    description: Name of the I2S bus that is shared with this bus
-    pattern: "^I2S[0-35-9]$"
-
 required:
   - compatible
   - interrupts
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:56 ` Nícolas F. R. A. Prado
  0 siblings, 0 replies; 12+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-09 18:56 UTC (permalink / raw)
  To: Mark Brown
  Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
	Jiaxin Yu, Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek

This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
was merged while the property name and definition were still being
discussed. Revert the commit for now and a follow up commit will re-add
the property after it is further discussed and reviewed.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
index 5b03c8dbf318..7a25bc9b8060 100644
--- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
@@ -54,11 +54,6 @@ properties:
       - const: aud_infra_clk
       - const: aud_infra_26m_clk
 
-patternProperties:
-  "^i2s[0-35-9]-share$":
-    description: Name of the I2S bus that is shared with this bus
-    pattern: "^I2S[0-35-9]$"
-
 required:
   - compatible
   - interrupts
-- 
2.36.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:56 ` Nícolas F. R. A. Prado
  0 siblings, 0 replies; 12+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-09 18:56 UTC (permalink / raw)
  To: Mark Brown
  Cc: devicetree, alsa-devel, Nícolas F. R. A. Prado,
	Liam Girdwood, Jiaxin Yu, linux-kernel, Shane Chien, Rob Herring,
	linux-mediatek, Matthias Brugger, Krzysztof Kozlowski, kernel,
	linux-arm-kernel, AngeloGioacchino Del Regno

This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
was merged while the property name and definition were still being
discussed. Revert the commit for now and a follow up commit will re-add
the property after it is further discussed and reviewed.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
index 5b03c8dbf318..7a25bc9b8060 100644
--- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
@@ -54,11 +54,6 @@ properties:
       - const: aud_infra_clk
       - const: aud_infra_26m_clk
 
-patternProperties:
-  "^i2s[0-35-9]-share$":
-    description: Name of the I2S bus that is shared with this bus
-    pattern: "^I2S[0-35-9]$"
-
 required:
   - compatible
   - interrupts
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:56 ` Nícolas F. R. A. Prado
  0 siblings, 0 replies; 12+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-05-09 18:56 UTC (permalink / raw)
  To: Mark Brown
  Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
	Jiaxin Yu, Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek

This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
was merged while the property name and definition were still being
discussed. Revert the commit for now and a follow up commit will re-add
the property after it is further discussed and reviewed.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
index 5b03c8dbf318..7a25bc9b8060 100644
--- a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
+++ b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
@@ -54,11 +54,6 @@ properties:
       - const: aud_infra_clk
       - const: aud_infra_26m_clk
 
-patternProperties:
-  "^i2s[0-35-9]-share$":
-    description: Name of the I2S bus that is shared with this bus
-    pattern: "^I2S[0-35-9]$"
-
 required:
   - compatible
   - interrupts
-- 
2.36.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
  2022-05-09 18:56 ` Nícolas F. R. A. Prado
  (?)
  (?)
@ 2022-05-09 18:58   ` Mark Brown
  -1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 18:58 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado
  Cc: kernel, AngeloGioacchino Del Regno, Jiaxin Yu,
	Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On Mon, May 09, 2022 at 02:56:25PM -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:58   ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 18:58 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado
  Cc: devicetree, alsa-devel, Liam Girdwood, Jiaxin Yu, linux-kernel,
	Shane Chien, Rob Herring, linux-mediatek, Matthias Brugger,
	Krzysztof Kozlowski, kernel, linux-arm-kernel,
	AngeloGioacchino Del Regno

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On Mon, May 09, 2022 at 02:56:25PM -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:58   ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 18:58 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado
  Cc: kernel, AngeloGioacchino Del Regno, Jiaxin Yu,
	Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek


[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]

On Mon, May 09, 2022 at 02:56:25PM -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 18:58   ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 18:58 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado
  Cc: kernel, AngeloGioacchino Del Regno, Jiaxin Yu,
	Krzysztof Kozlowski, Liam Girdwood, Matthias Brugger,
	Rob Herring, Shane Chien, alsa-devel, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek


[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]

On Mon, May 09, 2022 at 02:56:25PM -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
  2022-05-09 18:56 ` Nícolas F. R. A. Prado
  (?)
  (?)
@ 2022-05-09 19:57   ` Mark Brown
  -1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 19:57 UTC (permalink / raw)
  To: nfraprado
  Cc: angelogioacchino.delregno, linux-arm-kernel, matthias.bgg,
	robh+dt, jiaxin.yu, alsa-devel, shane.chien, lgirdwood,
	linux-mediatek, kernel, krzk+dt, linux-kernel, devicetree

On Mon, 9 May 2022 14:56:25 -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
      commit: d94d1486952b860dcedd04d0ff8ade2176418905

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 19:57   ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 19:57 UTC (permalink / raw)
  To: nfraprado
  Cc: angelogioacchino.delregno, linux-arm-kernel, matthias.bgg,
	robh+dt, jiaxin.yu, alsa-devel, shane.chien, lgirdwood,
	linux-mediatek, kernel, krzk+dt, linux-kernel, devicetree

On Mon, 9 May 2022 14:56:25 -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
      commit: d94d1486952b860dcedd04d0ff8ade2176418905

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 19:57   ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 19:57 UTC (permalink / raw)
  To: nfraprado
  Cc: devicetree, alsa-devel, lgirdwood, jiaxin.yu, linux-kernel,
	shane.chien, robh+dt, linux-mediatek, matthias.bgg, krzk+dt,
	kernel, linux-arm-kernel, angelogioacchino.delregno

On Mon, 9 May 2022 14:56:25 -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
      commit: d94d1486952b860dcedd04d0ff8ade2176418905

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
@ 2022-05-09 19:57   ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-05-09 19:57 UTC (permalink / raw)
  To: nfraprado
  Cc: angelogioacchino.delregno, linux-arm-kernel, matthias.bgg,
	robh+dt, jiaxin.yu, alsa-devel, shane.chien, lgirdwood,
	linux-mediatek, kernel, krzk+dt, linux-kernel, devicetree

On Mon, 9 May 2022 14:56:25 -0400, Nícolas F. R. A. Prado wrote:
> This reverts commit e056cf4341ae3f856f1e38da02b27cb04de4c69b. The commit
> was merged while the property name and definition were still being
> discussed. Revert the commit for now and a follow up commit will re-add
> the property after it is further discussed and reviewed.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties"
      commit: d94d1486952b860dcedd04d0ff8ade2176418905

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-05-09 19:58 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 18:56 [PATCH] Revert "ASoC: dt-bindings: mediatek: mt8192: Add i2s-share properties" Nícolas F. R. A. Prado
2022-05-09 18:56 ` Nícolas F. R. A. Prado
2022-05-09 18:56 ` Nícolas F. R. A. Prado
2022-05-09 18:56 ` Nícolas F. R. A. Prado
2022-05-09 18:58 ` Mark Brown
2022-05-09 18:58   ` Mark Brown
2022-05-09 18:58   ` Mark Brown
2022-05-09 18:58   ` Mark Brown
2022-05-09 19:57 ` Mark Brown
2022-05-09 19:57   ` Mark Brown
2022-05-09 19:57   ` Mark Brown
2022-05-09 19:57   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.