All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
	Melissa Wen <melissa.srw@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kernel-dev@igalia.com
Subject: Re: [PATCH] drm/vkms: Update vkms_composer_worker documentation
Date: Wed, 25 May 2022 17:41:00 +0200	[thread overview]
Message-ID: <Yo5ODIGuMI7GcoYZ@phenom.ffwll.local> (raw)
In-Reply-To: <20220521191342.23520-1-andrealmeid@igalia.com>

On Sat, May 21, 2022 at 04:13:42PM -0300, André Almeida wrote:
> Since commit ba420afab565 ("drm/vkms: Bugfix racing hrtimer vblank
> handle") the work is scheduled at vkms_vblank_simulate() and since
> commit 5ef8100a3919 ("drm/vkms: flush crc workers earlier in commit
> flow") the work is flushed at vkms_atomic_commit_tail(). Update function
> commment to reflect that.
> 
> Signed-off-by: André Almeida <andrealmeid@igalia.com>

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index c6a1036bf2ea..914c0ac7dc8b 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -213,7 +213,7 @@ static int compose_active_planes(void **vaddr_out,
>   *
>   * Work handler for composing and computing CRCs. work_struct scheduled in
>   * an ordered workqueue that's periodically scheduled to run by
> - * _vblank_handle() and flushed at vkms_atomic_crtc_destroy_state().
> + * vkms_vblank_simulate() and flushed at vkms_atomic_commit_tail().
>   */
>  void vkms_composer_worker(struct work_struct *work)
>  {
> -- 
> 2.36.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
	kernel-dev@igalia.com,
	Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Melissa Wen <melissa.srw@gmail.com>
Subject: Re: [PATCH] drm/vkms: Update vkms_composer_worker documentation
Date: Wed, 25 May 2022 17:41:00 +0200	[thread overview]
Message-ID: <Yo5ODIGuMI7GcoYZ@phenom.ffwll.local> (raw)
In-Reply-To: <20220521191342.23520-1-andrealmeid@igalia.com>

On Sat, May 21, 2022 at 04:13:42PM -0300, André Almeida wrote:
> Since commit ba420afab565 ("drm/vkms: Bugfix racing hrtimer vblank
> handle") the work is scheduled at vkms_vblank_simulate() and since
> commit 5ef8100a3919 ("drm/vkms: flush crc workers earlier in commit
> flow") the work is flushed at vkms_atomic_commit_tail(). Update function
> commment to reflect that.
> 
> Signed-off-by: André Almeida <andrealmeid@igalia.com>

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index c6a1036bf2ea..914c0ac7dc8b 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -213,7 +213,7 @@ static int compose_active_planes(void **vaddr_out,
>   *
>   * Work handler for composing and computing CRCs. work_struct scheduled in
>   * an ordered workqueue that's periodically scheduled to run by
> - * _vblank_handle() and flushed at vkms_atomic_crtc_destroy_state().
> + * vkms_vblank_simulate() and flushed at vkms_atomic_commit_tail().
>   */
>  void vkms_composer_worker(struct work_struct *work)
>  {
> -- 
> 2.36.0
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2022-05-25 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 19:13 [PATCH] drm/vkms: Update vkms_composer_worker documentation André Almeida
2022-05-21 19:13 ` André Almeida
2022-05-25 15:41 ` Daniel Vetter [this message]
2022-05-25 15:41   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yo5ODIGuMI7GcoYZ@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=andrealmeid@igalia.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=melissa.srw@gmail.com \
    --cc=rodrigosiqueiramelo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.