* [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()
@ 2022-05-16 7:05 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-05-16 7:05 UTC (permalink / raw)
To: Harry Wentland, Jude Shih
Cc: Leo Li, Rodrigo Siqueira, Alex Deucher, Christian König,
Pan, Xinhui, David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Roman Li, Qingqing Zhuo, Wayne Lin, Simon Ser, amd-gfx,
kernel-janitors
The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds
access.
Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6edfc0963dab..c4f122c6faec 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -770,7 +770,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
do {
dc_stat_get_dmub_notification(adev->dm.dc, ¬ify);
- if (notify.type > ARRAY_SIZE(dm->dmub_thread_offload)) {
+ if (notify.type >= ARRAY_SIZE(dm->dmub_thread_offload)) {
DRM_ERROR("DM: notify type %d invalid!", notify.type);
continue;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()
@ 2022-05-16 7:05 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-05-16 7:05 UTC (permalink / raw)
To: Harry Wentland, Jude Shih
Cc: kernel-janitors, Leo Li, Simon Ser, Qingqing Zhuo, Pan, Xinhui,
Rodrigo Siqueira, Roman Li, amd-gfx, Nicholas Kazlauskas,
David Airlie, Daniel Vetter, Wayne Lin, Alex Deucher,
Christian König
The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds
access.
Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 6edfc0963dab..c4f122c6faec 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -770,7 +770,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
do {
dc_stat_get_dmub_notification(adev->dm.dc, ¬ify);
- if (notify.type > ARRAY_SIZE(dm->dmub_thread_offload)) {
+ if (notify.type >= ARRAY_SIZE(dm->dmub_thread_offload)) {
DRM_ERROR("DM: notify type %d invalid!", notify.type);
continue;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()
2022-05-16 7:05 ` Dan Carpenter
@ 2022-05-19 20:52 ` Harry Wentland
-1 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2022-05-19 20:52 UTC (permalink / raw)
To: Dan Carpenter, Jude Shih
Cc: Leo Li, Rodrigo Siqueira, Alex Deucher, Christian König,
Pan, Xinhui, David Airlie, Daniel Vetter, Nicholas Kazlauskas,
Roman Li, Qingqing Zhuo, Wayne Lin, Simon Ser, amd-gfx,
kernel-janitors
On 2022-05-16 03:05, Dan Carpenter wrote:
> The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds
> access.
>
> Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 6edfc0963dab..c4f122c6faec 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -770,7 +770,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>
> do {
> dc_stat_get_dmub_notification(adev->dm.dc, ¬ify);
> - if (notify.type > ARRAY_SIZE(dm->dmub_thread_offload)) {
> + if (notify.type >= ARRAY_SIZE(dm->dmub_thread_offload)) {
> DRM_ERROR("DM: notify type %d invalid!", notify.type);
> continue;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()
@ 2022-05-19 20:52 ` Harry Wentland
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2022-05-19 20:52 UTC (permalink / raw)
To: Dan Carpenter, Jude Shih
Cc: kernel-janitors, Leo Li, Simon Ser, Qingqing Zhuo, Pan, Xinhui,
Rodrigo Siqueira, Roman Li, amd-gfx, Nicholas Kazlauskas,
David Airlie, Daniel Vetter, Wayne Lin, Alex Deucher,
Christian König
On 2022-05-16 03:05, Dan Carpenter wrote:
> The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds
> access.
>
> Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 6edfc0963dab..c4f122c6faec 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -770,7 +770,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>
> do {
> dc_stat_get_dmub_notification(adev->dm.dc, ¬ify);
> - if (notify.type > ARRAY_SIZE(dm->dmub_thread_offload)) {
> + if (notify.type >= ARRAY_SIZE(dm->dmub_thread_offload)) {
> DRM_ERROR("DM: notify type %d invalid!", notify.type);
> continue;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()
2022-05-19 20:52 ` Harry Wentland
@ 2022-05-20 14:39 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-05-20 14:39 UTC (permalink / raw)
To: Harry Wentland
Cc: Dan Carpenter, Jude Shih, kernel-janitors, Leo Li, Simon Ser,
Qingqing Zhuo, Pan, Xinhui, Rodrigo Siqueira, Roman Li,
amd-gfx list, Nicholas Kazlauskas, David Airlie, Daniel Vetter,
Wayne Lin, Alex Deucher, Christian König
Applied. Thanks!
Alex
On Thu, May 19, 2022 at 4:53 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2022-05-16 03:05, Dan Carpenter wrote:
> > The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds
> > access.
> >
> > Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt handling")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 6edfc0963dab..c4f122c6faec 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -770,7 +770,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
> >
> > do {
> > dc_stat_get_dmub_notification(adev->dm.dc, ¬ify);
> > - if (notify.type > ARRAY_SIZE(dm->dmub_thread_offload)) {
> > + if (notify.type >= ARRAY_SIZE(dm->dmub_thread_offload)) {
> > DRM_ERROR("DM: notify type %d invalid!", notify.type);
> > continue;
> > }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq()
@ 2022-05-20 14:39 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-05-20 14:39 UTC (permalink / raw)
To: Harry Wentland
Cc: Wayne Lin, Leo Li, Jude Shih, Qingqing Zhuo, Pan, Xinhui,
kernel-janitors, Roman Li, amd-gfx list, Christian König,
David Airlie, Daniel Vetter, Simon Ser, Alex Deucher,
Rodrigo Siqueira, Nicholas Kazlauskas, Dan Carpenter
Applied. Thanks!
Alex
On Thu, May 19, 2022 at 4:53 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2022-05-16 03:05, Dan Carpenter wrote:
> > The > ARRAY_SIZE() should be >= ARRAY_SIZE() to prevent an out of bounds
> > access.
> >
> > Fixes: e27c41d5b068 ("drm/amd/display: Support for DMUB HPD interrupt handling")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 6edfc0963dab..c4f122c6faec 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -770,7 +770,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
> >
> > do {
> > dc_stat_get_dmub_notification(adev->dm.dc, ¬ify);
> > - if (notify.type > ARRAY_SIZE(dm->dmub_thread_offload)) {
> > + if (notify.type >= ARRAY_SIZE(dm->dmub_thread_offload)) {
> > DRM_ERROR("DM: notify type %d invalid!", notify.type);
> > continue;
> > }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-20 14:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 7:05 [PATCH] drm/amdgpu: Off by one in dm_dmub_outbox1_low_irq() Dan Carpenter
2022-05-16 7:05 ` Dan Carpenter
2022-05-19 20:52 ` Harry Wentland
2022-05-19 20:52 ` Harry Wentland
2022-05-20 14:39 ` Alex Deucher
2022-05-20 14:39 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.