* [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows()
@ 2022-05-18 17:33 Dan Carpenter
2022-05-28 13:00 ` Corentin Labbe
2022-06-10 9:14 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-05-18 17:33 UTC (permalink / raw)
To: Corentin Labbe
Cc: Herbert Xu, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-crypto, linux-sunxi, kernel-janitors
These failure paths should return -ENOMEM. Currently they return
success.
Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
Fixes: 8eec4563f152 ("crypto: sun8i-ss - do not allocate memory when handling hash requests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
.../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index 98593a0cff69..ac2329e2b0e5 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -528,25 +528,33 @@ static int allocate_flows(struct sun8i_ss_dev *ss)
ss->flows[i].biv = devm_kmalloc(ss->dev, AES_BLOCK_SIZE,
GFP_KERNEL | GFP_DMA);
- if (!ss->flows[i].biv)
+ if (!ss->flows[i].biv) {
+ err = -ENOMEM;
goto error_engine;
+ }
for (j = 0; j < MAX_SG; j++) {
ss->flows[i].iv[j] = devm_kmalloc(ss->dev, AES_BLOCK_SIZE,
GFP_KERNEL | GFP_DMA);
- if (!ss->flows[i].iv[j])
+ if (!ss->flows[i].iv[j]) {
+ err = -ENOMEM;
goto error_engine;
+ }
}
/* the padding could be up to two block. */
ss->flows[i].pad = devm_kmalloc(ss->dev, MAX_PAD_SIZE,
GFP_KERNEL | GFP_DMA);
- if (!ss->flows[i].pad)
+ if (!ss->flows[i].pad) {
+ err = -ENOMEM;
goto error_engine;
+ }
ss->flows[i].result = devm_kmalloc(ss->dev, SHA256_DIGEST_SIZE,
GFP_KERNEL | GFP_DMA);
- if (!ss->flows[i].result)
+ if (!ss->flows[i].result) {
+ err = -ENOMEM;
goto error_engine;
+ }
ss->flows[i].engine = crypto_engine_alloc_init(ss->dev, true);
if (!ss->flows[i].engine) {
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows()
2022-05-18 17:33 [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows() Dan Carpenter
@ 2022-05-28 13:00 ` Corentin Labbe
2022-06-10 9:14 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Corentin Labbe @ 2022-05-28 13:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Herbert Xu, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-crypto, linux-sunxi, kernel-janitors
Le Wed, May 18, 2022 at 08:33:44PM +0300, Dan Carpenter a écrit :
> These failure paths should return -ENOMEM. Currently they return
> success.
>
> Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
> Fixes: 8eec4563f152 ("crypto: sun8i-ss - do not allocate memory when handling hash requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-on: sun8i-a83t-bananapi-m3
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows()
2022-05-18 17:33 [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows() Dan Carpenter
2022-05-28 13:00 ` Corentin Labbe
@ 2022-06-10 9:14 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-06-10 9:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Corentin Labbe, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
linux-crypto, linux-sunxi, kernel-janitors
On Wed, May 18, 2022 at 08:33:44PM +0300, Dan Carpenter wrote:
> These failure paths should return -ENOMEM. Currently they return
> success.
>
> Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
> Fixes: 8eec4563f152 ("crypto: sun8i-ss - do not allocate memory when handling hash requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> .../crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-10 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18 17:33 [PATCH] crypto: sun8i-ss - fix error codes in allocate_flows() Dan Carpenter
2022-05-28 13:00 ` Corentin Labbe
2022-06-10 9:14 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.