From: Andrew Lunn <andrew@lunn.ch> To: Maxime Chevallier <maxime.chevallier@bootlin.com> Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, Richard Cochran <richardcochran@gmail.com>, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next 4/6] net: phy: Add support for inband extensions Date: Thu, 19 May 2022 16:10:15 +0200 [thread overview] Message-ID: <YoZPx3s353hJcGnt@lunn.ch> (raw) In-Reply-To: <20220519135647.465653-5-maxime.chevallier@bootlin.com> > +static int phy_set_inband_ext(struct phy_device *phydev, u32 mask, u32 ext) > +{ > + int ret; > + > + if (!phy_interface_has_inband_ext(phydev->interface)) > + return -EOPNOTSUPP; > + > + if (!phydev->drv->inband_ext_config) > + return -EOPNOTSUPP; > + > + ret = phydev->drv->inband_ext_config(phydev, mask, ext); > + if (ret) > + return ret; > + > + phydev->inband_ext.enabled &= ~mask; > + phydev->inband_ext.enabled |= (mask & ext); You appear to be missing locking in this patchset. > +int phy_inband_ext_enable(struct phy_device *phydev, u32 ext) > +{ > + return phy_set_inband_ext(phydev, ext, ext); There should be an -EOPNOTSUPP here is requested to enable an extension which is not available. > +} > +EXPORT_SYMBOL(phy_inband_ext_enable); > + > +int phy_inband_ext_disable(struct phy_device *phydev, u32 ext) > +{ > + return phy_set_inband_ext(phydev, ext, 0); And the same here. > +} > +EXPORT_SYMBOL(phy_inband_ext_disable); > + > +int phy_inband_ext_set_available(struct phy_device *phydev, u32 mask, u32 ext) > +{ > + if (!(mask & phydev->drv->inband_ext)) > + return -EOPNOTSUPP; > + > + phydev->inband_ext.available &= ~mask; > + phydev->inband_ext.available |= (mask & ext); > + > + return 0; > +} > +EXPORT_SYMBOL(phy_inband_ext_set_available); > + > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 4a2731c78590..6b08f49bce5b 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -190,6 +190,21 @@ static inline void phy_interface_set_rgmii(unsigned long *intf) > __set_bit(PHY_INTERFACE_MODE_RGMII_TXID, intf); > } > > +/* > + * TODO : Doc > + */ > +enum { > + __PHY_INBAND_EXT_PCH = 0, > +}; > + > +#define PHY_INBAND_EXT_PCH BIT(__PHY_INBAND_EXT_PCH) the documentation is important here, since it makes it clear if these are values directly taken from the specification, or if these are linux specific, and the driver needs to map from linux to whatever the spec calls them. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Maxime Chevallier <maxime.chevallier@bootlin.com> Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Florian Fainelli <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, Richard Cochran <richardcochran@gmail.com>, Horatiu.Vultur@microchip.com, Allan.Nielsen@microchip.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next 4/6] net: phy: Add support for inband extensions Date: Thu, 19 May 2022 16:10:15 +0200 [thread overview] Message-ID: <YoZPx3s353hJcGnt@lunn.ch> (raw) In-Reply-To: <20220519135647.465653-5-maxime.chevallier@bootlin.com> > +static int phy_set_inband_ext(struct phy_device *phydev, u32 mask, u32 ext) > +{ > + int ret; > + > + if (!phy_interface_has_inband_ext(phydev->interface)) > + return -EOPNOTSUPP; > + > + if (!phydev->drv->inband_ext_config) > + return -EOPNOTSUPP; > + > + ret = phydev->drv->inband_ext_config(phydev, mask, ext); > + if (ret) > + return ret; > + > + phydev->inband_ext.enabled &= ~mask; > + phydev->inband_ext.enabled |= (mask & ext); You appear to be missing locking in this patchset. > +int phy_inband_ext_enable(struct phy_device *phydev, u32 ext) > +{ > + return phy_set_inband_ext(phydev, ext, ext); There should be an -EOPNOTSUPP here is requested to enable an extension which is not available. > +} > +EXPORT_SYMBOL(phy_inband_ext_enable); > + > +int phy_inband_ext_disable(struct phy_device *phydev, u32 ext) > +{ > + return phy_set_inband_ext(phydev, ext, 0); And the same here. > +} > +EXPORT_SYMBOL(phy_inband_ext_disable); > + > +int phy_inband_ext_set_available(struct phy_device *phydev, u32 mask, u32 ext) > +{ > + if (!(mask & phydev->drv->inband_ext)) > + return -EOPNOTSUPP; > + > + phydev->inband_ext.available &= ~mask; > + phydev->inband_ext.available |= (mask & ext); > + > + return 0; > +} > +EXPORT_SYMBOL(phy_inband_ext_set_available); > + > diff --git a/include/linux/phy.h b/include/linux/phy.h > index 4a2731c78590..6b08f49bce5b 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -190,6 +190,21 @@ static inline void phy_interface_set_rgmii(unsigned long *intf) > __set_bit(PHY_INTERFACE_MODE_RGMII_TXID, intf); > } > > +/* > + * TODO : Doc > + */ > +enum { > + __PHY_INBAND_EXT_PCH = 0, > +}; > + > +#define PHY_INBAND_EXT_PCH BIT(__PHY_INBAND_EXT_PCH) the documentation is important here, since it makes it clear if these are values directly taken from the specification, or if these are linux specific, and the driver needs to map from linux to whatever the spec calls them. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-19 14:10 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 13:56 [PATCH net-next 0/6] net: Introduce Ethernet Inband Extensions Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier 2022-05-19 13:56 ` [PATCH net-next 1/6] net: phy: Introduce QUSGMII PHY mode Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier 2022-05-19 13:56 ` [PATCH net-next 2/6] dt-bindings: net: ethernet-controller: add QUSGMII mode Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier 2022-06-01 21:10 ` Rob Herring 2022-06-01 21:10 ` Rob Herring 2022-05-19 13:56 ` [PATCH net-next 3/6] net: lan966x: Add QUSGMII support for lan966x Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier 2022-05-19 14:26 ` Russell King (Oracle) 2022-05-19 14:26 ` Russell King (Oracle) 2022-07-27 13:48 ` Maxime Chevallier 2022-07-27 13:48 ` Maxime Chevallier 2022-05-19 13:56 ` [PATCH net-next 4/6] net: phy: Add support for inband extensions Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier 2022-05-19 14:10 ` Andrew Lunn [this message] 2022-05-19 14:10 ` Andrew Lunn 2022-05-19 14:28 ` Andrew Lunn 2022-05-19 14:28 ` Andrew Lunn 2022-05-19 13:56 ` [PATCH net-next 5/6] net: lan966x: Allow using PCH extension for PTP Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier 2022-05-19 13:56 ` [PATCH net-next 6/6] net: phy: micrel: Add QUSGMII support and PCH extension Maxime Chevallier 2022-05-19 13:56 ` Maxime Chevallier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YoZPx3s353hJcGnt@lunn.ch \ --to=andrew@lunn.ch \ --cc=Allan.Nielsen@microchip.com \ --cc=Horatiu.Vultur@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=maxime.chevallier@bootlin.com \ --cc=netdev@vger.kernel.org \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.