All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	ldv-project@linuxtesting.org
Subject: Re: [PATCH] ASoC: max98090: Remove unneeded check in max98090_put_enab_tlv()
Date: Thu, 19 May 2022 21:07:22 +0100	[thread overview]
Message-ID: <YoajesD+D1W3ZV7/@sirena.org.uk> (raw)
In-Reply-To: <ce6853a9-6789-f151-3193-59b7dd73bd27@ispras.ru>

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Thu, May 19, 2022 at 09:27:25PM +0300, Alexey Khoroshilov wrote:
> On 19.05.2022 20:54, Mark Brown wrote:

> > Oh, the check won't be working properly - it's just that like I say the
> > fix is to move rather than remove it so it's operating on the signed
> > value.

> Do you mean something like this?

That looks about right.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: ldv-project@linuxtesting.org, alsa-devel@alsa-project.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: max98090: Remove unneeded check in max98090_put_enab_tlv()
Date: Thu, 19 May 2022 21:07:22 +0100	[thread overview]
Message-ID: <YoajesD+D1W3ZV7/@sirena.org.uk> (raw)
In-Reply-To: <ce6853a9-6789-f151-3193-59b7dd73bd27@ispras.ru>

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Thu, May 19, 2022 at 09:27:25PM +0300, Alexey Khoroshilov wrote:
> On 19.05.2022 20:54, Mark Brown wrote:

> > Oh, the check won't be working properly - it's just that like I say the
> > fix is to move rather than remove it so it's operating on the signed
> > value.

> Do you mean something like this?

That looks about right.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-05-19 20:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 17:10 [PATCH] ASoC: max98090: Remove unneeded check in max98090_put_enab_tlv() Alexey Khoroshilov
2022-05-19 17:10 ` Alexey Khoroshilov
2022-05-19 17:29 ` Mark Brown
2022-05-19 17:29   ` Mark Brown
2022-05-19 17:49   ` Pierre-Louis Bossart
2022-05-19 17:49     ` Pierre-Louis Bossart
2022-05-19 17:49   ` Alexey Khoroshilov
2022-05-19 17:49     ` Alexey Khoroshilov
2022-05-19 17:54     ` Mark Brown
2022-05-19 17:54       ` Mark Brown
2022-05-19 18:27       ` Alexey Khoroshilov
2022-05-19 18:27         ` Alexey Khoroshilov
2022-05-19 20:07         ` Mark Brown [this message]
2022-05-19 20:07           ` Mark Brown
2022-05-19 20:13           ` Alexey Khoroshilov
2022-05-19 20:13             ` Alexey Khoroshilov
2022-05-19 20:31             ` Mark Brown
2022-05-19 20:31               ` Mark Brown
2022-05-19 22:31           ` [PATCH] ASoC: max98090: Move check for invalid values before casting " Alexey Khoroshilov
2022-05-19 22:31             ` Alexey Khoroshilov
2022-05-20 16:58             ` Mark Brown
2022-05-20 16:58               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoajesD+D1W3ZV7/@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.